Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Hi On Tue, Mar 15, 2016 at 6:23 AM, Muhammad Aqeel wrote: > Hi Dave, > > On Mon, Mar 14, 2016 at 7:06 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Mar 14, 2016 at 1:46 PM, Muhammad Aqeel >> wrote: >> > Hi Dave,

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Hi On Mon, Mar 14, 2016 at 1:46 PM, Muhammad Aqeel wrote: > Hi Dave, > > I tested the build after your commit. There were minor bugs in your changes > which prevented the packaging of pgadmin4 sources. > > - It needed a space after * in recursive include

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Hi Dave, I tested the build after your commit. There were minor bugs in your changes which prevented the packaging of pgadmin4 sources. - It needed a space after * in recursive include statement of manifest.in - \n is not interpreted as new line. I fixed both issues in attached patch and tested

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Thanks Dave. --Aqeel On Mon, Mar 14, 2016 at 3:28 PM, Dave Page wrote: > Thanks - committed with some minor tweaks: > > - Avoid packaging *.pyc and pgadmin4.db > - Add some more keywords > - Minor re-arrangement of setup_pip.py and the Makefile. > > Thanks again! > > On Mon,

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Thanks - committed with some minor tweaks: - Avoid packaging *.pyc and pgadmin4.db - Add some more keywords - Minor re-arrangement of setup_pip.py and the Makefile. Thanks again! On Mon, Mar 14, 2016 at 6:33 AM, Muhammad Aqeel wrote: > Sorry for broken patch. >

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Sorry for broken patch. PFA the corrected patch. --Aqeel On Fri, Mar 11, 2016 at 5:51 PM, Dave Page wrote: > EBROKENPATCH > > (pgadmin4)piranha:pgAdmin4 dpage$ git apply > ~/Downloads/pgadmin4_pip_framework_v5.patch >

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

EBROKENPATCH (pgadmin4)piranha:pgAdmin4 dpage$ git apply ~/Downloads/pgadmin4_pip_framework_v5.patch /Users/dpage/Downloads/pgadmin4_pip_framework_v5.patch:41: trailing whitespace. python pkg/pip/setup_pip.py bdist_wheel /Users/dpage/Downloads/pgadmin4_pip_framework_v5.patch:45: trailing

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

PFA the updated patch. On Wed, Mar 9, 2016 at 10:25 PM, Dave Page wrote: > Hi > > On Wed, Mar 9, 2016 at 2:24 PM, Muhammad Aqeel > wrote: > > Hi, > > > > PFA the patch to build PIP package for pgAdmin4 web component. It builds > PIP > > wheel

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Hi On Wed, Mar 9, 2016 at 2:24 PM, Muhammad Aqeel wrote: > Hi, > > PFA the patch to build PIP package for pgAdmin4 web component. It builds PIP > wheel file based on Python version in PATH. > > This pip package build setup is supported for python version 2.6 and

[pgadmin-hackers] PIP Package Building for pgAdmin4

Hi, PFA the patch to build PIP package for pgAdmin4 web component. It builds PIP wheel file based on Python version in PATH. This pip package build setup is supported for python version 2.6 and above. The pip package can easily be built with a make statement. Makefile has following targets. -