Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

okay. Thanks again! On Thu, Jun 2, 2016 at 6:37 PM, Dave Page wrote: > On Thu, Jun 2, 2016 at 2:05 PM, Sandeep Thakkar > wrote: > > Thanks Dave! > > > > I saw the runtime code and observed one change (prepend -> append) . Was > it > > not

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Thu, Jun 2, 2016 at 2:05 PM, Sandeep Thakkar wrote: > Thanks Dave! > > I saw the runtime code and observed one change (prepend -> append) . Was it > not saving the location because of this? No - I changed that because if the value is prepended, the user

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Thanks Dave! I saw the runtime code and observed one change (prepend -> append) . Was it not saving the location because of this? On Thu, Jun 2, 2016 at 6:27 PM, Dave Page wrote: > Thanks - applied with some tweaks to the runtime code (i.e. not saving > the location of the

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Thanks - applied with some tweaks to the runtime code (i.e. not saving the location of the venv in the appbundle). On Tue, May 31, 2016 at 6:37 PM, Sandeep Thakkar wrote: > Hi Dave, > > > On Tue, May 31, 2016 at 9:29 PM, Dave Page wrote: >>

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Dave, On Tue, May 31, 2016 at 9:29 PM, Dave Page wrote: > Hi, > > On the first run, I get: > > App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin > 4.app > ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory > Cleaning up > Copying

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi, On the first run, I get: App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin 4.app ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory Cleaning up Copying data into temporary directory cp: ./../mac-build/pgAdmin 4.app: No such file or directory

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Somehow the patch skipped the Makefile changes. Attached is the updated patch. On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Thanks. I have fixed all the issues. > > Regarding the app not running from within the DMG for the first time, I > was

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Thanks. I have fixed all the issues. Regarding the app not running from within the DMG for the first time, I was unable to reproduce it on Zilan's machine which didn't have the development env. On Murali's machine, it was reproducible for 1 time after couple of attempts. So, I just added the

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Fri, May 27, 2016 at 4:48 PM, Dave Page wrote: > > > On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar > wrote: >> >> Sure. Thanks. >> >> There is a typo in pkg/mac/build.sh. i.e >> >> s/HTML_HELP/HELP_PATH/ >> >> >> On Fri, May 27, 2016 at

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Sure. Thanks. > > There is a typo in pkg/mac/build.sh. i.e > > s/HTML_HELP/HELP_PATH/ > > > On Fri, May 27, 2016 at 5:26 PM, Dave Page wrote: > >> Not entirely - we definitely need to

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Attached is an updated patch in which I made some minor changes, most significantly, to stop the build script from over-writing my configuration file (again)! There are a couple of important issues to be resolved: 1) It doesn't work. When testing on Karen's machine (which is new, and doesn't

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Dave I have fixed this issue. Instead of getting path from otool, script now uses QTDIR variable to copy the framework directory. Please find the updated patch attached. Thanks. On Thu, May 19, 2016 at 7:39 PM, Dave Page wrote: > On Thu, May 19, 2016 at 10:05 AM, Sandeep

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hmm.. looks like some difference in the QT installation. Can you please provide me the otool -L output for pgAdmin4 from /mac-build/pgAdmin4.app/Contents/MacOS/pgAdmin4 and also the tree for $QTDIR/lib Thanks. On Thu, May 19, 2016 at 7:20 PM, Dave Page wrote: > Hi > > I

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi I see the following error when attempting to build. My configurable paths match the defaults in the README. App: pgAdmin4.app: Post-processing: .//Contents/MacOS/pgAdmin4 App: pgAdmin4.app: Adding symlink: QtWebKitWidgets (because of: .//Contents/MacOS/pgAdmin4) cp:

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Dave I have added the 'docs' target in the /Makefile. This target is also called by appbundle. pgAdmin4 versioning change is also taken care of. I have attached the updated patch here. Kindly review and let me know your feedback. Thanks. On Tue, May 17, 2016 at 4:52 PM, Dave Page

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

So, this means, the installer name would be pgadmin4-1.0-dev.exe on Windows and so on for other platforms? Also, the installation would go in $installdir/pgadmin4/1/ ? and the Revision change would update the installation? and the Release change will stay side-by-side? On Wed, May 18, 2016 at

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Okay, so the patch needs a little change because of the change in the versioning for pgAdmin. Will update it. Paresh, please take a note of it. On Tue, May 17, 2016 at 4:24 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave > > I have fixed the issues. Attached is the

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Tue, May 17, 2016 at 4:52 PM, Dave Page wrote: > > > On Tuesday, May 17, 2016, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have fixed the issues. Attached is the updated patch. >> >> The docs are built as part of 'appbundle' target,

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Tuesday, May 17, 2016, Sandeep Thakkar wrote: > Hi Dave > > I have fixed the issues. Attached is the updated patch. > > The docs are built as part of 'appbundle' target, there is no separate > target in Makefile for this. I observed that it requires the

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hello Dave, Attached is the patch for pgAdmin4.py to autocreate database configuration if does not exist. On Tue, May 17, 2016 at 4:24 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave > > I have fixed the issues. Attached is the updated patch. > > The docs are built

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Dave I have fixed the issues. Attached is the updated patch. The docs are built as part of 'appbundle' target, there is no separate target in Makefile for this. I observed that it requires the python modules to get this built. We create virtual environment as a part of 'appbundle' target

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Fri, May 13, 2016 at 2:01 PM, Sandeep Thakkar wrote: > Thanks Dave. > > Please see inline. > > On Fri, May 6, 2016 at 9:03 PM, Dave Page wrote: >> >> Hi >> >> Thanks. I've applied the path fix patch. The second one needs a little >> work -

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Thanks Dave. Please see inline. On Fri, May 6, 2016 at 9:03 PM, Dave Page wrote: > Hi > > Thanks. I've applied the path fix patch. The second one needs a little > work - I've attached an updated version to work from: > > - I've updated the README, and some of the default

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Thanks. I've applied the path fix patch. The second one needs a little work - I've attached an updated version to work from: - I've updated the README, and some of the default values. - I've removed the file type registration for .sql files. - Should we note that the user may need to run in

[pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Team, Dave, Attached herewith are two patches. pgadmin4-mac-bundle.patch - This includes scripts to build Mac app bundle and DMG for pgAdmin4. This is the tree of the generated app bundle: $ find pgAdmin4.app/ -maxdepth 3 -type d pgAdmin4.app/