Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-15 Thread Guillaume Lelarge
Le 15/09/2010 06:35, Steffen Kuhn a écrit : > Hi Guillaume, > > I tested it a bit. Your patch solves the issue: open editor, bringing a > cell in editmode, do not change and then close the editor. > - Really editing some values and then pressing 'ESC' does the same as > 'Undo' with the new behavio

Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-14 Thread Steffen Kuhn
Hi Guillaume, I tested it a bit. Your patch solves the issue: open editor, bringing a cell in editmode, do not change and then close the editor. - Really editing some values and then pressing 'ESC' does the same as 'Undo' with the new behaviour, - Really editing a value and the getting editmode

Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-14 Thread Guillaume Lelarge
Le 14/09/2010 13:09, Steffen Kuhn a écrit : > Hi Guillaume, > > checking for changed values is what I tried to, but my place was > sqlGridEditor::EndEdit because this is already checked there. Oh, yeah, I didn't see that. You're right. > But checking here, may be also in OnEditorHidden can be d

Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-14 Thread Steffen Kuhn
Hi Guillaume, checking for changed values is what I tried to, but my place was sqlGridEditor::EndEdit because this is already checked there. But checking here, may be also in OnEditorHidden can be dangerous I think, because of there might be previous changes that might be lost by just disableing

Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-13 Thread Guillaume Lelarge
Hi again :) Le 13/09/2010 20:55, Steffen Kuhn a écrit : > [...] > doing around with the context menu I encountered another issue, > I wasn't able to solve my self: > 1: bring a cell in edit mode do not change it. > 2.1: stay in the not edited cell an click row label or some emtpy space > on the ri

[pgadmin-hackers] Save Query in frmEditGrid

2010-09-13 Thread Steffen Kuhn
Hi Guillaume, doing around with the context menu I encountered another issue, I wasn't able to solve my self: 1: bring a cell in edit mode do not change it. 2.1: stay in the not edited cell an click row label or some emtpy space on the right border and close 2.2: choose another cell in the same