Re: [pgadmin-hackers] Updated patches

2016-02-04 Thread Neel Patel
Hi, New database patch is working fine. Ashesh - Can you please review it ? If it looks good then can you please commit ? Thanks, Neel Patel On Thu, Feb 4, 2016 at 6:35 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for database node. > > Issue fixed:

Re: [pgadmin-hackers] Updated patches

2016-02-03 Thread Harshal Dhumal
-- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Feb 3, 2016 at 2:47 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for database node. > > I have fixed almost all issues reported by Neel. > > -- > *Harshal

Re: [pgadmin-hackers] Updated patches

2016-02-02 Thread Neel Patel
Adding more comments. - "Delete Database" functionality is not working, we are getting below error. * The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.* - "Drop/Delete functionality is not working, we are getting below

Re: [pgadmin-hackers] Updated patches

2016-02-01 Thread Neel Patel
Hi Harshal, Please find below review comments. - While applying the patch, we are getting warning regarding "trailing whitespace.". Please remove the warning. - We are getting error saying "*IndexError: tuple index out of range*" on python side while connecting to "template0" database. - Many

[pgadmin-hackers] Updated patches

2016-01-22 Thread Harshal Dhumal
Hi, PFA updated patches: I have made changes as per Ashesh's suggestions. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py

Re: [pgadmin-hackers] Updated patches

2016-01-22 Thread Ashesh Vashi
Hi Harshal, On Fri, Jan 22, 2016 at 2:48 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patches: > > I have made changes as per Ashesh's suggestions. > As discussed, I've committed the privileges, and variable changes. I will look into database patch later.