On Wed, Apr 22, 2015 at 6:49 PM, Sanket Mehta wrote:
> Hi,
>
> I have made the following changes:
>
> When autocommit mode is enabled and transaction is not idle, it will show
> a warning message to user suggesting to close the current transaction by
> executing COMMIT or ROLLBACK in order to tak
Hi,
I have made the following changes:
When autocommit mode is enabled and transaction is not idle, it will show a
warning message to user suggesting to close the current transaction by
executing COMMIT or ROLLBACK in order to take the effect of AUTOCOMMIT mode.
I have attached the patch with th
Hi,
Sure, I will do the required changes.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Apr 22, 2015 at 3:09 PM, Ashesh Vashi wrote:
>
>
> On Wed, Apr 22, 2015 at 1:23 PM, Dave Page wrote:
>
>>
>>
>> On Wed, Apr 22, 2015 at 8:40 AM, Ashesh Vashi <
>> ashesh.va...@enterprise
On Wed, Apr 22, 2015 at 1:23 PM, Dave Page wrote:
>
>
> On Wed, Apr 22, 2015 at 8:40 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta <
>>> s
On Wed, Apr 22, 2015 at 8:40 AM, Ashesh Vashi wrote:
> On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> I have made all the changes mentioned in b
On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi wrote:
> On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta <
> [email protected]> wrote:
>
>> Hi,
>>
>> I have made all the changes mentioned in below mail.
>> Along with that I have changed the code to read autoRollBack value in
>> pgadmin/frm
Hi Ashesh,
Yes you are right.
It will be still in transaction till user executes COMMIT/ROLLBACK/END.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi wrote:
> On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta <
> [email protected]> w
On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta
wrote:
> Hi,
>
> I have made all the changes mentioned in below mail.
> Along with that I have changed the code to read autoRollBack value in
> pgadmin/frm/frmQuery.cpp file.
>
> previously it was used "settings->Read(wxT("frmQuery/AutoRollBack"),
> &
Hi,
I have made all the changes mentioned in below mail.
Along with that I have changed the code to read autoRollBack value in
pgadmin/frm/frmQuery.cpp file.
previously it was used "settings->Read(wxT("frmQuery/AutoRollBack"),
&bVal, true)" directly.
Now I have changed it to settings->GetAutoRo
Hi Sanket,
In your patch, I see couple of issues with your patch:
1. In pgadmin/frm/frmQuery.cpp:
You've used "settings->Read(wxT("frmQuery/AutoCommit"), &bVal, true)"
directly.
You should be using the function, you've defined in sysSettings.
i.e.
sysSettings::GetAutoCommit()
and, sysSettings::Set
Hi,
Below is the description of the autocommit feature implementation in
pgadmin:
This feature is only applicable in query editor.
Autocommit can be set on/off from 2 places.
1. pgadmin main browser -> File menu -> Options -> Query tool -> Query
editor -> Enable Auto commit
2. In Query editor -
11 matches
Mail list logo
