Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-21 Thread Dave Page
Thanks, patch applied. On Tue, Mar 21, 2017 at 12:35 PM, Harshal Dhumal wrote: > Hi, > > Please find updated patch for RM2244. > > Changes: View Data was broken in last patch when table contains more that 1 > column. > > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-21 Thread Harshal Dhumal
Hi, Please find updated patch for RM2244. Changes: View Data was broken in last patch when table contains more that 1 column. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Mar 20, 2017 at 4:10 PM, Dave Page

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-20 Thread Dave Page
Hi On Sat, Mar 18, 2017 at 2:57 PM, Harshal Dhumal wrote: > > Please find attached patch for RM2244. If I run View Data on the table below, I see the following exception and no grid is rendered: CREATE TABLE public.varchar_test ( id integer NOT NULL DEFAULT nextval('varchar_test_id_seq'::re

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-18 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 17, 2017 at 4:04 PM, Dave Page wrote: > Hi > > On Fri, Mar 17, 2017 at 7:02 AM, Harshal Dhumal > wrote: > > Hi, > > > > Here is patch for RM2243 and RM224

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-17 Thread Dave Page
Hi On Fri, Mar 17, 2017 at 7:02 AM, Harshal Dhumal wrote: > Hi, > > Here is patch for RM2243 and RM2244 > > Changes: 1. Pickup correct encoding in qtLiteral to decode. > 2. While releasing database connection only decode database name if it's not > unicode. This fixes 2243, but 2244 is an SQL er

[pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-17 Thread Harshal Dhumal
Hi, Here is patch for RM2243 and RM2244 Changes: 1. Pickup correct encoding in qtLiteral to decode. 2. While releasing database connection only decode database name if it's not unicode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise Postg