Re: [pgadmin-hackers] pgAdmin III commit: Install adminpack on user request in frmStatus

2011-04-20 Thread Guillaume Lelarge
Le 20/04/2011 11:30, Dave Page a écrit : > On Tue, Apr 19, 2011 at 9:58 PM, Guillaume Lelarge > wrote: >> Le 19/04/2011 12:47, Dave Page a écrit : >>> >>> I was thinking more that we shouldn't have a hint in one place, and >>> offer to fix it in another. We should have the hint, and offer to fix >

Re: [pgadmin-hackers] pgAdmin III commit: Install adminpack on user request in frmStatus

2011-04-20 Thread Dave Page
On Tue, Apr 19, 2011 at 9:58 PM, Guillaume Lelarge wrote: > Le 19/04/2011 12:47, Dave Page a écrit : >> >> I was thinking more that we shouldn't have a hint in one place, and >> offer to fix it in another. We should have the hint, and offer to fix >> the problem in all places (frmHint can handle "

Re: [pgadmin-hackers] pgAdmin III commit: Install adminpack on user request in frmStatus

2011-04-19 Thread Guillaume Lelarge
Le 19/04/2011 12:47, Dave Page a écrit : > On Tue, Apr 19, 2011 at 10:48 AM, Guillaume Lelarge > wrote: >> Hi, >> >> Le 19/04/2011 10:40, Dave Page a écrit : >>> [...] >>> I've tweaked the wording on the message in this patch as I wasn't >>> entirely happy with the phrasing, >> >> Good idea. >> >>

Re: [pgadmin-hackers] pgAdmin III commit: Install adminpack on user request in frmStatus

2011-04-19 Thread Dave Page
On Tue, Apr 19, 2011 at 10:48 AM, Guillaume Lelarge wrote: > Hi, > > Le 19/04/2011 10:40, Dave Page a écrit : >> [...] >> I've tweaked the wording on the message in this patch as I wasn't >> entirely happy with the phrasing, > > Good idea. > >> but whilst doing so I noticed there >> doesn't seem t

Re: [pgadmin-hackers] pgAdmin III commit: Install adminpack on user request in frmStatus

2011-04-19 Thread Guillaume Lelarge
Hi, Le 19/04/2011 10:40, Dave Page a écrit : > [...] > I've tweaked the wording on the message in this patch as I wasn't > entirely happy with the phrasing, Good idea. > but whilst doing so I noticed there > doesn't seem to be any error checking to handle the case where the > extension cannot be

Re: [pgadmin-hackers] pgAdmin III commit: Install adminpack on user request in frmStatus

2011-04-19 Thread Dave Page
Hi Guillaume, I've tweaked the wording on the message in this patch as I wasn't entirely happy with the phrasing, but whilst doing so I noticed there doesn't seem to be any error checking to handle the case where the extension cannot be installed (for example, because the user is using a hosting s

[pgadmin-hackers] pgAdmin III commit: Install adminpack on user request in frmStatus

2011-04-18 Thread Guillaume Lelarge
Install adminpack on user request in frmStatus Now that we can install an extension quite easily, it's simpler to ask the user if he wants pgAdmin to install it, rather than displaying him a hint. We still do that if it's not an 9.1 server or if the server doesn't have the adminpack extension inst