Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-08 Thread Dave Page
That seems better - committed, thanks! On Fri, May 5, 2017 at 11:35 AM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the revised patch with some code changes related OS > module used in feature tests for starting and stoping the app. There are > so

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-05 Thread Navnath Gadakh
Hi Dave, Please find the revised patch with some code changes related OS module used in feature tests for starting and stoping the app. There are some functions of of OS module not supported in windows and unix/mac I have applied some checked in the code. Hope this will successfully run

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-04 Thread Navnath Gadakh
Hi Dave, Please find the revised patch. I have added some print statements for debug purpose, so that I can get which line causing this issue. Most probably issue should be in the cleanup process. Please apply the patch and run the regression. Send me your console output and *regression.l

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-04 Thread Dave Page
I still see the issue. See the attached screenshot. Killing process 32287 caused the test suite to exit.[image: Inline image 1] On Wed, May 3, 2017 at 1:32 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > It's getting strange now. I just updated my Mac OS from EI Capitan(10.11.6) >

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-03 Thread Navnath Gadakh
It's getting strange now. I just updated my Mac OS from EI Capitan(10.11.6) to Sierra(10.12.4). I have applied the patch and it ran successfully without any hangup. This is my console output: *==* *Test Result Summary* *===

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-03 Thread Dave Page
10.12.3 (Sierra), 16GB MBP. Running in a virtualenv built from the system Python installation. Packages are: (pgadmin4)piranha:~ dpage$ pip freeze alabaster==0.7.10 alembic==0.9.1 args==0.1.0 Babel==1.3 beautifulsoup4==4.4.1 blinker==1.3 chromedriver-installer==0.0.6 click==6.6 clint==0.5.1 dateut

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-02 Thread Navnath Gadakh
Hi Dave, I have applied and run this patch on Mac and it ran successfully without hang up. I used different OS: OS X Yosemite Version 10.10.2 OS X EI Capitan Version 10.11.6 What is your system config? On Tue, May 2, 2017 at 4:39 PM, Dave Page wrote: > Hi > > When te

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-02 Thread Dave Page
Hi When testing on Mac, the testsuite never exits with this patch applied. It just hangs after printing the result summary. On Fri, Apr 28, 2017 at 2:51 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the patch for OS compatability issue of test-s

[pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-04-28 Thread Navnath Gadakh
Hi Dave, Please find the patch for OS compatability issue of test-suite. *Code Changes:* 1. Minor code changes done related to os module in *pgadmin4/web/regression/feature_utils/app_starter.py* 2. Code added in pgadmin4/*web/pgadmin/utils/tests/test_versioned_te