Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Sanket, On Fri, Nov 28, 2014 at 3:57 PM, Sanket Mehta wrote: > Hi Ashesh, > > On Wed, Nov 26, 2014 at 7:35 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Sanket, >> >> On Wed, Nov 26, 2014 at 5:41 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Sanket

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Ashesh, On Wed, Nov 26, 2014 at 7:35 PM, Ashesh Vashi wrote: > Hi Sanket, > > On Wed, Nov 26, 2014 at 5:41 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Sanket >> >> Patch looks good to me. I have tested couple of scenarios and it works >> fine. >> >> On Wed, Nov 26, 2014

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Sanket, On Wed, Nov 26, 2014 at 5:41 PM, Akshay Joshi wrote: > Hi Sanket > > Patch looks good to me. I have tested couple of scenarios and it works > fine. > > On Wed, Nov 26, 2014 at 3:27 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> >> On Tue, Nov 25, 2014

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Sanket Patch looks good to me. I have tested couple of scenarios and it works fine. On Wed, Nov 26, 2014 at 3:27 PM, Sanket Mehta wrote: > Hi Akshay, > > > On Tue, Nov 25, 2014 at 2:57 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Sanket >> >> On Mon, Nov 24, 2014 at 5:1

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Akshay, On Tue, Nov 25, 2014 at 2:57 PM, Akshay Joshi wrote: > Hi Sanket > > On Mon, Nov 24, 2014 at 5:18 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> >> On Wed, Nov 19, 2014 at 4:39 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi San

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Sanket On Mon, Nov 24, 2014 at 5:18 PM, Sanket Mehta wrote: > Hi Akshay, > > > On Wed, Nov 19, 2014 at 4:39 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Sanket >> >> Below are the file wise review comments >> >> >>1. ctlSeclabelPanel.cpp and ctlSeclabelPanel.h >>

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Akshay, On Wed, Nov 19, 2014 at 4:39 PM, Akshay Joshi wrote: > Hi Sanket > > Below are the file wise review comments > > >1. ctlSeclabelPanel.cpp and ctlSeclabelPanel.h >- Correct the function name "GetCUrrentProviderLabelArray" according > to camel case. > - Use trim bef

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Sanket Below are the file wise review comments 1. ctlSeclabelPanel.cpp and ctlSeclabelPanel.h - Correct the function name "GetCUrrentProviderLabelArray" according to camel case. - Use trim before check the empty condition of txtProvider and txtSeclabel used in ctlSecla

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi, Below are the thing I have taken care in this patch: 1. While creating the new table using table wizard, when any variables or security labels are specified for certain column, those were not visible on *sql tab* of table wizard. 2. when new/existing column dialog is open from table dialog th

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Akshay, PFA the patch. Please review it and let me know if anything is missing. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, Nov 11, 2014 at 7:21 PM, Ashesh Vashi wrote: > Hi Sanket, > > Apart from variable persistence issue taken care in your patch, I've also > observed

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Sanket, Apart from variable persistence issue taken care in your patch, I've also observed the data persistence issue with: (When reloading the existing/new column in column dialog from table dialog) 1. Priviledges 2. Security Lables I also observed, when I remove some privileges from an exist

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi Sanket, Quick review suggests that, you're not following the consistent name convention in new functions as per pgAdmin3 coding standard. I also observed a white-space warning, while apply the patch. Please resend the patch after resolving these issues. -- Thanks & Regards, Ashesh Vashi Ent

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi, Issue was occurring as mentioned below: While creating the new table using table wizard, when any variables or security labels are specified for certain column then in *dlgTable* class, it was not fetching those variable or security labels from *dlgColumn *class. So those were not visible on

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Sure Ashesh, I will check and get back. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, Nov 4, 2014 at 1:03 PM, Ashesh Vashi wrote: > Sanket, > > Can you take a look at it? > > -- > Thanks, > > Ashesh Vashi > > On 4 Nov 2014 12:54, "liuyuanyuan" wrote: > > > > > > > > Hi , ha

Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Sanket, Can you take a look at it? -- Thanks, Ashesh Vashi On 4 Nov 2014 12:54, "liuyuanyuan" wrote: > > > > Hi , hackers! > > Currently I test some part of pgadmin GUI, and I found some potential invalid input field of New Column GUI, > > Like Variables and Security Labels. Could you please ha

[pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

Hi , hackers! Currently I test some part of pgadmin GUI, and I found some potential invalid input field of New Column GUI, Like Variables and Security Labels. Could you please have a look on this issue? For example: OS: WIN7 64bit PostgreSQL 9.3 pgAdmin III:Version 1.18.1 I use GUI of