Awesome. Thanks folks!
On Mon, Jan 30, 2017 at 6:35 AM, Fahar Abbas
wrote:
> Sure Dave.
>
> On Mon, Jan 30, 2017 at 4:33 PM, Dave Page wrote:
>
>> Thanks Murtuza. Fixed and committed. George; I stuck with the original
>> filename for the loader - I couldn't come up with anything better.
>>
>> F
Sure Dave.
On Mon, Jan 30, 2017 at 4:33 PM, Dave Page wrote:
> Thanks Murtuza. Fixed and committed. George; I stuck with the original
> filename for the loader - I couldn't come up with anything better.
>
> Fahar; This is a fairly major change. Please test thoroughly on
> different versions of P
Thanks Murtuza. Fixed and committed. George; I stuck with the original
filename for the loader - I couldn't come up with anything better.
Fahar; This is a fairly major change. Please test thoroughly on
different versions of PG and EPAS to ensure that the correct SQL
templates are being used. They'
Hi Dave,
I found one typo as given below and apart from that, code is working as
expected with new template loader,
-
web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py:241:
return 'ppas/*#{0#}*'.format(ver)
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://w
Sure Dave, I will take a look.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jan 27, 2017 at 9:57 PM, Dave Page wrote:
> Scrub that Khushboo - Murtuza, can you review on Monday please? I'm
> being told Khushboo is on the critic
We thought of that one too. That sort of makes it sound like the loader is
versioned rather than the template files. Also, it's unclear what it is a
loader for without "template".
That said, do you think there is a better place for it to live? We stuck it
under utils just because we didn't see any
Good point. How about just versioned_loader?
On Fri, Jan 27, 2017 at 4:40 PM, George Gelashvili
wrote:
> That would work, but the versioned template loader can load anything that is
> a template, as it extends from DispatchingJinjaLoader
>
> On Fri, Jan 27, 2017 at 11:39 AM, Dave Page wrote:
>>
That would work, but the versioned template loader can load anything that
is a template, as it extends from DispatchingJinjaLoader
On Fri, Jan 27, 2017 at 11:39 AM, Dave Page wrote:
> sql_loader ?
>
> On Fri, Jan 27, 2017 at 4:38 PM, George Gelashvili
> wrote:
> > Thanks!
> > Did you have a nam
sql_loader ?
On Fri, Jan 27, 2017 at 4:38 PM, George Gelashvili
wrote:
> Thanks!
> Did you have a name in mind? We're not sure we could come up with a clear
> name in fewer words.
>
> On Fri, Jan 27, 2017 at 11:27 AM, Dave Page wrote:
>>
>> Scrub that Khushboo - Murtuza, can you review on Monday
Thanks!
Did you have a name in mind? We're not sure we could come up with a clear
name in fewer words.
On Fri, Jan 27, 2017 at 11:27 AM, Dave Page wrote:
> Scrub that Khushboo - Murtuza, can you review on Monday please? I'm
> being told Khushboo is on the critical path for something else at the
Scrub that Khushboo - Murtuza, can you review on Monday please? I'm
being told Khushboo is on the critical path for something else at the
moment.
On Fri, Jan 27, 2017 at 4:22 PM, Dave Page wrote:
> Very nice indeed! I didn't realise we'd ended up with quite so many
> duplicated templates.
>
> Bot
Very nice indeed! I didn't realise we'd ended up with quite so many
duplicated templates.
Both patches look good to me - really the only thing that caught my
eye was the name versioned_template_loader which is somewhat longer
than I'd prefer.
As it's a major change, and we're going to be wrapping
12 matches
Mail list logo
