Thanks - patch committed!
On Wed, Apr 12, 2017 at 10:00 PM, Matthew Kleiman wrote:
> Hi Dave,
>
> We have found the source of this bug and fixed it in the attached patch.
> If this revised patch addresses the copy issues you pointed out, it can be
> pulled into master.
>
> Please note that we'll
Hi Dave,
Unfortunately I found another regression; I have a test table called
> موسيقى (Arabic for music) which if included in a selection of rows,
Could you share the queries that:
- create this table
- populate it with data
- access it leading to the regression
What user interaction are you pe
Hi Matt,
On Fri, Apr 7, 2017 at 10:56 PM, Matthew Kleiman wrote:
> Hi Dave,
>
> I've updated the attached patch to include a change to the "Paste Rows"
> button. It will now be enabled only if there are rows on the clipboard.
Unfortunately I found another regression; I have a test table called
م
On Fri, Apr 7, 2017 at 2:49 PM, Atira Odhner wrote:
>> The one tweak I made to the patch was to remove the code that disabled
>> the Copy button from the top of copy_data.js. I think the button
>> should remain enabled to allow the user to copy again, in case they
>> use the clipboard for somethin
The one tweak I made to the patch was to remove the code that disabled
> the Copy button from the top of copy_data.js. I think the button
> should remain enabled to allow the user to copy again, in case they
> use the clipboard for something else and then need to refresh it with
> the data. Of cour
Hi
I was just about to commit this (and was quite please to get it in
before next week's release), but unfortunately realised at the last
minute that it breaks pasting of rows when the query tool is in edit
mode. You should be able to copy 1 or more rows, and then hit the
paste button to append th
Hi Dave,
I still think that smaller commits make it easier to handle git history,
but here is a squashed patch. We've updated the styling as well. Shirley
okayed this styling for now but is going to look into updating it in the
future--investigating whether we should keep the checkboxes.
Also, a
Can you send me a squashed version as a single patch please?
On Mon, Apr 3, 2017 at 8:32 PM, Atira Odhner wrote:
> Oops, there was a test issue we missed while de-branding.
>
> Please look at these instead
>
> On Mon, Apr 3, 2017 at 3:12 PM, Atira Odhner wrote:
>>>
>>> This doesn't seem to work
Hi
On Tue, Mar 14, 2017 at 10:08 PM, Joao Pedro De Almeida Pereira
wrote:
> Hi Hackers,
>
> Attached you can find the patches that finish the following Redmine Issue
> https://redmine.postgresql.org/issues/2216
>
> Note:
> These changes depend on the acceptance of the patch that we submitted on t
