Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-07 Thread Dave Page
Hi On Fri, Mar 3, 2017 at 6:41 PM, Atira Odhner wrote: > Hey Dave, > > We're not able to reproduce that issue over here. Any chance you could debug > it? Per the discussion at https://github.com/seleniumhq/selenium-google-code-issue-archive/issues/3378, it looks like we're not closing the driver

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-03 Thread Atira Odhner
Hey Dave, We're not able to reproduce that issue over here. Any chance you could debug it? Thanks, Tira On Fri, Mar 3, 2017 at 10:20 AM, Dave Page wrote: > On Fri, Mar 3, 2017 at 1:57 PM, Dave Page wrote: > > Hi > > > > On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira > > wrote

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-03 Thread Dave Page
On Fri, Mar 3, 2017 at 1:57 PM, Dave Page wrote: > Hi > > On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira > wrote: >> Hi, >> We adjusted the patches to correct the issues that you mentioned >> >> Improves screenshots and reduces test flakiness > > Hmm, was that the 0.5 second sleep

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-03 Thread Dave Page
Hi On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira wrote: > Hi, > We adjusted the patches to correct the issues that you mentioned > > Improves screenshots and reduces test flakiness Hmm, was that the 0.5 second sleep? I hate doing that, but sometimes it's the only way that doesn'

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-02 Thread Joao Pedro De Almeida Pereira
Hi, We adjusted the patches to correct the issues that you mentioned Improves screenshots and reduces test flakiness - rename screenshot files to add python version - put screenshots into separate pg version folders Thanks Joao & Tira & Sarah On Thu, Mar 2, 2017 at 5:15 AM, Dave Page w

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-02 Thread Dave Page
Hi On Wed, Mar 1, 2017 at 9:34 PM, Joao Pedro De Almeida Pereira wrote: > Hi Hackers > > We noticed that the feature test dependencies were removed in a recent > patch, so we added them back. They were intentionally moved - see: https://www.postgresql.org/message-id/CA%2BOCxoxz8ZPsWBvEhSnMfq%3D