Re: [pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-09 Thread Dave Page
Thanks, applied. On Tue, Jun 9, 2009 at 1:51 AM, Chuck McDevitt wrote: > Forgot to change "Reading log from server." To "Reading log from server..." > Here is new diff > -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@post

Re: [pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-09 Thread Chuck McDevitt
Forgot to change "Reading log from server." To "Reading log from server..." Here is new diff patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-08 Thread Dave Page
On Mon, Jun 8, 2009 at 10:02 PM, Chuck McDevitt wrote: > Thanks Dave.  Some questions: > >> Hi, >> >> Some issues with this, 2 minor, one less so: >> >> - Please rearrange the code in frmStatus.h to remove the class >> definition. We try to keep the headers purely for declarations and >> only inclu

Re: [pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-08 Thread Chuck McDevitt
Thanks Dave. Some questions: > Hi, > > Some issues with this, 2 minor, one less so: > > - Please rearrange the code in frmStatus.h to remove the class > definition. We try to keep the headers purely for declarations and > only include one-line functions in them. I would suggest a new file in >

Re: [pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-08 Thread Dave Page
On Fri, Jun 5, 2009 at 3:40 AM, Chuck McDevitt wrote: > This patch fixes many problems in the handling of GPDB CSV format logs for > the frmStatus display. > > It's also a useful start for supporting PostgreSQL 8.4 CSV format logs. Hi, Some issues with this, 2 minor, one less so: - Please rearr