Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

2014-11-20 Thread Guillaume Lelarge
2014-11-20 10:03 GMT+01:00 Dave Page : > On Wed, Nov 19, 2014 at 8:01 PM, Guillaume Lelarge > wrote: > > 2014-11-18 17:09 GMT+01:00 Dave Page : > >> > >> If Guillaume is satisfied with the code enough to commit it, it can. I > >> consider it a bug fix, albeit minor. > >> > > > > I didn't check th

Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

2014-11-20 Thread Dave Page
On Wed, Nov 19, 2014 at 8:01 PM, Guillaume Lelarge wrote: > 2014-11-18 17:09 GMT+01:00 Dave Page : >> >> If Guillaume is satisfied with the code enough to commit it, it can. I >> consider it a bug fix, albeit minor. >> > > I didn't check the code. I just looked at the pics, and they feel right to

Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

2014-11-19 Thread Guillaume Lelarge
2014-11-18 17:09 GMT+01:00 Dave Page : > If Guillaume is satisfied with the code enough to commit it, it can. I > consider it a bug fix, albeit minor. > > I didn't check the code. I just looked at the pics, and they feel right to me. Pretty sure I won't have time to check the code, and commit it,

Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

2014-11-18 Thread Dave Page
If Guillaume is satisfied with the code enough to commit it, it can. I consider it a bug fix, albeit minor. On Tue, Nov 18, 2014 at 3:00 PM, J.F. Oster wrote: > Hello Dave, > > I wonder if this patch will get into 1.20... > > Wednesday, November 5, 2014, 5:25:10 PM, J.F. Oster wrote: > > JFO> Hel

Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

2014-11-18 Thread J.F. Oster
Hello Dave, I wonder if this patch will get into 1.20... Wednesday, November 5, 2014, 5:25:10 PM, J.F. Oster wrote: JFO> Hello, JFO> Per recent discussion on pgadmin-support ("index only scans are not JFO> shown graphically"), JFO>> Insert JFO>> Update JFO>> Delete JFO>> Foreign Scan JFO>> Ind

Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

2014-11-05 Thread Guillaume Lelarge
2014-11-05 15:25 GMT+01:00 J.F. Oster : > Hello, > > Per recent discussion on pgadmin-support ("index only scans are not > shown graphically"), > > JFO> Insert > JFO> Update > JFO> Delete > JFO> Foreign Scan > JFO> Index Only Scan > JFO> BitmapAnd > JFO> BitmapOr > JFO> Values Scan (shows up as a