Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-19 Thread Murtuza Zabuawala
Hi, PFA updated patch with fix for below mentioned issues except issue no.8 (That issue occurs when you create any database object for other schema rather then selected schema in tree view, once object is created it will gets associated within current tree schema rather then schema mentioned

Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-18 Thread Neel Patel
Hi Murtuza, Please find below review comments for the collation node. 1. "Owner" field should be changed from text control to Backform.NodeListByNameControl. 2. Remove "Use Slony" option, we will implement it as separate module. 3. Use 2 space indentation instead of 4 space in javascript file.

Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-18 Thread Murtuza Zabuawala
Thanks Neel. I'll work on below mentioned issues & send new patch. Regards, Murtuza On Monday 18 January 2016 10:12 PM, Neel Patel wrote: Hi Murtuza, Please find below review comments for the collation node. 1. "Owner" field should be changed from text control to

Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-06 Thread Dave Page
On Wed, Jan 6, 2016 at 12:18 PM, Murtuza Zabuawala wrote: > Hi, > > Please find patch to add "Collation" & "Catalog Objects" nodes in pgAdmin4. > > Please note that this patch is mainly for "Collation" & "Catalog Objects" > nodes, Schema/Catalog node is not yet