[pgadmin-hackers] pgAgent commit: USe exit status macros to get the Unix exit code, and r

2011-03-14 Thread Dave Page
USe exit status macros to get the Unix exit code, and recognise all non-zero return values as failure codes. Per discussion with Korry Douglas and Robert Haas. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=2aec3bc473e583f8fa07e133bc8def60ff1c0

[pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

2011-03-14 Thread Guillaume Lelarge
Le 13/03/2011 09:46, Dave Page a écrit : > On Sun, Mar 13, 2011 at 1:52 AM, Peter Geoghegan > wrote: >> On 12 March 2011 19:13, Guillaume Lelarge wrote: >>> Maybe a stupid question but what is the ! in the variable name >>> (ex_hash_setop_except_png!_data)? >> >> There's no good reason. It isn't

[pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

2011-03-14 Thread Peter Geoghegan
On 14 March 2011 20:22, Guillaume Lelarge wrote: > So I worked a bit on this issue tonight. I think you didn't allocate > enough memory for filename. See the patch attached. With this patch, it > works OK for me. I'm wondering if the patch should also do +1 on the > other calloc calls. Any ideas o

[pgadmin-hackers] pgAdmin III commit: Fix the path to the image files, per Vladimir Kokov

2011-03-14 Thread Dave Page
Fix the path to the image files, per Vladimir Kokovic Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2b13577803ad13f97ef90c68ae6306f4d4011964 Modified Files -- pgadmin/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 delet

[pgadmin-hackers] pgAdmin III commit: Make sure we allocate enough space for names etc. P

2011-03-14 Thread Dave Page
Make sure we allocate enough space for names etc. Problem spotted and diagnosed by Guillaume. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=58725b6765f272bce2360286b1ff78a036833fe6 Modified Files -- xtra/png2c/png2c.c |6 +++--

[pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

2011-03-14 Thread Dave Page
On Mon, Mar 14, 2011 at 8:22 PM, Guillaume Lelarge wrote: > Le 13/03/2011 09:46, Dave Page a écrit : >> On Sun, Mar 13, 2011 at 1:52 AM, Peter Geoghegan >> wrote: >>> On 12 March 2011 19:13, Guillaume Lelarge wrote: Maybe a stupid question but what is the ! in the variable name (ex_ha

[pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

2011-03-14 Thread Dave Page
On Mon, Mar 14, 2011 at 8:37 PM, Peter Geoghegan wrote: > On 14 March 2011 20:22, Guillaume Lelarge wrote: >> So I worked a bit on this issue tonight. I think you didn't allocate >> enough memory for filename. See the patch attached. With this patch, it >> works OK for me. I'm wondering if the pa

Re: [pgadmin-hackers] pgAdmin III commit: Fix selection of objects in backup/restore dialogs

2011-03-14 Thread Thom Brown
On 12 March 2011 09:27, Guillaume Lelarge wrote: > Fix selection of objects in backup/restore dialogs > > When a user selects a table, the schema and the database should be selected as > well. This patch handles this automatically. > > Report from Melvin Davidson. > > Branch > -- > REL-1_12_0_

Re: [pgadmin-hackers] pgAdmin III commit: Fix selection of objects in backup/restore dialogs

2011-03-14 Thread Guillaume Lelarge
Le 14/03/2011 22:17, Thom Brown a écrit : > On 12 March 2011 09:27, Guillaume Lelarge wrote: >> Fix selection of objects in backup/restore dialogs >> >> When a user selects a table, the schema and the database should be selected >> as >> well. This patch handles this automatically. >> >> Report f

Re: [pgadmin-hackers] [pgadmin-support] Copy & paste - git

2011-03-14 Thread Timon
it was already discussed. I have same bug, but Guillaume Lelarge unable to reproduce it. Using git bisect I found commit which broke this feature. This is http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff 2011/3/15 Claudio Freire : > Hey, I ju