Re: [pgadmin-hackers] Materialized View Patch File

2013-07-18 Thread Dave Page
Hi I realised this code is all wonky anyway - why is IsMaterializedView() not just an accessor over a pgView private variable that is set in pgViewFactory::CreateObjects when we create the object? We already know at that point whether it's a matview or not (from pg_class.relkind). Querying pg_clas

[pgadmin-hackers] pgAdmin III commit: Ensure SQL keywords used in the UI don't get transl

2013-07-18 Thread Dave Page
Ensure SQL keywords used in the UI don't get translated. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4b06713e62a690a81066dc85ecf005a8e1b125b6 Author: Dinesh Kumar Modified Files -- pgadmin/dlg/dlgForeignKey.cpp | 14 +

Re: [pgadmin-hackers] pgAdmin bug - SQL creation for foreign keys

2013-07-18 Thread Dave Page
Thanks - patch applied with a couple of minor changes: - I reworded the comments. - I removed the changes to dlgIndex.xrc and one of the corrsponding changes in dlgIndex.cpp. They changed the labelling that was previously correct. On Wed, Jul 17, 2013 at 6:09 PM, Dinesh Kumar wrote: > Hi Dave

Re: [pgadmin-hackers] pgAdmin bug - SQL creation for foreign keys

2013-07-18 Thread Dinesh Kumar
OK. Thanks Dave. Dinesh -- *Dinesh Kumar* Software Engineer Ph: +918087463317 Skype ID: dinesh.kumar432 www.enterprisedb.co m * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers

[pgadmin-hackers] pgAdmin III commit: Fix UTF-8 display for guru hints

2013-07-18 Thread Guillaume Lelarge
Fix UTF-8 display for guru hints Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=95c14eea5e6ee502f3e64053a6cdbc89ba7487fd Author: Marek Cernocky Modified Files -- CHANGELOG |1 + docs/en_US/

Re: [pgadmin-hackers] Heads-up - Beta 1

2013-07-18 Thread Guillaume Lelarge
On Thu, 2013-06-20 at 08:28 +0100, Dave Page wrote: > Guillaume? > Sorry for the huge delay. Both are commited, and pushed. > On Thu, Jun 20, 2013 at 7:11 AM, Marek Černocký wrote: > > What my translation and patch > > http://www.postgresql.org/message-id/1366823347.15060.23.camel@sirius > > C

[pgadmin-hackers] pgAdmin III commit: Update czech hints files

2013-07-18 Thread Guillaume Lelarge
Update czech hints files Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=af512147b89f9f5db3de1bb0582b061aad02f6e1 Author: Marek Cernocky Modified Files -- docs/cs_CZ/hints/autovacuum.html | 33 - docs/cs_

[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.

2013-07-18 Thread Guillaume Lelarge
Automatic merge using stringmerge script. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4c2ceac29501d9a48f962cd80185cb60c8880fed Modified Files -- i18n/af_ZA/pgadmin3.po | 4008 +--- i18n/ar_SA/pgadmin3.po | 4029 +--- i18n/

[pgadmin-hackers] pgAdmin III commit: There's one less folder to check for new messages t

2013-07-18 Thread Guillaume Lelarge
There's one less folder to check for new messages to translate Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=3d09954445d86af171c3dfe18976659522017e13 Modified Files -- stringextract |1 - 1 file changed, 1 deletion(-) -- Sen

[pgadmin-hackers] Bug in the graphical explain

2013-07-18 Thread Guillaume Lelarge
Hi, I have no idea on how to fix this. I've attached the test case to reproduce it. First execute the test SQL file, then select the last UPDATE query, and hit F7. The graphical explain is kinda ugly because two nodes are one on the other. That's not the first time I meet this bug. For example, w

Re: [pgadmin-hackers] Bug in the graphical explain

2013-07-18 Thread Dave Page
Ashesh; do we have any capacity in the team to spend a little time on this at the moment? It'll affect the PEM SQL Profiler as well of course... On Thu, Jul 18, 2013 at 9:26 PM, Guillaume Lelarge wrote: > Hi, > > I have no idea on how to fix this. I've attached the test case to > reproduce it. >

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-18 Thread Neel Patel
Hi Dave, Thanks for the comment. We made the changes as you suggested. Please find the updated patch in attachment and let me know if you have any query. Thanks, Neel Patel On Thu, Jul 18, 2013 at 5:54 PM, Dave Page wrote: > Hi > > I realised this code is all wonky anyway - why is IsMaterial

[pgadmin-hackers] Fwd: patch proposal for acinclude.m4 to better support gcc on illumos/smartos

2013-07-18 Thread Richard PALO
As this seemed to fall upon deaf ears, I'll reiterate my request for integration of the following patch which fixes the fact that the linker directive '-as-needed' is not supported by Solaris ld. Message original Sujet: patch proposal for acinclude.m4 to better support gcc on