Re: [pgadmin-hackers] [PATCH] Add a menu option for disabling restoration of previous environment on reconnect

2014-01-08 Thread Kaarel Moppel
Oh indeed, missed the attachment somehow, sorry about that. And yes, there's an option already for that. But its on the 'advanced' tab with the default being "on" (changing this to "off" wouldn't probably be nice now) meaning couple of extra clicks which in case of dozens of servers gets quickly q

Re: [pgadmin-hackers] [PATCH] Added a menu option to disable code folding

2014-01-08 Thread Kaarel Moppel
Hmm, I'm not sure if we're talking about the same thing now, yes I don't have to click that but I mean for me there's just no way to look pass that. The clickable box with the minus sign together with the downstretching line that appears in the left gutter after typing in a pair of parentheses is j

Re: [pgadmin-hackers] [PATCH] fix newly added server being lost when crashing

2014-01-08 Thread Kaarel Moppel
Ok, got it. Corrected version in attach now. On Mon, Jan 6, 2014 at 12:29 PM, Ashesh Vashi wrote: > Hi Kaarel, > > I think - everything looks good except: > 1. Please use TAB instead of 4 spaces > 2. You don't require to define Flush function after inheriting the > wxConfig class publicly. >

Re: [pgadmin-hackers] [PATCH] fix newly added server being lost when crashing

2014-01-08 Thread Ashesh Vashi
Looking good to me. If nobody has any objection, then I can check-in. NOTE: I don't know the reason for the class sysSettings to inherit the wxConfig privately in original implementation. It was done by Dave in this commit: cfbae7d378766ab8cf138123186a024afffc061e. On Thu, Jan 9, 2014 at 5:42 A