Re: [pgadmin-hackers] F8 for Execute to file

Hi, I have reviewed this patch. It looks good to me. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Oct 27, 2014 at 4:16 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Fri, Oct 24, 2014 at 10:57 PM, Mads Jensen wrote: > > Hi, > > > > It's a trivial

Re: [pgadmin-hackers] PATCH: Stored procedure large parameter list

Hi I have reviewed this patch. This looks good to me. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Oct 27, 2014 at 4:16 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Sun, Oct 26, 2014 at 5:51 AM, J.F. Oster wrote: > > Hello! > > > > Please consid

Re: [pgadmin-hackers] PATCH: Clear undo/redo history when a file is opened in Query editor

Hi, As per my understanding below is the bug scenario. - open any file in sql editor.. - now open a second file in same editor and try undo. - it will show you previous file content again. Let me know if my understanding is correct so that i can go ahead and review the patch. Regards, Sanket

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Hi, Can you please explain in which case it will create issue if bug is not applied? Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Oct 27, 2014 at 4:14 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Fri, Oct 24, 2014 at 8:12 PM, J.F. Oster wrote:

[pgadmin-hackers] pgAdmin III commit: Beautify the query shown in the SQL pane for the fu

Beautify the query shown in the SQL pane for the functions having multiple arguments. Reviewed by Sanket Mehta and small modification done by Ashesh Vashi. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ea803ad68290bb506fd2148ee8ea8f4176e34197

Re: [pgadmin-hackers] PATCH: Stored procedure large parameter list

Committed with small modification. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Oct 28, 2014 at 2:59 PM, Sanket Mehta wrote: > Hi >

Re: [pgadmin-hackers] PATCH: Stored procedure large parameter list

On 28/10/2014 11:36, Ashesh Vashi wrote: > Committed with small modification. > Brilliant! Thanks everyone. Ray. -- Raymond O'Donnell :: Galway :: Ireland r...@iol.ie -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.p

[pgadmin-hackers] pgAdmin III commit: Added accelerator F8 for 'Execute to file' in the Q

Added accelerator F8 for 'Execute to file' in the Query window Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5d246ba6a7fe8105dc65ca0643e9c0119a409e22 Author: Mads Jensen Modified Files -- CHANGELOG|2 ++ pgadmi

Re: [pgadmin-hackers] F8 for Execute to file

Hi Mads Jensen, On Sat, Oct 25, 2014 at 3:27 AM, Mads Jensen wrote: > Hi, > > It's a trivial patch: I miss a shortcut key for this function, and thus > created a patch to support it. > > I don't get why this was: > wxAcceleratorTable accel(12, entries); > and not 14, as suggested in the

Re: [pgadmin-hackers] PATCH: Stored procedure large parameter list

Hello, Does anyone know if this will be put in Debian Wheezy (stable)? How do we get it into Debian Wheezy? I asked the Debian pgAdmin package maintainer and he told me to ask the pgamdin mailing list instead. Thanks! On Tue, Oct 28, 2014 at 7:39 AM, Raymond O'Donnell wrote: > On 28/10/2014 1

Re: [pgadmin-hackers] PATCH: Stored procedure large parameter list

On Tue, Oct 28, 2014 at 3:24 PM, inspector morse wrote: > Hello, > > Does anyone know if this will be put in Debian Wheezy (stable)? How do we > get it into Debian Wheezy? > > I asked the Debian pgAdmin package maintainer and he told me to ask the > pgamdin mailing list instead. We've have nothin

Re: [pgadmin-hackers] PATCH: Stored procedure large parameter list

Oh ok, thanks all for your work on the patch and getting it comitted. On Tue, Oct 28, 2014 at 11:32 AM, Dave Page wrote: > On Tue, Oct 28, 2014 at 3:24 PM, inspector morse > wrote: > > Hello, > > > > Does anyone know if this will be put in Debian Wheezy (stable)? How do we > > get it into Debi

Re: [pgadmin-hackers] PATCH: Clear undo/redo history when a file is opened in Query editor

Hello Sanket, SM> As per my understanding below is the bug scenario. Yes, - open any file in sql editor.. - perform some modifications to file so that Undo is possible. - now open a second file in same editor and try Undo. It will show you previous file content again.═ - do Save. Now con

Re: [pgadmin-hackers] pgAdmin III commit: Beautify the query shown in the SQL pane for the fu

Hello Ashesh, Right, bringing related logic close together is much better. But there is a small difference in your version. Per discussion held on pgadmin-support, >> ... >> vertical formatting shouldn't be applied where >> number of parameters is less than two. DP> Right. So we expect: CREAT

Re: [pgadmin-hackers] PATCH: Clear undo/redo history when a file is opened in Query editor

Hi J.F. Thank you for the clarification. I have reviewed the patch. It seems working fine. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, Oct 28, 2014 at 9:38 PM, J.F. Oster wrote: > Hello Sanket, > > > SM> As per my understanding below is the bug scenario. > Yes, > > - ope

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Hello Sanket, Steps to reveal issues: 1. Prepare test tables: CREATE TABLE tserial2 ( a smallserial NOT NULL, dat text, CONSTRAINT tserial2_pkey PRIMARY KEY (a) ); -- Create these for reference (to compare): CREATE TABLE tserial(

Re: [pgadmin-hackers] pgAdmin III commit: Beautify the query shown in the SQL pane for the fu

On Tue, Oct 28, 2014 at 9:58 PM, J.F. Oster wrote: > Hello Ashesh, > > Right, bringing related logic close together is much better. But there > is a small difference in your version. Per discussion held on > pgadmin-support, > > >> ... > >> vertical formatting shouldn't be applied where > >> numb

[pgadmin-hackers] pgAdmin III commit: Improved the query (the function arguments) display

Improved the query (the function arguments) displayed in the SQL pane Do not append the new line for one argument function as discussed with J.F.Oster Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=98e11c5fc3f3d2cf081b26a41f3b85a5b19ca5da Mod

[pgadmin-hackers] Completion

Hi, I tried to grep around for places where to hack (this issue has been bothering since I was introduced to pgAdmin in February/March. It's possible to complete table and column names for patterns like: SELECT * FROM [can_complete] JOIN [no completion options] SELECT * FROM [can_complete] WHER