Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

2014-11-19 Thread Akshay Joshi
Hi Sanket Below are the file wise review comments 1. ctlSeclabelPanel.cpp and ctlSeclabelPanel.h - Correct the function name "GetCUrrentProviderLabelArray" according to camel case. - Use trim before check the empty condition of txtProvider and txtSeclabel used in ctlSecla

[pgadmin-hackers] pgAdmin III commit: Update pgadmin3.pot

2014-11-19 Thread Guillaume Lelarge
Update pgadmin3.pot Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=6054eb395b04fcad16d6afa2ab9fb7d5fcb2975c Modified Files -- pgadmin3.pot | 717 +- 1 file changed, 362 insert

[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.

2014-11-19 Thread Guillaume Lelarge
Automatic merge using stringmerge script. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b0269b91063afc7e267decad03c825451038649c Modified Files -- i18n/af_ZA/pgadmin3.po | 718 ++-- i18n/ar_SA/pgadmin3.po | 718 ++

Re: [pgadmin-hackers] v1.20.0rc1 source code uploaded

2014-11-19 Thread Guillaume Lelarge
2014-11-18 13:08 GMT+01:00 Dave Page : > Hi, > > I've built the 1.20.0-rc1 tarball and uploaded it to > > http://ftp.pgadmin.org/release/v1.20.0-rc1/src/ > > Guillaume - can you please finalise the translation updates as we'll > be releasing GA soon (hopefully)! > > I've just sent an email to our

[pgadmin-hackers] pgAdmin III commit: Update french translation

2014-11-19 Thread Guillaume Lelarge
Update french translation Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=fd2f55cee5473fddc0f13a6238077933c0c087df Modified Files -- i18n/fr_FR/pgadmin3.mo | Bin 356753 -> 356828 bytes i18n/fr_FR/pgadmin3.po |5 ++--- 2 files ch

Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

2014-11-19 Thread Guillaume Lelarge
2014-11-18 17:09 GMT+01:00 Dave Page : > If Guillaume is satisfied with the code enough to commit it, it can. I > consider it a bug fix, albeit minor. > > I didn't check the code. I just looked at the pics, and they feel right to me. Pretty sure I won't have time to check the code, and commit it,