Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi Neel, Please find updated patch. Thanks, Khushboo On Wed, Jan 20, 2016 at 12:50 PM, Neel Patel wrote: > Hi Khushboo, > > While applying the patch file, we are getting below warnings. > > # > domains (1).patch:1340: trailing whitespace. > oid

Re: [pgadmin-hackers] PATCH: Login/Group Role Node

Hi Ashesh, Addition to below, I also observed two more issues, - It's a bad idea to give md5 hash of current role's password in properties/edit mode, A malicious user can use that hash to crack another role's password. - When you select a role and click on SQL panel (near to Statistic panel

[pgadmin-hackers] Patch for minor UI issues [pgadmin4]

Hi, PFA patches for minor issues in status bar and border issue in Unique coll collection. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js ind

Re: [pgadmin-hackers] patch for cast module

Hi Neel. PFA the revised patch which has changed according to your comments. Please do review it and let me know in case anything is missing. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Jan 20, 2016 at 10:20 AM, Neel Patel wrote: > Hi Sanket, > > Below are the review comm

[pgadmin-hackers] pgAdmin 4 commit: Allow the privileges control to work properly. Resolv

Allow the privileges control to work properly. Resolved few typos and trivial bugs within the privilige control. i.e. - Do not show 'ALL' for only one privilege type. - Show correct privilege label in PrivilegeEditor. - Typo in TEMPORARY privilege. - Added missing toJSON function call, while calli

[pgadmin-hackers] pgAdmin 4 commit: Model needs to update the parent collection object, t

Model needs to update the parent collection object, that - it has been modified, and please do the needful. This allows us to track down the nested objects within the nested objects. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b1bbe55fa61e

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo in the frame javscript

Resolved a typo in the frame javscript Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ba4a6faaa4c77fb4806359dbbc946af5f533e2cb Modified Files -- web/pgadmin/browser/static/js/frame.js | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi Khushboo, Please find below review comments. - While creating new Domain and clicking on SQL tab, python side we are getting error saying "*TypeError: 'bool' object is not callable".* We are not able to create any domain. Fix this issue so that we can test other functionality. - Implement th

[pgadmin-hackers] PATCH: Minor bug fixed for decoding request data [pgAdmin4]

Hi, PFA patch to fix minor issue in decoding request data in server node for Python3. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_server_update_function_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing lis

Re: [pgadmin-hackers] PATCH: Minor bug fixed for decoding request data [pgAdmin4]

Thanks committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jan 21, 2016 at 11:03 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterpr

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo in the datamodel javascript.

Resolved a typo in the datamodel javascript. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=720a9c819baae206ee62f7d235e357784f000439 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/static/js/datamodel.js | 4 ++-- 1 fi

[pgadmin-hackers] pgAdmin 4 commit: [Python 3] Fixed the issue processing the request dat

[Python 3] Fixed the issue processing the request data (decoding issue) for UPDATE operation of the server node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2f6135a98be3a5d53d6e5868f7ba4c39f011e61 Author: Murtuza Zabuawala Modified Files