[pgadmin-hackers] PATCH: Fix for node.ui.js [pgAdmin4]

[Murtuza Zabuawala]

Hi,

PFA patch to fix an issue in node.ui.js,

Issue: There is a typo in node.ui.js for node-ajax-options cell causing
TypeError at client side.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


fix_node-ajax-options_cell.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo in the psycopg2 driver, qtTypeIdent c

[Ashesh Vashi]

Resolved a typo in the psycopg2 driver, qtTypeIdent checking the wrong
list, because - in specific type match comma (,) was missing.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0a21beca17b2227942f64b17fc7d82af3ce9485e

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix comment

[Dave Page]

Fix comment

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b39943e3ff3c900e5d3157cfac993245938a1d5f

Modified Files
--
runtime/BrowserWindow.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix minor status bar display issue.

[Dave Page]

Fix minor status bar display issue.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6cfad4f0170ff44baedfef449a8e092fa7a1771
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix border display issue in unique column collection

[Dave Page]

Fix border display issue in unique column collection

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f18ff04aeb32ca445601efc4877bb20bbce6917
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/static/js/backform.pgadmin.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for minor UI issues [pgadmin4]

[Dave Page]

Thanks, applied.

On Wed, Jan 20, 2016 at 11:23 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA patches for minor issues in status bar and border issue in Unique coll
> collection.
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

[Dave Page]

On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
 wrote:
> On 19.01.2016 16:03, Dave Page wrote:
>>
>>
>> Your patch won't apply again. I have no idea why - I'm trying to do it
>> on my Mac, which is a *nix under the hood (they don't use Mac line
>> endings any more - that was the old Mac OS 9 and earlier from a decade
>> or so ago iirc). How are you creating them? The normal way is to do
>> something like:
>
>
> And how does the attached work? Fresh clone again, only difference is a
> warning (not an error) for whitespaces removed.

Still doesn't apply. I tried on the following systems:

Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
CentOS release 6.7 (Final) - git version 1.7.1

I'm fairly convinced at this stage that there's something funky on
your system. Perhaps we should take a look next week when we're both
in Brussels?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

[Surinder Kumar]

Hi,

I've fixed the issues given in review comments.

Please find the attached updated patch for extension module, review it and
let me know for any comments.

On Mon, Jan 18, 2016 at 5:44 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Thanks Neel for reviewing. I'll send the patch with the fixes suggested.
>
> On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel 
> wrote:
>
>> Hi Surinder,
>>
>> We have applied/tested the patch and below are the review comments.
>>
>> 1. When we select the extension "plpython3u", "plperl", "plperu" etc.
>> then it gives 'TypeError' in Javascript.
>> TypeError: d.version is undefined
>> 'version': (!_.isNull(d.version[0]) ? d.version[0]: '')
>>
>> We are getting this error while selecting many extensions so please test
>> with all types of extensions, it should not give any error at client side.
>>
> Fixed.

>
>> 2.  Use 2 space indentation instead of 4 space in javascript file.
>>
> Done

>
>> 3. In "validate" function in "extension.js" file, validate only the
>> changed values not all, and "this.get('name') - should be called only one
>> time not multiple
>> time".
>>
> Fixed.

>
>> 4. When we pass object identifier, use the function 'qtIdent', and for
>> the values, use function  'qtLiteral' in all the sql files.
>>
> Done.

>
>> 5. By default, when we create the extension, "schema_name" and "version"
>> should not be be set with value. It should be set blank by default.
>>
> Kept blank while creating extension.

>
>> 6. When we create any extension like "citext" then we are not able to
>> create the same extension again after deleting the same extension. May be
>> issue
>> with caching mechanism.
>>
> It is an architecture change. we'll fix it later.

>
>> 7. When we remove the schema_name during the "Edit" operation then wrong
>> SQL is getting generated.
>>
> Fixed, Now it generates right SQL.

>
>>
> 8. Remove "Use Slony" option. As discussed with Ashesh, we will implement
>> it as separate module.
>>
> Removed.

>
>> Please fix the above issues. Let us know if you want more information.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> Thanks,
>> Neel Patel
>>
>>
>> On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Please find the updated patch with following changes:
>>>
>>>1. corrected copyright.
>>>2. Added proper comment for script_module function in __init__.py
>>>file.
>>>3. Renamed collection Node's label to Extensions in extensions.js
>>>file.
>>>
>>>
>>> On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find attached patch for the extension module.
 Please review it and Let me know for any comments.


 Thanks,
 Surinder Kumar

>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>


extension_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

[Magnus Hagander]

On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum <
adsm...@wars-nicht.de> wrote:

> On 21.01.2016 10:31, Dave Page wrote:
>
>> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
>>  wrote:
>>
>>> On 19.01.2016 16:03, Dave Page wrote:
>>>


 Your patch won't apply again. I have no idea why - I'm trying to do it
 on my Mac, which is a *nix under the hood (they don't use Mac line
 endings any more - that was the old Mac OS 9 and earlier from a decade
 or so ago iirc). How are you creating them? The normal way is to do
 something like:

>>>
>>>
>>> And how does the attached work? Fresh clone again, only difference is a
>>> warning (not an error) for whitespaces removed.
>>>
>>
>> Still doesn't apply. I tried on the following systems:
>>
>> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
>> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
>> CentOS release 6.7 (Final) - git version 1.7.1
>>
>> I'm fairly convinced at this stage that there's something funky on
>> your system. Perhaps we should take a look next week when we're both
>> in Brussels?
>>
>>
> After debugging back and forth with Magnus, it looks like that Google Mail
> is fooling you. Your downloaded file has a different line ending, and your
> file is 3269 bytes, where the original file is 3210 bytes. That's 59
> additional line breaks.
>
> 4fa0990a1020e425fe95b99ea9f186de  gp-warning2.diff
>
> The file you download from the archive:
>
> http://www.postgresql.org/message-id/569ebea2.5040...@wars-nicht.de
>
> is also correct.


It's also worth noticing that "patch" has no problem with either of the two
files, but "git apply" does. At least on my system.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

[Magnus Hagander]

On Thu, Jan 21, 2016 at 10:31 AM, Dave Page  wrote:

> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
>  wrote:
> > On 19.01.2016 16:03, Dave Page wrote:
> >>
> >>
> >> Your patch won't apply again. I have no idea why - I'm trying to do it
> >> on my Mac, which is a *nix under the hood (they don't use Mac line
> >> endings any more - that was the old Mac OS 9 and earlier from a decade
> >> or so ago iirc). How are you creating them? The normal way is to do
> >> something like:
> >
> >
> > And how does the attached work? Fresh clone again, only difference is a
> > warning (not an error) for whitespaces removed.
>
> Still doesn't apply. I tried on the following systems:
>
> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
> CentOS release 6.7 (Final) - git version 1.7.1
>
> I'm fairly convinced at this stage that there's something funky on
> your system. Perhaps we should take a look next week when we're both
> in Brussels?
>
>
Tried off a fresh clone of HEAD and it works perfectly:

mha@mha-laptop:~/postgresql/pgadmin3$ patch -p1 < /tmp/gp-warning2.diff
(Stripping trailing CRs from patch; use --binary to disable.)
patching file pgadmin/schema/pgServer.cpp

git 2.1.4 on Debian Jessie

Dave - have you tried off a completely clean checkout as well? In case some
metadata has gotten screwed?

The settings that you have that I don't (so they're not the ones you get by
default) are:

[core]
ignorecase = true
precomposeunicode = true


I wonder if it's the unicode one..


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

[Magnus Hagander]

On Thu, Jan 21, 2016 at 11:13 PM, Magnus Hagander 
wrote:

> On Thu, Jan 21, 2016 at 10:31 AM, Dave Page  wrote:
>
>> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
>>  wrote:
>> > On 19.01.2016 16:03, Dave Page wrote:
>> >>
>> >>
>> >> Your patch won't apply again. I have no idea why - I'm trying to do it
>> >> on my Mac, which is a *nix under the hood (they don't use Mac line
>> >> endings any more - that was the old Mac OS 9 and earlier from a decade
>> >> or so ago iirc). How are you creating them? The normal way is to do
>> >> something like:
>> >
>> >
>> > And how does the attached work? Fresh clone again, only difference is a
>> > warning (not an error) for whitespaces removed.
>>
>> Still doesn't apply. I tried on the following systems:
>>
>> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
>> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
>> CentOS release 6.7 (Final) - git version 1.7.1
>>
>> I'm fairly convinced at this stage that there's something funky on
>> your system. Perhaps we should take a look next week when we're both
>> in Brussels?
>>
>>
> Tried off a fresh clone of HEAD and it works perfectly:
>
> mha@mha-laptop:~/postgresql/pgadmin3$ patch -p1 < /tmp/gp-warning2.diff
> (Stripping trailing CRs from patch; use --binary to disable.)
> patching file pgadmin/schema/pgServer.cpp
>
> git 2.1.4 on Debian Jessie
>


Actually, since I'm using patch to apply it, the relevant version is
probably:
$ patch --version
GNU patch 2.7.5
Copyright (C) 2003, 2009-2012 Free Software Foundation, Inc.
Copyright (C) 1988 Larry Wall


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

[Andreas 'ads' Scherbaum]

On 21.01.2016 10:31, Dave Page wrote:

On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
 wrote:

On 19.01.2016 16:03, Dave Page wrote:



Your patch won't apply again. I have no idea why - I'm trying to do it
on my Mac, which is a *nix under the hood (they don't use Mac line
endings any more - that was the old Mac OS 9 and earlier from a decade
or so ago iirc). How are you creating them? The normal way is to do
something like:



And how does the attached work? Fresh clone again, only difference is a
warning (not an error) for whitespaces removed.


Still doesn't apply. I tried on the following systems:

Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
CentOS release 6.7 (Final) - git version 1.7.1

I'm fairly convinced at this stage that there's something funky on
your system. Perhaps we should take a look next week when we're both
in Brussels?



After debugging back and forth with Magnus, it looks like that Google 
Mail is fooling you. Your downloaded file has a different line ending, 
and your file is 3269 bytes, where the original file is 3210 bytes. 
That's 59 additional line breaks.


4fa0990a1020e425fe95b99ea9f186de  gp-warning2.diff

The file you download from the archive:

http://www.postgresql.org/message-id/569ebea2.5040...@wars-nicht.de

is also correct.

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: minor issue resolved related to retrieval of last system oid

[Sanket Mehta]

Hi,

I found an issue in *connnection* function in
utils/drivers/psycopg2/__init__.py file related to 'datlastsysoid'.
It was not getting retrieved and put inside db_info dict.
Due to this error occurred while expanding cast collection node.


I have resolved the issue and attached a patch with this mail.
Please do review it.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py b/web/pgadmin/utils/driver/psycopg2/__init__.py
index c6c87f1..d4205d2 100644
--- a/web/pgadmin/utils/driver/psycopg2/__init__.py
+++ b/web/pgadmin/utils/driver/psycopg2/__init__.py
@@ -568,7 +568,7 @@ class ServerManager(object):
 status, res = conn.execute_dict("""
 SELECT
 db.oid as did, db.datname, db.datallowconn, pg_encoding_to_char(db.encoding) AS serverencoding,
-has_database_privilege(db.oid, 'CREATE') as cancreate
+has_database_privilege(db.oid, 'CREATE') as cancreate, datlastsysoid
 FROM
 pg_database db
 WHERE db.oid = {0}""".format(did))

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Database patch and other minor patches and control documentation

[Harshal Dhumal]

Hi,

Please find the attached patches:

Database node patch (depends on privilege_macro, node_ui_typo, variable_js
patches)

*How to use controls:*

*1] Privilege control:*

   *a]* Data expected from server in following format:
  eg:


* {grantee: public, privileges: Tc* , grantor: postgres} should be
converted to below object*
  (data parsing logic can be found in databases/__init__.py and
browser/utils.py)

"": [{"grantor": "postgres",
  "privileges": [
 {"with_grant": false,
"privilege_type": "T",
"privilege": true
  },
 {"with_grant": true,
   "privilege_type": "c",
   "privilege": true
}],
"grantee": "public"
}]

  *b]* Privilege control field schema:
 When using this control extend PrivilegeRoleModel with actual
privileges you want to show in your control.
See privilege.js for all supported privileges and their mapping.

{
  id: 'datacl', label: '{{ _('Privileges') }}', model:
pgAdmin.Browser.Node.PrivilegeRoleModel.extend(
{privileges: ['C', 'T', 'c']}), uniqueCol : ['grantee', 'grantor'],
  editable: false, type: 'collection', group: '{{ _('Security') }}',
mode: ['properties', 'edit', 'create'],
  canAdd: true, canDelete: true, control: 'unique-col-collection',
}






*2] Variable control:*
*   a]* Data expected from server:

"variables": [{"database": "db", "value": "ser", "name":
"application_name", "role": "postgres"}, {"database": "db"
, "value": "on", "name": "enable_seqscan", "role": "postgres"}]

 *b] Variable control field schema:*
 Note: database and role fields are optional are not included in variable
control unless specified in field schema.
 Use below flag to enable them



* hasDatabase: true and hasRole:true   (both can not be used at same time)*
(In below example you can see hasRole:true as I need role field in variable
control for database node)

{
  id: 'variables', label: '{{ _('Variables') }}', type: 'collection',
  model: pgAdmin.Browser.Node.VariableModel, editable: false,
  group: '{{ _('Security') }}', mode: ['properties', 'edit', 'create'],
  canAdd: true, canEdit: false, canDelete: true, hasRole: true,
  control: Backform.VariableCollectionControl, node: 'role'
}



Let me know if you have any queries regarding how to use above contorls.

-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 
diff --git a/web/pgadmin/browser/server_groups/servers/static/js/privilege.js b/web/pgadmin/browser/server_groups/servers/static/js/privilege.js
index e1d3b76..b89e676 100644
--- a/web/pgadmin/browser/server_groups/servers/static/js/privilege.js
+++ b/web/pgadmin/browser/server_groups/servers/static/js/privilege.js
@@ -272,6 +272,9 @@
   $(self.$el.find('input[type=checkbox]')).on('blur',function() {
 self.$el.blur();
   });
+
+  $(self.$el).pgMakeVisible('backform-tab');
+
   self.delegateEvents();
 
   return this;
diff --git a/web/pgadmin/browser/server_groups/servers/templates/macros/default_privilege.macros b/web/pgadmin/browser/server_groups/servers/templates/macros/default_privilege.macros
new file mode 100644
index 000..81fb07d
--- /dev/null
+++ b/web/pgadmin/browser/server_groups/servers/templates/macros/default_privilege.macros
@@ -0,0 +1,14 @@
+{% macro APPLY(conn, type, role, priv, with_grant) -%}
+{% if priv %}
+ALTER DEFAULT PRIVILEGES
+GRANT {{ priv }} ON {{ type }} TO {{ self.conn|qtIdent(role) }};
+{% endif %}
+{% if with_grant %}
+ALTER DEFAULT PRIVILEGES
+GRANT {{ with_grant }} ON {{ type }} TO {{ self.conn|qtIdent(role) }} WITH GRANT OPTION;
+{% endif %}
+{%- endmacro %}
+{% macro RESETALL(conn, type, role) -%}
+ALTER DEFAULT PRIVILEGES
+REVOKE ALL ON {{ type }} FROM {{ self.conn|qtIdent(role) }};
+{%- endmacro %}
\ No newline at end of file
diff --git a/web/pgadmin/browser/server_groups/servers/templates/macros/privilege.macros b/web/pgadmin/browser/server_groups/servers/templates/macros/privilege.macros
new file mode 100644
index 000..08d53a4
--- /dev/null
+++ b/web/pgadmin/browser/server_groups/servers/templates/macros/privilege.macros
@@ -0,0 +1,11 @@
+{% macro APPLY(conn, type, role, param, priv, with_grant) -%}
+{% if priv %}
+GRANT {{ priv }} ON {{ type }} {{ self.conn|qtIdent(param) }} TO {{ self.conn|qtIdent(role) }};
+{% endif %}
+{% if with_grant %}
+GRANT {{ with_grant }} ON {{ type }} {{ self.conn|qtIdent(param) }} TO {{ self.conn|qtIdent(role) }} WITH GRANT OPTION;
+{% endif %}
+{%- endmacro %}
+{% macro RESETALL(conn, type, role, param) -%}
+REVOKE ALL ON {{ type }} {{ self.conn|qtIdent(param) }} FROM {{ self.conn|qtIdent(role) }};
+{%- endmacro %}
\ No newline at end of file
diff --git 

Re: [pgadmin-hackers] PATCH: minor issue resolved related to retrieval of last system oid

[Ashesh Vashi]

Thanks applied.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Fri, Jan 22, 2016 at 10:31 AM, Sanket Mehta <
sanket.me...@enterprisedb.com> wrote:

> Hi,
>
> I found an issue in *connnection* function in
> utils/drivers/psycopg2/__init__.py file related to 'datlastsysoid'.
> It was not getting retrieved and put inside db_info dict.
> Due to this error occurred while expanding cast collection node.
>
>
> I have resolved the issue and attached a patch with this mail.
> Please do review it.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Fetch the last system oid for the database connection

[Ashesh Vashi]

Fetch the last system oid for the database connection too.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0eadd92a7f56a4a10f4a88d4256fef4a8768e81c
Author: Sanket Mehta 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

[Surinder Kumar]

Hi

Please find the updated patch with following fixes:
1. Missing `owner` column under properties for `extensions collection`. Add
cell: 'string' property for owner fixed it
2. Schema object identifier should be wrapped with in function qtIdent .
Using function `qtIdent` for schema in create.sql fixed it.


Thanks
Surinder Kumar

On Thu, Jan 21, 2016 at 8:04 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> I've fixed the issues given in review comments.
>
> Please find the attached updated patch for extension module, review it and
> let me know for any comments.
>
> On Mon, Jan 18, 2016 at 5:44 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Thanks Neel for reviewing. I'll send the patch with the fixes suggested.
>>
>> On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel 
>> wrote:
>>
>>> Hi Surinder,
>>>
>>> We have applied/tested the patch and below are the review comments.
>>>
>>> 1. When we select the extension "plpython3u", "plperl", "plperu" etc.
>>> then it gives 'TypeError' in Javascript.
>>> TypeError: d.version is undefined
>>> 'version': (!_.isNull(d.version[0]) ? d.version[0]: '')
>>>
>>> We are getting this error while selecting many extensions so please test
>>> with all types of extensions, it should not give any error at client side.
>>>
>> Fixed.
>
>>
>>> 2.  Use 2 space indentation instead of 4 space in javascript file.
>>>
>> Done
>
>>
>>> 3. In "validate" function in "extension.js" file, validate only the
>>> changed values not all, and "this.get('name') - should be called only one
>>> time not multiple
>>> time".
>>>
>> Fixed.
>
>>
>>> 4. When we pass object identifier, use the function 'qtIdent', and for
>>> the values, use function  'qtLiteral' in all the sql files.
>>>
>> Done.
>
>>
>>> 5. By default, when we create the extension, "schema_name" and "version"
>>> should not be be set with value. It should be set blank by default.
>>>
>> Kept blank while creating extension.
>
>>
>>> 6. When we create any extension like "citext" then we are not able to
>>> create the same extension again after deleting the same extension. May be
>>> issue
>>> with caching mechanism.
>>>
>> It is an architecture change. we'll fix it later.
>
>>
>>> 7. When we remove the schema_name during the "Edit" operation then wrong
>>> SQL is getting generated.
>>>
>> Fixed, Now it generates right SQL.
>
>>
>>>
>> 8. Remove "Use Slony" option. As discussed with Ashesh, we will implement
>>> it as separate module.
>>>
>> Removed.
>
>>
>>> Please fix the above issues. Let us know if you want more information.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>>
>>> On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Please find the updated patch with following changes:

1. corrected copyright.
2. Added proper comment for script_module function in __init__.py
file.
3. Renamed collection Node's label to Extensions in extensions.js
file.


 On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch for the extension module.
> Please review it and Let me know for any comments.
>
>
> Thanks,
> Surinder Kumar
>



 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


>>>
>>
>


extension_v3.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Resovled a typo in rendering the NodeAjaxOptionsCell

[Ashesh Vashi]

Resovled a typo in rendering the NodeAjaxOptionsCell about getting the
options from the column schema for the cell.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f3c972d066b5378e6a368622b210399add4183d
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/browser/static/js/node.ui.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers