[pgadmin-hackers] pgAdmin 4 commit: Resolved the issue related showing errors in the radi

2016-02-22 Thread Ashesh Vashi
Resolved the issue related showing errors in the radio control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db9b5f0e0c54e94028335adf98a228fadec1ba6e Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 38

[pgadmin-hackers] pgAdmin 4 commit: Do not need to implement the BackendSupported functio

2016-02-22 Thread Ashesh Vashi
Do not need to implement the BackendSupported function in resource group, we do have the same function in CollectionModule class, which will work, when we set the min_ver, max_ver and server_type properly. Thanks Khushboo for pointing that out, and Akshay for quick testing for this patch. Branch

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Dave Page
On Mon, Feb 22, 2016 at 10:53 AM, Dave Page wrote: > > > On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> On Mon, Feb 15, 2016 at 3:47 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Feb 15, 2016 at 7:29

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

2016-02-22 Thread Dave Page
Committed, with a couple of additional minor changes: - s/resourcegroups/resource_groups (for consistency with server_groups) - Added a PyDoc module description to __init__.py Thanks! On Mon, Feb 22, 2016 at 4:29 AM, Neel Patel wrote: > Hi Akshay, > > After

[pgadmin-hackers] pgAdmin 4 commit: Add support for Resource Groups in EDB Advanced Serve

2016-02-22 Thread Dave Page
Add support for Resource Groups in EDB Advanced Server 9.4+. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dafd2f33234ff5a59f9f5b1c23bcfc81f01f659f Author: Akshay Joshi Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Dave Page
On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi All > > On Mon, Feb 15, 2016 at 3:47 PM, Dave Page wrote: > >> >> >> On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>>

Re: [pgadmin-hackers] backform.pgadmin: fix for showing multiple errors for radio control [pgadmin4]

2016-02-22 Thread Ashesh Vashi
On Thu, Feb 11, 2016 at 6:44 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for backform.pgadmin.js > > *Issue fixed*: Backform was showing same error multiple times (equal to > no. of radio buttons in radio group) in dialog. > Approach for this patch is wrong,

[pgadmin-hackers] pgAdmin 4 commit: Adding Numeric control support for Backform.

2016-02-22 Thread Ashesh Vashi
Adding Numeric control support for Backform. This patch also includes an issue related to IntegerControl, which does not emit any error message, when it has some issues. In order to fix the issue, it will trigger 'pgadmin-session:invalid' event, when the input value is not an valid integer.

[pgadmin-hackers] pgAdmin 4 commit: public in the privilege control should not be allowed

2016-02-22 Thread Ashesh Vashi
public in the privilege control should not be allowed to select the 'WITH GRANT' options. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b956813d4250200145a290c0e99d53a005fe280 Author: Harshal Dhumal

[pgadmin-hackers] Fixed runtime compilation error for Qt4

2016-02-22 Thread Neel Patel
Hi All, As sandeep from EDB was doing the setup for pgAdmin4 runtimes in CentOS 7 with Qt4 and found that there were some compilation errors. Please find the attached patch file which will fix the below compilation errors for Qt4. - QtWebKitWidgets should only be included in Qt5. There is no

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Dependecies/Dependents functionality

2016-02-22 Thread Dave Page
Thanks - patch applied. On Mon, Feb 22, 2016 at 7:57 AM, Akshay Joshi wrote: > Hi All > > I have modified the logic as per suggested by Dave. In new implementation > I have added two methods "get_dependencies" and "get_dependents" to the > class

[pgadmin-hackers] pgAdmin 4 commit: Add support for displaying dependency and dependents

2016-02-22 Thread Dave Page
Add support for displaying dependency and dependents info. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c153032e3bffc4acb88d513a484a150259b64864 Author: Akshay Joshi Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Akshay Joshi
Hi All Attached is the modified patch with support of Dependents and Dependencies tabs. Please review it. On Mon, Feb 22, 2016 at 5:29 PM, Dave Page wrote: > > > On Mon, Feb 22, 2016 at 10:53 AM, Dave Page wrote: > >> >> >> On Fri, Feb 19, 2016 at 10:48

[pgadmin-hackers] pgAdmin 4 commit: Returns an error when the driver couldn't decrypt the

2016-02-22 Thread Ashesh Vashi
Returns an error when the driver couldn't decrypt the password, and let the user know the issue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3b0e1dec41bb2c4fa75842ed4ce25b78f0dc6e7 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo in Server Module related to assigning

2016-02-22 Thread Ashesh Vashi
Resolved a typo in Server Module related to assigning manager object to driver variable. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bbf037f005001531728c5957ece1b86d43011ada Modified Files --