Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

Hi, I forgot to add 'node.ui.js' file in the previous patch, please ignore the previous patch. Attached is the new patch, Please review the patch and let me know for any comments. On Tue, Mar 8, 2016 at 10:44 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > PFA patch with

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

Hi, Do you have a test dialogue or similar in which I can test this code? Ideally an addition to the test module would be good. Thanks. On Tue, Mar 8, 2016 at 7:34 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA backform control for selecting multiple columns.(This co

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

Hi Dave, Currently there is no test dialogue to test this control. Also Ashesh has suggested some changes. Once I complete those changes; I'll resubmit the patch along with test dialogue to test it. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Tue

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

On Tue, Mar 8, 2016 at 10:00 AM, Surinder Kumar wrote: > Hi, > > I forgot to add 'node.ui.js' file in the previous patch, please ignore the > previous patch. > Attached is the new patch, > > Please review the patch and let me know for any comments. Is this dependent on any other patches? The menu

Re: [pgadmin-hackers] PATCH: Collation node [pgAdmin4]

Hi Dave, PFA updated patch for collation node. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 25, 2016 at 7:53 PM, Dave Page wrote: > Hi > > On Tue, Feb 9, 2016 at 10:15 AM, Murtuza Zabuawala < > murtuza.z

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

The menu option is dependent only on certain nodes like: 1. Schema Node 2. Views Collection Node 3. Tables Collection Node 4. Sequences Collection Node 5. Functions Collection Node It will be enabled on click of above listed nodes. On Tue, Mar 8, 2016 at 6:57 PM, Dave Page wrote: > On Tue, Mar

[pgadmin-hackers] PATCH: Updated ACL parsing function. [pgAdmin4]

Hi All, I have updated "parse_priv_to_db" function to return list instead of string. I have also updated the common macro template under servers node. (Please review & verify respective nodes ACL functionality though) This will also allow us to operate on individual privileges & also we needed th

[pgadmin-hackers] PATCH: Updated acl parsing on tablespace node [pgAdmin4]

Hi, PFA updated patch to update acl parsing with new changes. Removed hardcoded string and passed acl list instead. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Updated_tablespace_acl_parsing.patch Description: Binary data -- Sent

[pgadmin-hackers] Bug fixed in Asynchronous connection

Hi All During testing I have found one issue in Asynchronous connection logic, we fetch column info only when there is some row return by the sql query, which is not correct, Column info should be fetch even if there is no data, so at least we can display the columns. Attached is the patch to fix

Re: [pgadmin-hackers] PATCH: Schema/Catalog Node [pgAdmin4]

On Tue, Mar 8, 2016 at 2:18 PM, Ashesh Vashi wrote: > On Tue, Mar 8, 2016 at 7:36 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Mar 8, 2016 at 12:20 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> >>> On Thu, Mar 3, 2016

Re: [pgadmin-hackers] PATCH: Schema/Catalog Node [pgAdmin4]

On Tue, Mar 8, 2016 at 8:08 PM, Dave Page wrote: > > > On Tue, Mar 8, 2016 at 2:18 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Mar 8, 2016 at 7:36 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Mar 8, 2016 at 12:20 AM, Ashes

[pgadmin-hackers] pgAdmin 4 commit: Add support for Schemas and Catalogs.

Add support for Schemas and Catalogs. Initial patch by Murtuza Zabuawala with further hacking by Ashesh Vashi and I. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a92d4841d1f47fdac018a9d0654234d82052d5cf Modified Files -- .../ser

Re: [pgadmin-hackers] PATCH: Schema/Catalog Node [pgAdmin4]

On Tue, Mar 8, 2016 at 2:46 PM, Ashesh Vashi wrote: > On Tue, Mar 8, 2016 at 8:08 PM, Dave Page wrote: >> >> >> >> On Tue, Mar 8, 2016 at 2:18 PM, Ashesh Vashi >> wrote: >>> >>> On Tue, Mar 8, 2016 at 7:36 PM, Ashesh Vashi >>> wrote: Hi Dave, On Tue, Mar 8, 2016 at 12:20 AM,

[pgadmin-hackers] pgAdmin 4 commit: Always fetch column info from the server, even if the

Always fetch column info from the server, even if there are no rows. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f08aa6a3138a4e762548b33bc104f2bee2675bb4 Author: Akshay Joshi Modified Files -- web/pgadmin/utils/driver/psycopg2/

Re: [pgadmin-hackers] Bug fixed in Asynchronous connection

Thanks, committed. On Tue, Mar 8, 2016 at 2:29 PM, Akshay Joshi wrote: > Hi All > > During testing I have found one issue in Asynchronous connection logic, > we fetch column info only when there is some row return by the sql query, > which is not correct, Column info should be fetch even if the

Re: [pgadmin-hackers] PATCH: Schema/Catalog Node [pgAdmin4]

On Tue, Mar 8, 2016 at 9:23 PM, Dave Page wrote: > On Tue, Mar 8, 2016 at 2:46 PM, Ashesh Vashi > wrote: > > On Tue, Mar 8, 2016 at 8:08 PM, Dave Page wrote: > >> > >> > >> > >> On Tue, Mar 8, 2016 at 2:18 PM, Ashesh Vashi > >> wrote: > >>> > >>> On Tue, Mar 8, 2016 at 7:36 PM, Ashesh Vashi >

Re: [pgadmin-hackers] PATCH: Schema/Catalog Node [pgAdmin4]

On Tue, Mar 8, 2016 at 4:34 PM, Ashesh Vashi wrote: > On Tue, Mar 8, 2016 at 9:23 PM, Dave Page wrote: > >> On Tue, Mar 8, 2016 at 2:46 PM, Ashesh Vashi >> wrote: >> > On Tue, Mar 8, 2016 at 8:08 PM, Dave Page wrote: >> >> >> >> >> >> >> >> On Tue, Mar 8, 2016 at 2:18 PM, Ashesh Vashi >> >> w