[pgadmin-hackers] pgAdmin 4 commit: Improvise the psycopg2 wrapped driver for PostgreSQL

2016-04-04 Thread Ashesh Vashi
Improvise the psycopg2 wrapped driver for PostgreSQL to show formatted message on demand. Also - resolved an issue identifying the aborted transaction while using the asychronous connection. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53310

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add formatted error message support in psycopg2

2016-04-04 Thread Ashesh Vashi
Committed with minor change. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Apr 1, 2016 at 5:17 PM, Akshay Joshi wrote: > Hi > > On Fr

Re: [pgadmin-hackers] Patch: Added select2cell editor for backgrid [pgAdmin4]

2016-04-04 Thread Murtuza Zabuawala
Hi, PFA updated patch. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Apr 1, 2016 at 3:08 PM, Ashesh Vashi wrote: > On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com

Re: [pgadmin-hackers] PATCH: pgadmin 4: FTS Parser

2016-04-04 Thread Ashesh Vashi
On Mon, Mar 28, 2016 at 2:32 PM, Sanket Mehta wrote: > Hi, > > PFA the patch for FTS parser node for review. > Please do review it and provide the comments. > Hi Sanket, Thanks for the patch. Please find my review comments. * 'current_app' has been imported but not used. * Few variables are ass

[pgadmin-hackers] pgAdmin 4 commit: Use separate editor for Select2Cell.

2016-04-04 Thread Ashesh Vashi
Use separate editor for Select2Cell. This allows us to use the Backgrid key navigation as expected. This has also resulted into an issue - related unresponsive scrollbar issue in the SubNodeControl. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff

Re: [pgadmin-hackers] Patch: Added select2cell editor for backgrid [pgAdmin4]

2016-04-04 Thread Ashesh Vashi
Thanks - committed with small changes. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Apr 4, 2016 at 1:09 PM, Murtuza Zabuawala < murtuz

[pgadmin-hackers] [pgAdmin4][psycopg2] - Modified status message implementation

2016-04-04 Thread Neel Patel
Hi, Please find attached patch file which modified the earlier statusmessage implementation. *Previous implementation:- * statusmessage was implemented inside the poll function and if poll result row is greater than zero then statusmessage was replaced by the result row returned so if user wants

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

2016-04-04 Thread Khushboo Vashi
Hi Ashesh, I have changed the function name (from *render_deps* to *updateUIDeps*), which will be called on the dependent field change, as per your suggestion. Please find attached patch for the same. Thanks, Khushboo On Fri, Apr 1, 2016 at 3:56 PM, Khushboo Vashi < khushboo.va...@enterprisedb.

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

2016-04-04 Thread Ashesh Vashi
On Wed, Mar 30, 2016 at 5:14 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find updated patch. > > This patch has following changes: > 1. Improved code commenting. > 2. Properly handling memory leak issues in js code. > Hi Surinder, As discussed offline, here are t