Re: [pgadmin-hackers] PATCH: graphical explain

2016-04-13 Thread Dave Page
Hi, A couple of comments following a quick test: 1) Some of the horizontal lines are not actually horizontal - they noticeably drop down. Please see the attached screenshot. 2) I thought we were going to use a "viewport" to allow the user to navigate through the diagram? I was thinking of displa

Re: [pgadmin-hackers] Top Menu Link cursor change text to pointer [pgadmin4]

2016-04-13 Thread Dave Page
Thanks - patch applied. On Tue, Apr 12, 2016 at 10:33 PM, Seçkin Alan wrote: > Hi, > Top Menu Link cursor change text to pointer. > > because is does not give the feeling of link. > > -- > Seçkin ALAN > http://sckn.org > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.o

[pgadmin-hackers] pgAdmin 4 commit: Fix the mouse pointer on the top-level menus.

2016-04-13 Thread Dave Page
Fix the mouse pointer on the top-level menus. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de2e7bf8f1680ad321700b99dce45181b7d959e5 Author: Seçkin Alan Modified Files -- web/pgadmin/static/css/overrides.css | 1 + 1 file changed,

[pgadmin-hackers] pgAdmin 4 commit: Fix label

2016-04-13 Thread Dave Page
Fix label Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd5e86bcf4f159c7c2ef007b2ed70c4de9886580 Modified Files -- .../servers/databases/languages/templates/languages/js/languages.js | 2 +- 1 file changed, 1 insertion(+), 1 de

[pgadmin-hackers] pgAdmin 4 commit: Improvements to frame management.

2016-04-13 Thread Dave Page
Improvements to frame management. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e2d349591d2aa8287e13f611d1fb29a90928b16 Author: Ashesh Vashi Modified Files -- web/pgadmin/browser/static/js/frame.js | 19 +-- 1 fil

[pgadmin-hackers] pgAdmin 4 commit: Fix CodeMirror borders on dialogues.

2016-04-13 Thread Dave Page
Fix CodeMirror borders on dialogues. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0fb0820c642c4eab1170d0ff6ac3ef499d4ed2b3 Author: Arun Kollan Modified Files -- web/pgadmin/static/css/overrides.css | 22

[pgadmin-hackers] PATCH: Added canAddRow/canEditRow/canDeleteRow functionality for grid

2016-04-13 Thread Murtuza Zabuawala
Hi, PFA minor patch which will add canAddRow/canEditRow/canDeleteRow functionality for Backgrid. This will allow user to check condition on individual opration(add/edit/delete row) rather than only while rendering the control. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

2016-04-13 Thread Dave Page
Hi I'm seeing some more issues now, some related to new functionality: - Please don't include the descriptive header for shell types in create.sql. - Shell types can (and should) have owner/comments set if specified. - The Type dropdown should just say "Shell" for shell types (no additional tex

Re: [pgadmin-hackers] PATCH: Added canAddRow/canEditRow/canDeleteRow functionality for grid

2016-04-13 Thread Dave Page
Thanks, applied. On Wed, Apr 13, 2016 at 1:35 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch which will add canAddRow/canEditRow/canDeleteRow > functionality for Backgrid. > > This will allow user to check condition on individual > opration(add/edit/delete row) rather than only while rend

[pgadmin-hackers] pgAdmin 4 commit: Add canAddRow/canEditRow/canDeleteRow functionality f

2016-04-13 Thread Dave Page
Add canAddRow/canEditRow/canDeleteRow functionality for Backgrid. This will allow user to check condition on individual opration(add/edit/delete row) rather than only while rendering the control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h

[pgadmin-hackers] pgAdmin 4 commit: Grant wizard.

2016-04-13 Thread Dave Page
Grant wizard. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40c592a9888b412b475e6f9f2f42c93940a93f13 Author: Surinder Kumar Modified Files -- web/pgadmin/browser/static/css/wizard.css | 143 +++ web/pgadmin/browser/stati

[pgadmin-hackers] grant_wizard py3 bug

2016-04-13 Thread Seçkin Alan
Hi, I want the run pgadmin4 on python3, throw unquote module not found. In python3 unquote method moved root to parse class https://docs.python.org/3.4/library/urllib.parse.html#urllib.parse.unquote Maybe isn't clear patch. -- Seçkin ALAN http://sckn.org diff --git a/web/pgadmin/tools/grant_

[pgadmin-hackers] pgAdmin 4 commit: [Python 3 compability] Fixed the issue introduced by

2016-04-13 Thread Ashesh Vashi
[Python 3 compability] Fixed the issue introduced by the Grant Wizard, which fixes a issue with the Python 3. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af1e38a97a70c3b668f4ae87559d114fdbbd5604 Author: Seçkin Alan Modified Files -

Re: [pgadmin-hackers] grant_wizard py3 bug

2016-04-13 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Apr 14, 2016 at 12:40 AM, Seçkin Alan wrote: > Hi, > I want the run