[pgadmin-hackers] pgAdmin 4 commit: Restyle alertify dialogues so they look like the rest

2016-04-15 Thread Dave Page
Restyle alertify dialogues so they look like the rest of the app. Still some tweaks needed, but we're 95% of the way there. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=533aaa2fa3844220240f41df9af6202dca891756 Author: Arun Kollan

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

2016-04-15 Thread Surinder Kumar
Hi, PFA patch with following issues fixed: 1. Fixed 'get_schemas.sql' template for PPAS. It was fetching system level schemas due to wrong sql query. 2. Allowed the grant wizard to open on procedures node if server type is PPAS. Also, I will send another patch for the remaining

Re: [pgadmin-hackers] [pgAdmin4][Patch]: SQL Help Fix

2016-04-15 Thread Dave Page
Thanks, committed. On Fri, Apr 15, 2016 at 2:10 PM, Khushboo Vashi wrote: > Hi, > > The SQL Help Tab does not load the Help page on the Google Chrome (version: > 39.0) browser. > > Please find the attached patch for the same. > > Thanks, > Khushboo > > > -- >

[pgadmin-hackers] pgAdmin 4 commit: Improvised the data clean up, in some cases, it was c

2016-04-15 Thread Ashesh Vashi
Improvised the data clean up, in some cases, it was calling validation due to internal 'set' function call from the internal 'reset' function. We will stop the session management, before doing any clean up for ignoring such events. Branch -- master Details ---

Re: [pgadmin-hackers] Alertify Dialog (CSS)

2016-04-15 Thread Dave Page
Thanks - applied. There are still some minor issues to resolve which Arun will continue to work on; - Status bar height - Button height - Sizing of the X in the close button. On Fri, Apr 15, 2016 at 3:14 PM, Arun Kollan wrote: > Hi Team, > Please find attached

[pgadmin-hackers] pgAdmin 4 commit: Fix SQL Help on older browsers without string.endsWit

2016-04-15 Thread Dave Page
Fix SQL Help on older browsers without string.endsWith(). Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de0864a92c6ff1b08ce9cff42c02e4b71f72dbd3 Author: Khushboo Vashi Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix the properties toolbar at the top of the panel so

2016-04-15 Thread Dave Page
Fix the properties toolbar at the top of the panel so it's always visible. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e42e48244a7dfa8d300cd5184a0986360370cab Author: Ashesh Vashi Modified Files

[pgadmin-hackers] [pgAdmin4] Query Tools result paginate control labels

2016-04-15 Thread Seçkin Alan
Hi, Backgrid js default control label is 《, it looks bad. now it looks like this << < 1 > >> ​ -- Seçkin ALAN http://sckn.org diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js index 463ee45..f0fed4d

[pgadmin-hackers] [pgAdmin4] Server Groups Delete patch

2016-04-15 Thread Seçkin Alan
Drop server groups. -- Seçkin ALAN http://sckn.org diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js index 0b52519..890c3dc 100644 --- a/web/pgadmin/browser/templates/browser/js/node.js +++

Re: [pgadmin-hackers] Dialogues not closing

2016-04-15 Thread Ashesh Vashi
Hi Dave, On Fri, Apr 15, 2016 at 1:20 PM, Dave Page wrote: > > > On Fri, Apr 15, 2016 at 6:32 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Fri, Apr 15, 2016 at 2:23 AM, Dave Page wrote: >> >>> Hey Ashesh, >>> >>> We have an issue

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-15 Thread Dave Page
Thanks - committed. On Fri, Apr 15, 2016 at 8:03 AM, Akshay Joshi wrote: > > > On Thu, Apr 14, 2016 at 7:40 PM, Dave Page > wrote: > >> Hi >> >> On Thu, Apr 14, 2016 at 1:58 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote:

[pgadmin-hackers] pgAdmin 4 commit: Fix "View Filtered Rows" option.

2016-04-15 Thread Dave Page
Fix "View Filtered Rows" option. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c65b73f31581b8625fbc4168ded68cb9a3894da Modified Files -- web/pgadmin/tools/datagrid/templates/datagrid/js/datagrid.js | 5 +++--

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-15 Thread Akshay Joshi
On Thu, Apr 14, 2016 at 7:40 PM, Dave Page wrote: > Hi > > On Thu, Apr 14, 2016 at 1:58 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> I have fixed review comments given by Dave and couple of them are >> remaining >> >> *Fixed Review

Re: [pgadmin-hackers] Dialogues not closing

2016-04-15 Thread Dave Page
On Fri, Apr 15, 2016 at 6:32 AM, Ashesh Vashi wrote: > On Fri, Apr 15, 2016 at 2:23 AM, Dave Page wrote: > >> Hey Ashesh, >> >> We have an issue with dialogues not closing on Save button presses. >> One of the team told me yesterday or the day

[pgadmin-hackers] Initial Check constraint node patch [Pgadmin4]

2016-04-15 Thread Harshal Dhumal
Hi, PFA initial patch for check constraint. Note: This patch has dependency on Table, Column node and Index constraint. As of now all (5) constraint nodes are completed (initial patches). -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git

[pgadmin-hackers] pgAdmin 4 commit: Deleting the object (model & nested model/collection)

2016-04-15 Thread Ashesh Vashi
Deleting the object (model & nested model/collection) during showing the node properties. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=58fcbd943a277793bd0170f3b005e666881a7142 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Confine whitespace prewrap to the SQL Editor's output

2016-04-15 Thread Dave Page
Confine whitespace prewrap to the SQL Editor's output grid to prevent it breaking subnode forms. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf80db66a612541f77d0112a33cf0b22f62e2035 Modified Files --

Re: [pgadmin-hackers] Dialogues not closing

2016-04-15 Thread Ashesh Vashi
Oops.. clicked before attaching... -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Apr 15, 2016 at 4:18 PM, Ashesh Vashi

Re: [pgadmin-hackers] Dialogues not closing

2016-04-15 Thread Ashesh Vashi
Hi Dave, I was able to reproduce the issue with the help of Murtuza. I missed one corner case - it was not able to close the dialog, when the parent/collection has not yet been loaded. Please find the updated patch. This patch only includes the dialog issue. Please let me know - if you still see

[pgadmin-hackers] pgAdmin 4 commit: Icon and toolbar cleanup/consistency.

2016-04-15 Thread Dave Page
Icon and toolbar cleanup/consistency. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d7d3bd5e1134cb800b5b2b34b7d11690bc13945 Modified Files -- web/pgadmin/browser/static/js/frame.js | 7 -

Re: [pgadmin-hackers] Dialogues not closing

2016-04-15 Thread Dave Page
That seems to have got it - thanks! On Fri, Apr 15, 2016 at 11:48 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Oops.. clicked before attaching... > > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > >

[pgadmin-hackers] pgAdmin 4 commit: Fix dialogue close issue.

2016-04-15 Thread Dave Page
Fix dialogue close issue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7ca939dcaf9bffa720d28b0cdb183f02b1926dc3 Author: Ashesh Vashi Modified Files --

[pgadmin-hackers] [pgAdmin4][Patch]: SQL Help Fix

2016-04-15 Thread Khushboo Vashi
Hi, The SQL Help Tab does not load the Help page on the Google Chrome (version: 39.0) browser. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js index 331d818..d38eee7