Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-07 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Apr 27, 2016 at 6:13 PM, Thom Brown wrote: > On 27 April 2016 at 10:22, Harshal Dhumal > wrote: > > > > Hi, > > > > PFA attached patches for table node and all table child nodes. > > > > This

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-07 Thread Harshal Dhumal
Hi, i have fixed all of below mentioned issues. > A couple more: > > > If I go to create a new table, give it a name, select a table to > inherit from, and then do nothing else, I get an error: > > ERROR: syntax error at or near "INHERITS" > LINE 2: INHERITS (test) > ^ > > This is because no c

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-07 Thread Harshal Dhumal
Hi, Please find below responses. > > Please find the review comments so far: > > 1. On the Table Collection node, The fields in the grid should be Name, > Owner and Comments. OID is not required. Please follow same for the other > Nodes like Index, Constraints etc. > Fixed > 2. While Updating t