Re: [pgadmin-hackers] pgAdmin4 - Session file name too large

Hi guys, i was just updating my working copy of git, and got the same issue again. it seems that the issue happend every time (or at least really often) when i pull new changes. so it might still be some issues with the session management. to hel you understand my workflow, here are the step tha

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Hi Khushboo, Please find comments as below, (Tested with Python3) 1) Default string value is not quoted properly which causing SQL to break, here default string should be 'my test string' for myCol2. CREATE FOREIGN TABLE "Test123"."test1_Server" ("myCol" bigint NOT NULL DEFAULT 213 COLLATE pg_

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

On Mon, May 9, 2016 at 5:50 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch for the Foreign Tables module. > > Thanks, > Khushboo > > On Mon, May 9, 2016 at 1:46 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >>

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Hi On Fri, Apr 15, 2016 at 4:31 PM, Paresh More wrote: > Hello Dave, > > I have made changes according which you mentioned. > > Binary is located @ location > > https://uploads.enterprisedb.com/download.php?file=1f92c5abbaf7014d9aa8fb0711d53f6d > > Patch is attached in the Email. > > - Please mo

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi Initial eyeball review comments below... On Fri, Apr 22, 2016 at 11:57 AM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Team, Dave, > > Attached herewith are two patches. > > *pgadmin4-rpm.patch* - This is the main patch that includes scripts, > makefiles and spec to create

Re: [pgadmin-hackers] PATCH: pgAdmin4 debian installer

Hi Please see my earlier comments regarding the RPM packages - many of them apply to this patch as well: http://www.postgresql.org/message-id/ca+ocxoxbdt82p75q4cy4fbkznkpbw3yjwpz+wfarbbbsoi3...@mail.gmail.com By way of additional comment, why does pkg/deb/README include a bunch of boiler-plate te

[pgadmin-hackers] Improved password error message ui on password change page [pgadmin4]

Hi, PFA minor patch for password change page. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 2531863..00a9829 100755 --- a/web/pgadmin/static/css/overrides.css

[pgadmin-hackers] PATCH: minor typo in fts dictionary node

Hi, PFA the patch for minor typo issue in fts dictionary node. Please do review it and commit if found proper. Regards, Sanket Mehta Sr Software engineer Enterprisedb diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/no