Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-23 Thread Sandeep Thakkar
Hi Dave I have fixed this issue. Instead of getting path from otool, script now uses QTDIR variable to copy the framework directory. Please find the updated patch attached. Thanks. On Thu, May 19, 2016 at 7:39 PM, Dave Page wrote: > On Thu, May 19, 2016 at 10:05 AM, Sandeep

[pgadmin-hackers] [pgAdmin4]: Query tool and debugger height issue

2016-05-23 Thread Neel Patel
Hi, Because of the following commit, the query tool and debugger are not getting open in the browser window. We have fixed in runtime environment. Please find below link for reference. This issue is only reproducible in mozilla firefox browser.

[pgadmin-hackers] pgAdmin 4 commit: Fixed the issue related to set proper height, width o

2016-05-23 Thread Ashesh Vashi
Fixed the issue related to set proper height, width of the div of a frame in wcFrame. This is only happens only in the Firefox browser. This was regression of the commit-id: 9a832086c5c4c0dda51c43edd7fc4f40dda63a0c. Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4]: Query tool and debugger height issue

2016-05-23 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, May 23, 2016 at 12:05 PM, Neel Patel

[pgadmin-hackers] [pgAdmin4][Patch]: Auto redirect to page on opening FileManager when used in Fieldset

2016-05-23 Thread Surinder Kumar
Hi, *Issue*: When FileControl is used in * *tag, it auto redirects to some url when FileManager is opened up. *Reason: *The issue was due to ** tag, when a jQuery event which is bound to an element gets fired, the event callback then delegate the click event to the parent element which is form

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Auto redirect to page on opening FileManager when used in Fieldset

2016-05-23 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, May 23, 2016 at 4:15 PM, Surinder Kumar <

[pgadmin-hackers] pgAdmin 4 commit: Fixes the issue about redirection to undesirable URL

2016-05-23 Thread Ashesh Vashi
Fixes the issue about redirection to undesirable URL when clicked on the file control selection button. All our views are inherited from the Backform.Form (a extended Backbone.View), which has an tag element set to 'form'. The default action for a button in form is to submit the data, and that

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-23 Thread Murtuza Zabuawala
Hi, PFA patch, which will fixes below mentioned issues, - Fixed all the review comments given by Dave on tables & its child nodes. *Additional enhancements* - In Index node, We have updated the way columns were added, earlier it was using subnode control now we can insert/update values