[pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PAF patch for issue RM1336 Changes: Added keyboard shortcuts (static/non configurable) to some query tool operations. Execute --> Ctrl + Shift + E Explain -->Ctrl + Shift + X Explain analyze --> Ctrl + Shift + A Note: Keyboard shortcuts do not work if focus is set on any

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, Function keys won't work properly with browser as they already have predefined bindings. e.g. F5 for refresh (standard) F7 for Caret Browsing in firefox -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On

[pgadmin-hackers] pgAdmin 4 commit: Add files missed from previous commit.

Add files missed from previous commit. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8d0f410df719e01420bf95f4c5b60515f730be3 Modified Files -- docs/en_US/images/add_pgadmin_user.png | Bin 0 -> 38475 bytes

Re: [pgadmin-hackers] Patches

Hi On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar wrote: > Hi, > > I created virtual environment and tried building pgadmin on my Mac with > Python 3.3 and QT 5.5. I observed that in venv, the python3-config is copied > as python-config. Therefore, it's

Re: [pgadmin-hackers] Patches

On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar wrote: > Hi, > > I created virtual environment and tried building pgadmin on my Mac with > Python 3.3 and QT 5.5. I observed that in venv, the python3-config is copied > as python-config. Therefore, it's required

[pgadmin-hackers] pgAdmin 4 commit: Fix display of NaN and Bytea data. Fixes #1350. Fixes

Fix display of NaN and Bytea data. Fixes #1350. Fixes #1309 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a800b19c87ce4f9a8567cac1a91988fbf4e2f955 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: To fix error displaying bytea field (pgAdmin4)

Thanks - applied. On Thu, Jun 16, 2016 at 10:01 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where query tool was not able to show/handle > bytea field. > > This patch will two issues, > > RM#1350 (To handle bytea) > RM#1309 (To handle

Re: [pgadmin-hackers] Fixed RM #1356

Hi Dave On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi wrote: > > > On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote: > >> Thanks, patch applied. >> >> However, whilst I was testing, I saw just how slow the tool is: >> >> SELECT * FROM

[pgadmin-hackers] PATCH: To fix error displaying bytea field (pgAdmin4)

Hi, PFA patch to fix the issue where query tool was not able to show/handle bytea field. This patch will two issues, - RM#1350 (To handle bytea) - RM#1309 (To handle NaN) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Thanks! On Thu, Jun 16, 2016 at 11:40 AM, Harshal Dhumal wrote: > Hi Dave, > > Ok, I'll change shortcut keys > > New shortcuts would be: > > Execute --> F5 > Explain -->F7 > Explain analyze --> Shift+F7 > > > > -- > Harshal Dhumal > Software Engineer > >

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is significantly less convenient than F5. On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal wrote: > Hi, > > PAF patch for issue RM1336 > > Changes: Added keyboard shortcuts (static/non

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, As per my offline discussion with Ashesh; He is suggesting not to use Function keys as shortcuts. And regarding configurable key options, I suspect It is going to be time consuming task, please let me know if you want me to start working it. Or can we keep current shortcuts from my last

[pgadmin-hackers] pgAdmin 4 commit: Allow a value of 0 rows per page to mean "no paging".

Allow a value of 0 rows per page to mean "no paging". Allow rows to be added on any page. Fixes #1356 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9393aee4488c5f35eece0d2884ccf90ff13d7bf Author: Akshay Joshi

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote: > Thanks, patch applied. > > However, whilst I was testing, I saw just how slow the tool is: > > SELECT * FROM pg_attribute > > In a PEM database, returns 8150 rows. In pgAdmin 3, this is timed at 676ms > on my laptop. In

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi .com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote: >> >>> Thanks, patch

[pgadmin-hackers] pgAdmin 4 commit: Prevent the runtime from compiling bytecode to avoid

Prevent the runtime from compiling bytecode to avoid permissions issues. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fa917a08282b2a559a69e7b96af3f601d2608a6d Modified Files -- runtime/Server.cpp | 1 + 1 file changed, 1

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, Ok, I'll change shortcut keys New shortcuts would be: Execute --> F5 Explain -->F7 Explain analyze --> Shift+F7 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 16, 2016 at 4:03 PM, Dave

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite the bullet and make it configurable. On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal wrote: > Hi Dave, > > Function keys won't work properly with browser as they already have > predefined

Re: [pgadmin-hackers] Fixed RM #1356

Thanks, patch applied. However, whilst I was testing, I saw just how slow the tool is: SELECT * FROM pg_attribute In a PEM database, returns 8150 rows. In pgAdmin 3, this is timed at 676ms on my laptop. In pgAdmin 4, the busy spinner runs for approx 5 seconds, then the whole UI freezes. I then

[pgadmin-hackers] pgAdmin 4 commit: Hunt for the runtime on Windows in the same way we do

Hunt for the runtime on Windows in the same way we do on Mac. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cef0dc7c880fca9fdd8159b2704cd9887246154a Modified Files -- runtime/Server.cpp | 30 ++ 1 file

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 6:09 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi wrote: > > > On Thu, Jun 16, 2016 at 6:09 PM, Dave Page wrote: > >> >> >> On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun 16, 2016

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 5:07 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jun 16, 2016 at 12:04

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jun 16, 2016 at 5:07 PM, Dave Page wrote: > >> >> >> On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun

[pgadmin-hackers] PATCH: To fix the issue using complex password

Hi, PFA minor patch to fix the issue while connecting server using complex password in pgAdmin4. RM#1371 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1371.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal wrote: > Hi, > > As per my offline discussion with Ashesh; He is suggesting not to use > Function keys as shortcuts. Why? That is primarily what they are on the keyboard for. > And regarding configurable key

[pgadmin-hackers] PATCH: To fix the issue in date validation in role

Hi, PFA minor patch to fix the issue of date validation while creating new role. RM#1370 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1370.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi wrote: > > > On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 5:07 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jun 16,

Re: [pgadmin-hackers] Patches

On Thu, Jun 16, 2016 at 11:40 AM, Sandeep Thakkar wrote: > > >> > I have attached the patch (pgadminpro.patch) to fix this. >> >> Configuration and build fails for me with this: >> > yeah, the 'contains' function is trying to match the whole string. Replacing >

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: > >> >> >> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On

[pgadmin-hackers] pgAdmin 4 commit: Remove recusive call of _wait_timeout() due to which

Remove recusive call of _wait_timeout() due to which python server is crashing Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc295f94a3712d857c353853ffab33ee02db30fb Author: Ashesh Vashi Modified Files

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi > .com> wrote: >> >>> >>> >>> On Thu,

[pgadmin-hackers] pgAdmin 4 commit: Improve the reliability of the Windows build system.

Improve the reliability of the Windows build system. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=931f671756d43ea7d22d460fcb4c7a815a5aad11 Modified Files -- Make.bat | 26 +- 1 file changed, 13

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Thu, Jun 16, 2016 at 3:28 PM, Ashesh Vashi wrote: > On Thu, Jun 16, 2016 at 5:10 PM, Dave Page wrote: >> >> On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal >> wrote: >> > Hi, >> > >> > As per my offline

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Thu, Jun 16, 2016 at 5:10 PM, Dave Page wrote: > On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal > wrote: > > Hi, > > > > As per my offline discussion with Ashesh; He is suggesting not to use > > Function keys as shortcuts. > > Why? That

Re: [pgadmin-hackers] Patches

On Thu, Jun 16, 2016 at 7:04 PM, Dave Page wrote: > On Thu, Jun 16, 2016 at 11:40 AM, Sandeep Thakkar > wrote: > > > > > >> > I have attached the patch (pgadminpro.patch) to fix this. > >> > >> Configuration and build fails for me with this:

[pgadmin-hackers] Patches

Hi, I created virtual environment and tried building pgadmin on my Mac with Python 3.3 and QT 5.5. I observed that in venv, the python3-config is copied as python-config. Therefore, it's required to change pgAdmin4.pro to handle this. With the existing .pro, it does not find the python3-config

Re: [pgadmin-hackers] Patches

On Thu, Jun 16, 2016 at 3:19 PM, Dave Page wrote: > On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar > wrote: > > Hi, > > > > I created virtual environment and tried building pgadmin on my Mac with > > Python 3.3 and QT 5.5. I observed that

[pgadmin-hackers] interesting bug gcc 6 and pgadmin3

with some investigation https://bugzilla.redhat.com/show_bug.cgi?id=1344917 -- All bugs reserved

[pgadmin-hackers] pgAdmin 4 commit: Don't output the startup message in Desktop mode as i

Don't output the startup message in Desktop mode as it hangs the runtime on Windows. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc16a1a61f603e616075846a540cf290ac8fcbbe Modified Files -- web/pgAdmin4.py | 7 --- 1 file

[pgadmin-hackers] pgAdmin 4 commit: Do a more sensible venv search on Windows, and don't

Do a more sensible venv search on Windows, and don't update the registry upon installation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=73988bcecef9cea4a59fd5a18563948da2657769 Modified Files -- Make.bat | 3

[pgadmin-hackers] pgAdmin 4 commit: Fix password encryption with non-alpha passwords. Fix

Fix password encryption with non-alpha passwords. Fixes #1371 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c702ef9c4864afa40056ec85983774a948a8bfab Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Figure out storage paths in a more Windows friendly w

Figure out storage paths in a more Windows friendly way. Fixes #1369 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5f3511ce390df7cc65f3f04f3b0194686d0dffaa Modified Files -- web/config.py | 15 +++ 1 file changed, 11

Re: [pgadmin-hackers] PATCH: To fix the issue using complex password

Thanks, patch applied. On Thu, Jun 16, 2016 at 12:41 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue while connecting server using complex > password in pgAdmin4. > RM#1371 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

Re: [pgadmin-hackers] Qt runtime issue on python 3 + patch

Hi Dave, On Wed, Jun 15, 2016 at 10:48 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Wed, Jun 15, 2016 at 10:46 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Surinder, >> >> On Sat, Jun 11, 2016 at 11:08 PM, Dave Page wrote: >> >>> Hi