[pgadmin-hackers] pgAdmin 4 commit: Allow users to select a data type with the keyboard o

Allow users to select a data type with the keyboard only when creating a column in the subnode grid. Sanitise the list of fields shown. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=573abbe6efb007f9b306cf607e489bc084b3fae2 Author: Murtuza Zab

Re: [pgadmin-hackers] PATCH: To update table dialog column definition

Thanks, applied with minor changes to the labelling of the switches in the grid. On Tue, Jul 12, 2016 at 7:00 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix below issues > > 1) User cannot select a datatype without using the mouse. > > Fixed. > > Remaining issue, > --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: CanDrop option is missing for newly created database

Thanks, applied. On Tue, Jul 12, 2016 at 8:37 AM, Surinder Kumar wrote: > Hi > > I found this issue while working on an RM case. > > Solution: > setting canDrop flag to True fix the issue. > > Please find attached patch with fix and review. > > > Thanks, > Surinder Kumar > > > > -- > Sent via pga

[pgadmin-hackers] pgAdmin 4 commit: Ensure newly created database can be dropped.

Ensure newly created database can be dropped. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efb254c966ce495f7fffeca2122ea9cc4667d2e3 Author: Surinder Kumar Modified Files -- web/pgadmin/browser/server_groups/servers/databases/__i

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is sho

[pgadmin-hackers] pgAdmin 4 commit: File management dialogue enhancements:

File management dialogue enhancements: - Double click on file/folder icon or name will navigate to the folder/file. - Selected file/folder can be renamed by Rename button only. Double click rename is removed. - Filename text box will not hide on smaller screen. Setting minimum width of File Brow

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

Thanks Surinder, patch applied. I suspect the font rendering issue is related to others we've seen, where the solution is to ensure the -webkit-transform CSS attribute is set to none. Can you have a poke around with it please? On Wed, Jul 13, 2016 at 2:58 PM, Surinder Kumar wrote: > Please find

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

On Fri, Jul 15, 2016 at 3:22 PM, Dave Page wrote: > Thanks Surinder, patch applied. > > I suspect the font rendering issue is related to others we've seen, > where the solution is to ensure the -webkit-transform CSS attribute is > set to none. Can you have a poke around with it please? > Sure Dav

[pgadmin-hackers] pgAdmin 4 commit: Fix query tool display of various types:

Fix query tool display of various types: date reltime abstime time with timezone time without timezone Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=517a797947268dfae9e43935ea796bedd4366825 Author: Murtuza Zabuawala Modified Files -

Re: [pgadmin-hackers] PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)

Hi On Thu, Jul 14, 2016 at 7:00 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in timestamp datatype(s) displaying with time as > 00:00 > (RM#1437) > > The issue was with backgrid datetime cell which do not fully support > ISO-8601 datetime format. Thanks - this worked, except

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

On Thu, Jul 14, 2016 at 10:06 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where if user use cast function and it causes > freeze in query tool. > (RM#1438) This fixes the hang, but then displays the wrong data type for the first column - e.g. SELECT CURRENT_TIMESTAMP, CAST

Re: [pgadmin-hackers] PATCH: security label is not being added/updated for MATERIALIZED VIEW

Thanks - patch applied. On Thu, Jul 14, 2016 at 12:59 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in MATERIALIZED VIEW node where user was not able > to add/update security label. > (RM#1458) > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com >

[pgadmin-hackers] pgAdmin 4 commit: Fix the issue in MATERIALIZED VIEW node where user wa

Fix the issue in MATERIALIZED VIEW node where user was not able to add/update security label. Fixes #1458 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e94b14e7d75fe928ac2dd9ced37ec7f8a454bb84 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

Hi Dave, Yes, I am aware of that, but the issue you mentioned is due to psycopg2 DictCursor issue which I have already mentioned earlier (RM#1409) https://github.com/psycopg/psycopg2/issues/454. The patch is for different issue (RM#1438). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.en

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

++ FYI, If you provide alias, it'll give you proper result :) SELECT CURRENT_TIMESTAMP as ts, CAST ( CURRENT_TIMESTAMP AS text ) as ts_as_text; -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 15, 2016 at 5:14 PM, Murtuza Zab

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

OK, so the type names are affected by the duplicate column names, and need to be avoided by using indexes and avoiding dicts. That's issue #1409. The second issue is that "SELECT CURRENT_TIMESTAMP" gives us "now timestamp with time zone (8)". Is the (8) also part of issue #1409, or some other bug?

[pgadmin-hackers] pgAdmin 4 commit: FIx a hang in the query tool that could occur if a co

FIx a hang in the query tool that could occur if a column type couldn't be determined. Fixes #1438 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d15dfac60f6b3f8c5407dc29659e6c39d583cfd6 Author: Murtuza Zabuawala Modified Files -

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

On Fri, Jul 15, 2016 at 5:27 PM, Dave Page wrote: > OK, so the type names are affected by the duplicate column names, and > need to be avoided by using indexes and avoiding dicts. That's issue > #1409. > > The second issue is that "SELECT CURRENT_TIMESTAMP" gives us "now > timestamp with time zon

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

On Fri, Jul 15, 2016 at 1:25 PM, Murtuza Zabuawala wrote: > > > On Fri, Jul 15, 2016 at 5:27 PM, Dave Page wrote: >> >> OK, so the type names are affected by the duplicate column names, and >> need to be avoided by using indexes and avoiding dicts. That's issue >> #1409. >> >> The second issue is

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

Hi On Thu, Jul 14, 2016 at 12:50 PM, Priyanka Shendge wrote: > Hi Dave, > > I have added more debug statements to older patch. New patch attached. > Also, i removed database deletion test case from current patch so that we > can analyse > if database is added or not. OK. One quick note - somewhe

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi On Mon, Jul 11, 2016 at 2:16 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > PFA updated patch for modular API test cases. > > On Mon, Jul 11, 2016 at 5:11 PM, Dave Page > wrote: > >> >> >> On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh < >> navnath.gad...@enterprise

[pgadmin-hackers] pgAdmin 4 commit: Using own version of cursor class to allow us to take

Using own version of cursor class to allow us to take care of the duplicate name in column description. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ba6bafb2b701a1317daa789fdbd19c1b5298d81 Modified Files -- web/pgadmin/tools/sql