Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Thanks, applied. On Mon, Jul 18, 2016 at 1:01 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA rebased patch RM1405 (version 4) > > Neel will be sending patch for QT issue for same functionality. > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India:

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, Please find the revised patch for unit tests of pgAdmin4 APIs. This patch includes- 1. test_advance_config.json(for user it’s test_advance_config.json.in) for advance test configuration for database/server(Priyanka was working on this) 2. test_config.json(for user

[pgadmin-hackers] pgAdmin 4 commit: Ignore regression test files.

Ignore regression test files. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae9bbc030514e4768cee20fd79fde438a9a68c33 Modified Files -- web/regression/.gitignore | 3 +++ 1 file changed, 3 insertions(+) -- Sent via

[pgadmin-hackers] Where is option to disable pgadmin4 version check?

Tried to find the option to disable version check, but not clear on where to find it. I checked preferences, nothing there. Perhaps it is contained in some non-obvious option or I am dull today. Not sure why version strings should be arbitrary. Doesn't it make them less useful? -- Sent

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, Please find attached patch file to support server side download in runtime application. NOTE: Before applying this patch, use above harshal's patch. Thanks, Neel Patel On Mon, Jul 18, 2016 at 5:31 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA rebased patch

[pgadmin-hackers] pgAdmin 4 commit: Enhancements to the regression test suite.

Enhancements to the regression test suite. Navnath Gadakh and Priyanka Shendge Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f17c2e3b84015666267676b582c29f2bd59f77cf Modified Files -- .../servers/databases/tests/__init__.py

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Thanks, applied with minor changes to use the home dir as the default save location, and to store the save location as a persistent setting. On Mon, Jul 18, 2016 at 1:27 PM, Neel Patel wrote: > Hi, > > Please find attached patch file to support server side download

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Thanks - applied with some tweaks and changes, most notably: - "--pkg all" is the default if no command line options are given. - Output now goes in regression/regression.log - Terminal output is limited to WARNINGS from the app server. - The runner script is now python regression/runtests.py

[pgadmin-hackers] pgAdmin 4 commit: Support server side download in runtime application.

Support server side download in runtime application. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6024fc49ab1091366c52141bc786aafec7dede3 Author: Neel Patel Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix saving of query output as CSV data. Fixes #1405

Fix saving of query output as CSV data. Fixes #1405 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83a1535f89af1e37f8c46199368af4f42f7a3620 Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] Where is option to disable pgadmin4 version check?

On Mon, Jul 18, 2016 at 3:09 PM, Colin Beckingham wrote: > Tried to find the option to disable version check, but not clear on where to > find it. I checked preferences, nothing there. Perhaps it is contained in > some non-obvious option or I am dull today. Application

[pgadmin-hackers] pgAdmin 4 commit: Beta 3 version bump

Beta 3 version bump Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e29d16eecc7d9e432d31d7fcbe1d1404fb9ccc5 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Navnath, I have just ran the automated test cases, I noticed that the login test-case gets called (which actually post data and gets logged-in) each time before every test case runs. I think this should not happen, user login should be done only once. Thanks, Khushboo On Mon, Jul 18, 2016

[pgadmin-hackers] pgAdmin 4 commit: Generate the proper unique name for the duplicate col

Generate the proper unique name for the duplicate column name. Thanks Murtuza for reporting the issue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b35a60c088639739e14e95f7922e53b11c0065e Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time

Hi On Mon, Jul 18, 2016 at 8:34 AM, Surinder Kumar wrote: > Hi > > Please find attached patch for the fix: > Issue: > This issue is regression of one of the flickering issue of RM#1242. > "Aside from displaying/hiding the spinner, panes should have their content

Re: [pgadmin-hackers] Regarding issue 1241

Hi, PFA patch for issue RM1241 Changes: 1. Altered variable control to make its UI consistence with privileges and Security labels. 2. Changed datamodel.js to handle duplicate rows at datamodel level and not UI/Control level. (See variable control for example) -- *Harshal Dhumal* *Software

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi Dave, Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code. I will send the patch for runtime to support server side download CSV file. Thanks, Neel Patel On Fri, Jul 15, 2016 at 3:05 PM, Dave Page wrote:

Re: [pgadmin-hackers] PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)

Thanks - applied. On Mon, Jul 18, 2016 at 7:34 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Please find patch to fix the issue for interval type casting. > > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time

Hi Please find attached patch for the fix: *Issue:* This issue is regression of one of the flickering issue of RM#1242. "Aside from displaying/hiding the spinner, panes should have their content refreshed until and unless the new data differs from the previous, to reduce flicker" *Solution:*

[pgadmin-hackers] pgAdmin 4 commit: Properly support the interval type. Fixes #1437

Properly support the interval type. Fixes #1437 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5560d5b3349671ed646d39a6fc82e3b1fe2a04c4 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)

Hi Dave, Please find patch to fix the issue for interval type casting. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 15, 2016 at 4:31 PM, Dave Page wrote: > Hi > > On Thu, Jul 14,

[pgadmin-hackers] pgAdmin 4 commit: Make the Parameter grid use a workflow consistent wit

Make the Parameter grid use a workflow consistent with other grids. Fixes #1241 1. Altered variable control to make its UI consistent with privileges and Security labels. 2. Changed datamodel.js to handle duplicate rows at datamodel level and not UI/Control level. (See variable control for

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes. I am just testing with different OS. I will send it next 1-2 hour. Is it fine ? Thanks, Neel Patel On Mon, Jul 18, 2016 at 3:53 PM, Dave Page wrote: > Any chance of getting that in the next couple of hours so I can get it > into beta 3? > > On Mon, Jul 18, 2016 at

[pgadmin-hackers] Logical comparison on startup pgadmin4

Each time I run pgadmin4 I run a git pull to get latest. Then launch from web browser at 5050, no problem. However a message pops up to say that I am running this version but the current is something else. For example: "You are currently running version 1.0-beta2.1 of pgAdmin 4, however the

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Perfect, thanks! On Mon, Jul 18, 2016 at 11:24 AM, Neel Patel wrote: > Yes. I am just testing with different OS. I will send it next 1-2 hour. > > Is it fine ? > > Thanks, > Neel Patel > > On Mon, Jul 18, 2016 at 3:53 PM, Dave Page wrote: > >>

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Thanks! On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel wrote: > Hi Dave, > > Yes, it will break in runtime. If we need to support downloading at server > side then we need to change the runtime code. > I will send the patch for runtime to support server side download

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Any chance of getting that in the next couple of hours so I can get it into beta 3? On Mon, Jul 18, 2016 at 11:18 AM, Dave Page wrote: > Thanks! > > On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel > wrote: > >> Hi Dave, >> >> Yes, it will break in

Re: [pgadmin-hackers] Logical comparison on startup pgadmin4

On Mon, Jul 18, 2016 at 11:29 AM, Colin Beckingham wrote: > Each time I run pgadmin4 I run a git pull to get latest. Then launch from > web browser at 5050, no problem. > > However a message pops up to say that I am running this version but the > current is something else.

Re: [pgadmin-hackers] Regarding issue 1241

Thanks - committed with minor tweaks! On Mon, Jul 18, 2016 at 10:32 AM, Harshal Dhumal wrote: > Hi, > > PFA patch for issue RM1241 > > Changes: 1. Altered variable control to make its UI consistence with > privileges and Security labels. > 2. Changed datamodel.js

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA rebased patch RM1405 (version 4) Neel will be sending patch for QT issue for same functionality. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 18, 2016 at 4:02 PM, Dave Page