[pgadmin-hackers] pgAdmin 4 commit: Misc changes

2016-09-26 Thread Dave Page
Misc changes - Setting the CodeMirror height when panel is resized, which you had mentioned. - Added a new CellEditor (DatetimePickerEditor) for datetime picker. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b80cd43ae6a24eef89cb3ece5bbfb12a0b6

Re: [pgadmin-hackers] PATCH: pgAgent support

2016-09-26 Thread Dave Page
Hi I've applied the misc changes patch, but it looks like you forgot the --binary option for the pgAgent patch. Can you recreate it please? Thanks. On Fri, Sep 23, 2016 at 9:34 PM, Ashesh Vashi wrote: > Hi Dave, > > > On Thu, Sep 22, 2016 at 8:27 PM, Dave Page wrote: > >> Thanks. From the pgA

[pgadmin-hackers] pgAdmin 4 commit: Ensure the default schema is set when creating object

2016-09-26 Thread Dave Page
Ensure the default schema is set when creating objects. Fixes #1735 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6999249dcdc6274131e810155786c7a307d2589d Author: Ashesh Vashi Modified Files -- .../servers/databases/schemas/__ini

Re: [pgadmin-hackers] PATCH: RM#1735

2016-09-26 Thread Dave Page
Thanks, applied. On Fri, Sep 23, 2016 at 10:53 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Dave/Team, > > I've fixed the issue "No default schema when creating some schema objects". > > For package, allowing to change the schema at the create time only, as the > logic required t

Re: [pgadmin-hackers] PATCH: RM#1735

2016-09-26 Thread Dave Page
Thanks, applied. On Sat, Sep 24, 2016 at 12:04 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Team, > > > On Sat, Sep 24, 2016 at 3:23 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave/Team, >> >> I've fixed the issue "No default schema when creating some sche

[pgadmin-hackers] pgadmin4 rc1

2016-09-26 Thread steve hermes
Everything looks good and seems good But any queries never return on localhost DB PG 9.5. No errors in the browser. $ uname -a Linux lubuntu-vm 4.4.0-38-generic #57-Ubuntu SMP Tue Sep 6 15:42:33 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Anyone else seeing this ? Thanks Steve -- The pessimist

[pgadmin-hackers] pgAdmin 4 commit: Fix layout of the filter box.

2016-09-26 Thread Dave Page
Fix layout of the filter box. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d222067b99312f95b80f79970169646969e1ab7 Modified Files -- web/pgadmin/tools/sqleditor/static/css/sqleditor.css | 1 - 1 file changed, 1 deletion(-) --

[pgadmin-hackers] pgAdmin 4 commit: Ensure the view data filter box is usable. Fixes #173

2016-09-26 Thread Dave Page
Ensure the view data filter box is usable. Fixes #1733 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bf48d06fb137ae2de3d4201948f428c9f5abc69 Author: Ashesh Vashi Modified Files -- .../tools/sqleditor/templates/sqleditor/js/sqled

Re: [pgadmin-hackers] PATCH: RM#1733

2016-09-26 Thread Dave Page
Thanks, applied. On Fri, Sep 23, 2016 at 11:41 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Dave/Team, > > Please find the patch for the issue - 'Filter option taking too much time > to load'. > Actually - it wasn't taking any time, but - we did not hide the loading > div properl

[pgadmin-hackers] pgAdmin 4 commit: Fix validation message

2016-09-26 Thread Dave Page
Fix validation message Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f51d8c72efa277eaded9b5571d0f65235b43ba78 Modified Files -- .../servers/databases/schemas/views/templates/mview/js/mview.js | 2 +- .../servers/databases/s

[pgadmin-hackers] pgAdmin 4 commit: Fix view creation. Fixes #1736

2016-09-26 Thread Dave Page
Fix view creation. Fixes #1736 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=912eebb583fe4386774e50fc6514407947d4baef Author: Ashesh Vashi Modified Files -- .../servers/databases/schemas/views/__init__.py| 41

Re: [pgadmin-hackers] PATCH: RM#1736

2016-09-26 Thread Dave Page
Thanks, applied. On Fri, Sep 23, 2016 at 11:19 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Dave/Team, > > Please find the patch for the "Cannot create a view". > When we do not select the schema name, this error comes at backend-side. > > The client-side issue has been taken car

[pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where it was not disabling buttons after execution gets finished. RM#1227 *Issue:* If user clicks on buttons after execution is complete then it was throwing error, expected behaviour was all button should gets disabled except execute button. -- Regards, Murtuza Za

[pgadmin-hackers] pgAdmin 4 commit: Fix SQL box sizing.

2016-09-26 Thread Dave Page
Fix SQL box sizing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f3ca548cd6dfee75fd558b509bdded45444e576 Modified Files -- web/pgadmin/static/css/overrides.css | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) --

[pgadmin-hackers] pgAdmin 4 commit: pgAgent - add modules for jobs, steps and schedules.

2016-09-26 Thread Dave Page
pgAgent - add modules for jobs, steps and schedules. Fixes #1341 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=237bfd48821ecd2a71e54b6044a8b340c854991a Author: Ashesh Vashi Modified Files -- .../server_groups/servers/pgagent/__in

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Dave Page
Hi On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where it was not disabling buttons after > execution gets finished. > RM#1227 > > Issue: > If user clicks on buttons after execution is complete then it was throwing > error, expected behaviour was

[pgadmin-hackers] PATCH: To support new version of sqlparse (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi, PFA patch to address the issue where if user upgrades sqlparse module to >0.1.19, it breaks sqleditor auto-complete feature. RM#1725 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1725.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
On Mon, Sep 26, 2016 at 5:08 PM, Dave Page wrote: > Hi > > On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue where it was not disabling buttons after > > execution gets finished. > > RM#1227 > > > > Issue: > > If user clicks on buttons after

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch to fix `` tag display. Please clear cache & try again with this updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 26, 2016 at 5:44 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.

[pgadmin-hackers] pgAdmin 4 commit: pgAgent misc fixes:

2016-09-26 Thread Dave Page
pgAgent misc fixes: 1. When an existing schedule updated, or a new schedule is added from a pgAgent job dialog, it was not able to generate the proper update SQL Query. 2. The SubNodeCollectionControl was not removing the grid, when it is being getting removed. Branch -- master Details ---

[pgadmin-hackers] pgAdmin IV: Code changes in roles and tablespaces test cases

2016-09-26 Thread Navnath Gadakh
Hi Dave, Please find the attached patch for the role and table spaces(Changes required due to drop objects functionality). Also, I have added the code in test result summary to show skipped test cases for tablespace if path not mentioned. To run testsuite: python regression/runtests.py --pkg br

Re: [pgadmin-hackers] PATCH: To support new version of sqlparse (pgAdmin4)

2016-09-26 Thread Dave Page
Thanks - applied! On Mon, Sep 26, 2016 at 12:44 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to address the issue where if user upgrades sqlparse module to >>0.1.19, it breaks sqleditor auto-complete feature. > RM#1725 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterpris

[pgadmin-hackers] pgAdmin 4 commit: Ensure compatibility with newer sqlparse modules. Fix

2016-09-26 Thread Dave Page
Ensure compatibility with newer sqlparse modules. Fixes #1725 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0a6428e866a9a796167c9122872e1c75b19638f Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/sqlautocomplete/au

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Dave Page
On Mon, Sep 26, 2016 at 1:28 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch to fix `` tag display. > Please clear cache & try again with this updated patch. OK, that fixes the display issue. Regarding the error message, on this execution I noticed the following exception: 2016-09-

[pgadmin-hackers] REL9_6_STABLE configure does not fail when bison or flex not on the system

2016-09-26 Thread Dave Cramer
building on a clean ubuntu system configure runs fine. make fails with bison not found and or flex not found I understand this might be intentional, but the warning is useless as it flys by with the other couple hundred lines output Dave Cramer

[pgadmin-hackers] pgAdmin 4 commit: Update role and tablespace tests to cleanup properly

2016-09-26 Thread Dave Page
Update role and tablespace tests to cleanup properly following a failure. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4aae4c24587d2b477dcaafe5e6c2f463da3b8c2 Author: Navnath Gadakh Modified Files -- .../servers/roles/tests/tes

Re: [pgadmin-hackers] pgAdmin IV: Code changes in roles and tablespaces test cases

2016-09-26 Thread Dave Page
Thanks, applied. On Mon, Sep 26, 2016 at 1:44 PM, Navnath Gadakh wrote: > Hi Dave, > Please find the attached patch for the role and table spaces(Changes > required due to drop objects functionality). > Also, I have added the code in test result summary to show skipped test > cases for tablespa

[pgadmin-hackers] pgAdmin 4 commit: Improve layout of regression test format

2016-09-26 Thread Dave Page
Improve layout of regression test format Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d077626cdcf33b98c63e7cb6ac045907481e9425 Modified Files -- web/regression/runtests.py | 22 -- 1 file changed, 12 insertions

[pgadmin-hackers] [pgAdmin4][Patch]: Error while expanding server group node.

2016-09-26 Thread Surinder Kumar
Hi *Issue:* Getting following error while expanding server group node. File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py", line 86, in get_nodes in_recovery = result['rows'][0]['inrecovery']; TypeError: string indices must be integers Not

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

2016-09-26 Thread Surinder Kumar
Please find attached patch. Added activity indicator for: 1) Panels. 2) Dialog open and on click OK.(set cursor to progress) 3) Debugger. (Set cursor to progress). Not done: Activity indicator is not implemented for wizard pages. send another patch once completed. On Fri, Sep 23, 2016 at 2:19 PM,

[pgadmin-hackers] pgAdmin 4 commit: Do not try to set in_recovery, is_replay_paused prope

2016-09-26 Thread Ashesh Vashi
Do not try to set in_recovery, is_replay_paused properties in the server object, when data is not available. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ae719dae00324c49ea777d8194ca2860f4af471 Author: Surinder Kumar Modified Files ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Error while expanding server group node.

2016-09-26 Thread Ashesh Vashi
On Mon, Sep 26, 2016 at 6:54 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issue:* > Getting following error while expanding server group node. > File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/ > browser/server_groups/servers/__init__.py", line 86, in get_no

[pgadmin-hackers] pgAdmin 4 commit: Fix label cpaitalisation

2016-09-26 Thread Dave Page
Fix label cpaitalisation Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9dacc52374a29024ea5436cddedc6b80a322e2f Modified Files -- .../servers/databases/schemas/templates/schema/js/schema.js | 8 .../servers/databases

[pgadmin-hackers] pgAdmin 4 commit: Improve network/server activity feedback for the user

2016-09-26 Thread Dave Page
Improve network/server activity feedback for the user. Fixes #1751 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b4776ab5f15eff67a3d3a975fd9c2b32903d342 Author: Surinder Kumar Modified Files -- .../browser/templates/browser/js/m

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

2016-09-26 Thread Dave Page
Thanks, applied with some changes to wording, and reduction of the delay from 2 secs to 1. On Mon, Sep 26, 2016 at 2:41 PM, Surinder Kumar wrote: > Please find attached patch. Added activity indicator for: > 1) Panels. > 2) Dialog open and on click OK.(set cursor to progress) > 3) Debugger. (Set

[pgadmin-hackers] pgAdmin 4 commit: Prevent bigints getting rounded. Fixes #1547

2016-09-26 Thread Dave Page
Prevent bigints getting rounded. Fixes #1547 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09c2d605c9dfedf3f0ed06192d43d7842fb3bb3f Author: Ashesh Vashi Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 25 +++

[pgadmin-hackers] pgAdmin 4 commit: Update message catalogs

2016-09-26 Thread Dave Page
Update message catalogs Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ba2f46092afabd5ff1ddb6d0132e62774ff49bf Modified Files -- web/pgadmin/messages.pot | 3846 ++ .../translations/fr/LC_MESSAGES/

[pgadmin-hackers] pgAdmin 4 commit: Fix button label and colour

2016-09-26 Thread Dave Page
Fix button label and colour Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6790f14c6c4c6f461c4daaf236d3f02f21a37801 Modified Files -- web/pgadmin/static/js/slickgrid/slick.pgadmin.editors.js | 4 ++-- 1 file changed, 2 insertions(+)

[pgadmin-hackers] pgAdmin 4 commit: Bump version for release

2016-09-26 Thread Dave Page
Bump version for release Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e06fd21f3cbe7fafb308c77ef040b71ac1c47325 Modified Files -- web/config.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- Sent via pgadmin-h

[pgadmin-hackers] pgAdmin 4 commit: Ensure that the directory paths are as they should be

2016-09-26 Thread Dave Page
Ensure that the directory paths are as they should be under the runtime. Note that this change requires (for now) the regression tests to be run from the web/regression directory. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7175929cab984e0

[pgadmin-hackers] pgAdmin 4 commit: Don't munge the windows installer filename if there's

2016-09-26 Thread Dave Page
Don't munge the windows installer filename if there's no app suffix. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30397476da45e419a409710e7447bf0f10fcbcd9 Modified Files -- Make.bat | 2 ++ 1 file changed, 2 insertions(+) -- Se

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch to fix mentioned issue as well as incremental msgs updates in Messages Tab. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 26, 2016 at 6:24 PM, Dave Page wrote: > On Mon, Sep 26, 2016 at 1:28 PM