[pgadmin-hackers] pgAdmin 4 commit: Move security keys into the SQLite database, and auto

2016-10-19 Thread Dave Page
Move security keys into the SQLite database, and auto-generate them. This avoids packagers having to deal with the issue, which can be difficult if they need to cater for both server and desktop modes. Fixes #1849 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Dave Page
Patch applied. Fahar, can you please test this thoroughly in desktop and server modes, with both fresh and upgraded installations? https://redmine.postgresql.org/issues/1849 Packagers: This change means that packages are no longer forced to create a config_local.py file, and there is no longer a

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
Sure, Will test this thoroughly after complete investigation. Kind Regards, On Wed, Oct 19, 2016 at 1:27 PM, Dave Page wrote: > Patch applied. > > Fahar, can you please test this thoroughly in desktop and server modes, > with both fresh and upgraded installations? > > https://redmine.postgresq

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
Dave, Testing Environment Ubuntu 16.04 Linux 64: pg-AdminIV Development Environment Setup for Ubuntu : 1) Install GIT sudo apt-get install git 2) Install pip3 sudo apt-get install python3-pip 3) Install virtualenv sudo pip3 install virtualenv 4) install

Re: [pgadmin-hackers] Setting up pgAdmin4 as a web application

2016-10-19 Thread Dave Page
Hi On Tue, Oct 18, 2016 at 6:42 PM, Derek Ealy wrote: > I've been trying to get pgAdmin4 to work as a web app for a couple of days. > I've finally figured out python, pip, wsgi, apache (I think). I can see from > the logs that is failing when trying to select from the version table which > I assu

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
Here is the output of if we copy config_local.py and execute python setup.py pgAdmin 4 - Application Initialisation == The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does not exist. Entering initial setup mode... NOTE: Configuring authenticatio

[pgadmin-hackers] pgAdmin 4 commit: Resolved - Integer type of preferences are not update

2016-10-19 Thread Ashesh Vashi
Resolved - Integer type of preferences are not updated Reason: IntegerControl assumes the model, passed to it, would always has errorModel variable set properly. In order to resolve it, now using pgBrowser.DataModel instead of Backbone.Model, which initialize the errorModel by default. Fixes #

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
On Wed, Oct 19, 2016 at 3:55 PM, Ashesh Vashi wrote: > Hi Fahar, > > Please log the case on redmine. > https://redmine.postgresql.org/issues/1871 > Please find the attached patch, please apply it locally, and test it. > > And, please update the case, and this mail chain accordingly. > > Sure Wil

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Sandeep Thakkar
Hi Dave, On Wed, Oct 19, 2016 at 1:57 PM, Dave Page wrote: > Patch applied. > > Fahar, can you please test this thoroughly in desktop and server modes, > with both fresh and upgraded installations? > > https://redmine.postgresql.org/issues/1849 > > Packagers: This change means that packages are

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Ashesh Vashi
Hi Fahar, Please log the case on redmine. Please find the attached patch, please apply it locally, and test it. And, please update the case, and this mail chain accordingly. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *htt

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
On Wed, Oct 19, 2016 at 4:03 PM, Fahar Abbas wrote: > > > On Wed, Oct 19, 2016 at 3:55 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Fahar, >> >> Please log the case on redmine. >> > https://redmine.postgresql.org/issues/1871 > >> Please find the attached patch, please apply

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Dave Page
Great, thanks! On Wed, Oct 19, 2016 at 12:42 PM, Fahar Abbas wrote: > > > On Wed, Oct 19, 2016 at 4:03 PM, Fahar Abbas > wrote: > >> >> >> On Wed, Oct 19, 2016 at 3:55 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Fahar, >>> >>> Please log the case on redmine. >>> >> htt

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Neel Patel
Hi, Just to update for Python 3. It gives below error while running "pgAdmin4.py". # Traceback (most recent call last): File "/usr/lib/python3.4/threading.py", line 920, in _bootstrap_inner self.run() File "/usr/lib/python3.4/threading.py", line 868, in run self._target(*self._ar

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
Yes Neel is Right. This issue is also reproducible with Python 3.5 when user Launch python with pgAdmin4.py python pgAdmin4.py Starting pgAdmin 4. Please navigate to http://localhost:5050 in your browser. Exception in thread Thread-1: Traceback (most recent call last): File "/usr/lib/python3.5/

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Sandeep Thakkar
Here is the patch where we remove the config_local.py being created during packaging. The mac build script missed creating config_distro.py earlier and it has been take care of now. Please review the attached patch. I'll also make the changes in the EDB packaging scripts where we bundle pgAdmin in

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
After applying this patch on Python 2.7.11 on Windows 2012 64bit, User can launch pgAdmin4 with python pgAdmin4.py without any error. Will also retest once the 1871 will be resolved On Wed, Oct 19, 2016 at 5:19 PM, Fahar Abbas wrote: > Yes Neel is Right. > > This issue is also reproducible with

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Dave Page
I assume that's an existing issue with Python 3.5? That file wasn't changed by this patch. On Wed, Oct 19, 2016 at 1:11 PM, Neel Patel wrote: > Hi, > > Just to update for Python 3. > It gives below error while running "pgAdmin4.py". > > # > > Traceback (most recent call last): > File "/usr

[pgadmin-hackers] pgAdmin 4 commit: Ensure SECURITY_PASSWORD_SALT is set to something whe

2016-10-19 Thread Dave Page
Ensure SECURITY_PASSWORD_SALT is set to something when initialising (to avoid errors, prior to being set to the 'real' value). Fixes #1871 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19df1e3f4b27523f8f401a78ca8747dbfbb5fcfe Author: Ashesh V

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Dave Page
Patch applied. On Wed, Oct 19, 2016 at 11:55 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Fahar, > > Please log the case on redmine. > Please find the attached patch, please apply it locally, and test it. > > And, please update the case, and this mail chain accordingly. > > -- >

[pgadmin-hackers] pgAdmin 4 commit: Use config_distro.py for all settings, and don't crea

2016-10-19 Thread Dave Page
Use config_distro.py for all settings, and don't create/overwrite config_local.py. Partly fixes #1849 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1c0042a1e95d5329bceb3650219e804f080de10 Author: Sandeep Thakkar Modified Files

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Dave Page
Thanks, applied. On Wed, Oct 19, 2016 at 1:39 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Here is the patch where we remove the config_local.py being created during > packaging. The mac build script missed creating config_distro.py earlier > and it has been take care of now.

Re: [pgadmin-hackers] Setting up pgAdmin4 as a web application

2016-10-19 Thread Dave Page
[Please keep the mailing list CC'd] On Wed, Oct 19, 2016 at 3:32 PM, Derek Ealy wrote: > I had already tried something similar and it didn't work. > > I moved my stuff out of /var/www/.pgadmin to the directory locations you > suggested and set ownership to the www-data user and group. After resta

Re: [pgadmin-hackers] Setting up pgAdmin4 as a web application

2016-10-19 Thread dealy663
Ok, I'll give that a try. I have my python setup to use a virtual environment. Could that be causing the problems I'm having? I was able to get the venv setup with pgAdmin4 working on my workstation and thought that was the right way to set things up on the server. -- View this message in conte

Re: [pgadmin-hackers] Setting up pgAdmin4 as a web application

2016-10-19 Thread Dave Page
On Wed, Oct 19, 2016 at 3:43 PM, dealy663 wrote: > Ok, I'll give that a try. > > I have my python setup to use a virtual environment. Could that be causing > the problems I'm having? I was able to get the venv setup with pgAdmin4 > working on my workstation and thought that was the right way to se

Re: [pgadmin-hackers] Setting up pgAdmin4 as a web application

2016-10-19 Thread Murtuza Zabuawala
You can refer my config for activating virtual environment. http://i.stack.imgur.com/8HbKw.png -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 19, 2016 at 8:19 PM, Dave Page wrote: > On Wed, Oct 19, 2016 at 3:43 PM, dealy663

Re: [pgadmin-hackers] Setting up pgAdmin4 as a web application

2016-10-19 Thread Dave Page
On Wed, Oct 19, 2016 at 4:01 PM, Murtuza Zabuawala wrote: > You can refer my config for activating virtual environment. > http://i.stack.imgur.com/8HbKw.png That's your replacement wsgi file? I wonder if we should source a user-editable file from our standard WSGI file to allow the user to easil

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
Hi Dave, I have reopened following RM: https://redmine.postgresql.org/issues/1849 On Wed, Oct 19, 2016 at 6:04 PM, Dave Page wrote: > Patch applied. > > On Wed, Oct 19, 2016 at 11:55 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Fahar, >> >>

[pgadmin-hackers] [pgAdmin4][Patch]: RM1599 - Unable to fetch the records for grant wizard if schema contains special characters

2016-10-19 Thread Surinder Kumar
Hi, Issue: The schema name was passed into the template files to get schema name in response which doesn't escape special characters. Now schema is fetched using a JOIN statement on needed tables. Please find attached patch and review. Thanks, Surinder Kumar RM1599.patch Description: Binary d

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue for Pyhton3. RM#1849 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Oct 20, 2016 at 11:03 AM, Fahar Abbas wrote: > Hi Dave, > > I have reopened following RM: > > h

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
Murtaza, I have applied this patch and there is no success on new pgAdmin4 setup as well as existing pgAdmin4 setup. On Thu, Oct 20, 2016 at 10:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue for Pyhton3. > RM#1849 > > -- > Regards, > Mu

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Murtuza Zabuawala
Could you delete 'keys' table from pgadmin4.db file & try again? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Oct 20, 2016 at 11:26 AM, Fahar Abbas wrote: > Murtaza, > > I have applied this patch and there is no success on new

[pgadmin-hackers] patch for RM1861 [pgAdmin4]

2016-10-19 Thread Harshal Dhumal
Hi, PFA minor patch for RM1861. Issue fixed: SQL not generated for exclusion constraint on table -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/ta

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Fahar Abbas
I tried different variations and when launch pgAdmin4 with web browser still exception displayed when user deleted .pgadmin folder Here is the output: python pgAdmin4.py Starting pgAdmin 4. Please navigate to http://localhost:5050 in your browser. Exception in thread Threa

[pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2016-10-19 Thread Surinder Kumar
Hi, The options like "sort" and "nulls" must be conditional. i.e. include only when access method type is other than "gist" or "gin". Please find attached patch and review. Thanks, Surinder Kumar RM1840.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Dave Page
I think you'll also need to set the version back to 13 in the version table. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 20 Oct 2016, at 07:00, Murtuza Zabuawala > wrote: > > Could you del

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

2016-10-19 Thread Surinder Kumar
Hi, While fixing RM1840, I found when we add new index, it doesn't add under right parent. i.e. columns collection. because wrong parent is given in response. I also verified other nodes. This issue is only with index node. Do, I need to create separate RM for this case. ? Please find attached m