Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

2016-11-25 Thread Dave Page
Hi This doesn't apply - can you rebase it please? Thanks. On Thu, Nov 24, 2016 at 8:57 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. > > On Fri, Nov 18, 2016 at 7:45 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Nov 18, 2016 at 1:03 PM, Khushboo Vashi >> wrote: >>

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file

2016-11-25 Thread Dave Page
Hi On Thu, Nov 24, 2016 at 10:11 AM, Surinder Kumar wrote: > Please ignore above patch. because it breaks when we save a file with name > containing ascii chars in py35 > It is fixed. Please find attached patch and review. > > On Thu, Nov 24, 2016 at 2:56 PM, Surinder Kumar > wrote: >> >> Hi >>

Re: [pgadmin-hackers] PATCH: To fix the issue of column order in Primary Key/Index constraints (pgAdmin4)

2016-11-25 Thread Dave Page
On Thu, Nov 24, 2016 at 9:57 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where column order in Primary Key/Index > constraints was maintained while creating sql from template. > RM#1842 As far as I can see, this doesn't work. Given the following indexes from a PEM database:

[pgadmin-hackers] pgAdmin 4 commit: Handle the template property on databases appropriate

2016-11-25 Thread Dave Page
Handle the template property on databases appropriately. Fixes #1800 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66b9e22d01489cccd213b71f641f9034ac7f28c9 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/templat

Re: [pgadmin-hackers] PATCH: To fix issue in database node (pgAdmin4)

2016-11-25 Thread Dave Page
Thanks, patch applied. On Thu, Nov 24, 2016 at 9:59 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to display a flag if current database can be used as template > while creating new database. > RM#1800 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Ent

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2016-11-25 Thread Dave Page
Hi On Thu, Nov 24, 2016 at 10:25 AM, Harshal Dhumal wrote: > Hi Dave, > > Please find updated attached patch for RM1911 (V2) > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Nov 21, 2016 at 7:48 PM, Dav

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixes #1940 - Handle non-ascii characters in file/folder names

2016-11-25 Thread Dave Page
Hi On Thu, Nov 24, 2016 at 10:44 AM, Surinder Kumar wrote: > Hi > > This patch handles encode/decode issues for files names when following > operations are performed such as "create/rename/delete/download/upload" or > browsing a file etc. > > Changes in code: > 1) Removed cleanstring() js functio

Re: [pgadmin-hackers] [Patch]: RM#1979 - Editing Function Issues

2016-11-25 Thread Dave Page
Thanks, patch applied. On Thu, Nov 24, 2016 at 10:51 AM, Neel Patel wrote: > Hi, > > Please find attached patch file with the fix of below issues along with > mentioned in description. > > Function arguments are omitted in SQL tab (msql). > Function arguments are not displayed under "Arguments" t

[pgadmin-hackers] pgAdmin 4 commit: Deal with Function arguments correctly in the propert

2016-11-25 Thread Dave Page
Deal with Function arguments correctly in the properties dialogue. Fixes #1979 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54e6336a58884007609d96cebe7ea20be817ded9 Author: Neel Patel Modified Files -- .../functions/templates/fu

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2016-11-25 Thread Dave Page
On Thu, Nov 24, 2016 at 12:13 PM, Surinder Kumar wrote: > Hi > > Please find updated patch with change. > > On Fri, Oct 21, 2016 at 9:16 PM, Dave Page wrote: >> >> On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar >> wrote: >> > On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: >> >> >> >> Hi >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

2016-11-25 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Nov 25, 2016 at 2:56 PM, Dave Page wrote: > Hi > > This doesn't apply - can you rebase it please? > > Thanks. > > On Thu, Nov 24, 2016 at 8:57 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached updated pat

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

2016-11-25 Thread Dave Page
Hi On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. Please see the attached screenshot. It's still offering to let me connect to a database with datallowconn=false, or create objects in it. It also doesn't display the properties or dashbo

Re: [pgadmin-hackers] Final pgAdmin III - v1.22.2 Released

2016-11-25 Thread Erwin Brandstetter
So long an thanks for all the fish! How does the final release of pgadmin III v1.22.2 compare to the BigSQL release "pgAdmin3 LTS 1.23.0a" A later version number, released earlier? https://bigsql.com/components.jsp https://bigsql.org/pgadmin3/index.jsp Which one would you recommend as final vers