[pgadmin-hackers] [pgAdmin4][Patch]: RM1938 - Backgrid sorting not working for Integer/Number types

2017-01-06 Thread Surinder Kumar
Hi, As the type of data we get from server side is of string type, due to which the sorting for Integer/Number type columns is not working. To fix this issue, we are using BigNumber JS library. We are overriding Backgrid's sort and make_comparator method in backgrid.pgadmin.js. When sorting is p

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement

2017-01-06 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM 1730 - Role membership control display needs improvement *Fixed items:* - An alternate note is needed when shown on the properties panel - Remove the border - Align the label and control in columns as per other controls. *Remaining*: - Investigate m

Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2017-01-06 Thread Neel Patel
Hi Dave, I am able to reproduce the issue with the steps mentioned. Please find attached patch file for the fix. I have tested on web and desktop mode. Do review it and let us know for comments. Thanks, Neel Patel On Tue, Jan 3, 2017 at 3:18 PM, Dave Page wrote: > Hi > > On Fri, Dec 23, 2016

[pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4)

2017-01-06 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where some dialogue control buttons were not consistent with others dialogs. RM#1364 Patch fixes, 1) Preferences: Close, Maximise, Pin - Removed Pin button 2) Wizards: Close - Added Maximise button, which is can used with 'show_header_maximize_btn' option. 3) Pro

[pgadmin-hackers] pgAdmin 4 commit: Format JSON more efficiently. This can significantly

2017-01-06 Thread Dave Page
Format JSON more efficiently. This can significantly reduce response sizes from the server. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1504d05cddc4897df7880fc70326b416c6cf9c61 Modified Files -- web/pgadmin/utils/ajax.py | 4 ++

[pgadmin-hackers] pgAdmin 4 commit: Improve query plan tooltip formatting.

2017-01-06 Thread Dave Page
Improve query plan tooltip formatting. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a93a99fdc0aded2a9c0b9ec99e21a742d75b20f6 Modified Files -- web/pgadmin/misc/static/explain/css/explain.css | 6 -- 1 file changed, 4 insertion

[pgadmin-hackers] Driver Module

2017-01-06 Thread George Gelashvili
Hi there, We are working on connecting Greenplum to pgAdmin4. Currently we are exploring how modules work in pgAdmin. In an earlier off-thread email it was suggested we look at "the EDB PPAS" as an example of a driver class. We are not entirely clear on what that means. We found: - the BaseDriver