Re: [pgadmin-hackers] First time launch as simple user (improvement needed)

2017-01-17 Thread Dave Page
Hi On Mon, Jan 16, 2017 at 5:20 PM, Bruno Friedmann wrote: > In packaged world, the user will have a pgAdmin4.desktop file to be able to > run it from normal menus. Yes. > I've just tested a full fresh install on user system, and if it is run from > graphical environnement, nobody will see the

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-17 Thread Dave Page
Hi On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar wrote: > Hi > > Please find updated patch following changes: > 1) Keep field 'opclass' combo box enabled. That doesn't seem to be working. > 2) Keep ASC/DESC and NULLs FIRST/LAST options disable for access methods > other than 'btree'. > 3) Add

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Dave Page
Thanks. What log output do you get? On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas wrote: > Hi Dave. > > After applying this patch on Windows 2012 server 64 with Python 2.7.11 on > EPAS-9.6 server, Maintenance DB and Backup database failed. > > Please find attached the snapshot. > > Kind Regards,

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-17 Thread Surinder Kumar
Hi On Tue, Jan 17, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar > wrote: > > Hi > > > > Please find updated patch following changes: > > 1) Keep field 'opclass' combo box enabled. > > That doesn't seem to be working. ​Is the field 'opclass' is not e

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Fahar Abbas
Issue is also reproducible with PG-9.6 server. Regards, On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas wrote: > Please attached the log files output from the terminal and pgAdmin4.log. > > Kind Regards, > > > On Tue, Jan 17, 2017 at 2:46 PM, Dave Page wrote: > >> Thanks. What log output do you g

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Dave Page
Not surprising. Don't bother testing that any more for now thanks. I suspect it's a simple bug that Ashesh can fix pronto. On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas wrote: > Issue is also reproducible with PG-9.6 server. > > Regards, > > > On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas > wrot

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-17 Thread Dave Page
Hi On Tue, Jan 17, 2017 at 9:52 AM, Surinder Kumar wrote: > Hi > On Tue, Jan 17, 2017 at 3:08 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find updated patch following changes: >> > 1) Keep field 'opclass' combo box enabl

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Fahar Abbas
Thanks Dave. On Tue, Jan 17, 2017 at 3:07 PM, Dave Page wrote: > Not surprising. Don't bother testing that any more for now thanks. I > suspect it's a simple bug that Ashesh can fix pronto. > > On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas < > fahar.ab...@enterprisedb.com> wrote: > >> Issue is a

[pgadmin-hackers] pgAdmin 4 commit: Improve display of columns of exclusion contraints an

2017-01-17 Thread Dave Page
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28621999f22805852cd19ad7dca2a72cfb676e7e Author: Murtuza Zabuawala Modified Files ---

Re: [pgadmin-hackers] PATCH: To display column information properly in Properties Panel (pgAdmin4)

2017-01-17 Thread Dave Page
Hi On Fri, Jan 13, 2017 at 9:31 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to display columns in Properties panel for exclusion constraint > node, and in addition to that I found similar issue with foreign key node. > > We will also remove placeholder from Select2 control if it's in Propert

Re: [pgadmin-hackers] PATCH: To fix the issue in Variable control (pgAdmin4)

2017-01-17 Thread Dave Page
Thanks, patch applied. On Fri, Jan 13, 2017 at 12:29 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where variable control was not displaying values > properly in edit mode. > This issue was due to wrong value set in model. > RM#2067 > > -- > Regards, > Murtuza Zabuawala > Ente

[pgadmin-hackers] pgAdmin 4 commit: Fix display of enum GUCs on users/databases etc. Fixe

2017-01-17 Thread Dave Page
Fix display of enum GUCs on users/databases etc. Fixes #2067 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6557433061a471262e05080d16b2c6b34edc5aa2 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_groups/ser

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-17 Thread Atira Odhner
Thanks for your feedback, Dave! We can put the tests under the regression directory. I think that makes sense. I'm not picturing these tests being module specific, but we may want to enable running it as a separate suite of tests. Thanks for the callout about the port and title. We'll make sure t

Re: [pgadmin-hackers] First time launch as simple user (improvement needed)

2017-01-17 Thread Bruno Friedmann
On mardi, 17 janvier 2017 09.23:49 h CET Dave Page wrote: > Hi > > On Mon, Jan 16, 2017 at 5:20 PM, Bruno Friedmann wrote: > > In packaged world, the user will have a pgAdmin4.desktop file to be able > > to > > run it from normal menus. > > Yes. > > > I've just tested a full fresh install on us

Re: [pgadmin-hackers] First time launch as simple user (improvement needed)

2017-01-17 Thread Dave Page
Hi On Tue, Jan 17, 2017 at 4:50 PM, Bruno Friedmann wrote: > On mardi, 17 janvier 2017 09.23:49 h CET Dave Page wrote: >> Hi >> >> On Mon, Jan 16, 2017 at 5:20 PM, Bruno Friedmann wrote: >> > In packaged world, the user will have a pgAdmin4.desktop file to be able >> > to >> > run it from normal