[pgadmin-hackers] pgAdmin4: Minor code change in test-suite (RM #2127)

2017-01-31 Thread Navnath Gadakh
Hello Dave, Please find the attached patch for minor code changes in test-suite. It's just need to add config.UPGRADE_CHECK_ENABLED = False in runtests.py. So that it will not try to check the application version if there is no internet connection on the host machine. Thanks. -- Regards, Na

[pgadmin-hackers] Regarding Import and Export Issue

2017-01-31 Thread vinay.mali
Hello I have issue for the for the tables data in the Export and import functionality.  Regards,Vinay MaliSoftware Developer | Pune, (IST) | 

Re: [pgadmin-hackers] Regarding Import and Export Issue

2017-01-31 Thread Murtuza Zabuawala
Hi, Provide required details as below, - pgAdmin4 Version: ? - PostgreSQL Version: ? - Operating system: ? - Reproduce steps: Clearly mention the steps to reproduce the bug. - Expected result: How application should behave on the above mentioned steps. - Actual result: What i

[pgadmin-hackers] pgAdmin 4 commit: Python 3 fix for the template loader test.

2017-01-31 Thread Dave Page
Python 3 fix for the template loader test. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2e5771e164d2f67118948c4a620a1262a47dbdeb Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/tests/test_versioned_template_loader.

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Dave Page
Thanks Murtuza. When you get a minute, can you also look at the following issue I get with the tests under Python 3.5? It doesn't seem to stop them working. Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/route.py", line 75, in load_generators import_modu

Re: [pgadmin-hackers] Regarding Import and Export Issue

2017-01-31 Thread vinay.mali
Hi, Provide required details as below, - pgAdmin4 Version: Yes after installing PostgreSQL 9.6 - PostgreSQL Version: 9.6 - Operating system: Windows 10 - Reproduce steps: Clearly mention the steps to reproduce the bug. - Create table test having id as integer a

[pgadmin-hackers] pgAdmin 4 commit: Disable upgrade checks during regression testing.

2017-01-31 Thread Dave Page
Disable upgrade checks during regression testing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd53e0c527db5a13f6abdaa2cdf18d26e5f42665 Author: Navnath Gadakh Modified Files -- web/regression/runtests.py | 5 + 1 file changed

Re: [pgadmin-hackers] pgAdmin4: Minor code change in test-suite (RM #2127)

2017-01-31 Thread Dave Page
Thanks, applied. On Tue, Jan 31, 2017 at 6:23 AM, Navnath Gadakh wrote: > Hello Dave, > Please find the attached patch for minor code changes in test-suite. > It's just need to add config.UPGRADE_CHECK_ENABLED = False in runtests.py. > So that it will not try to check the application version

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Ashesh Vashi
Murtuza, FYI - http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html#itertools -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Murtuza Zabuawala
Hi Dave, Even I tested against Python3.5 but did not receive any such error and I tried again after your mail but still did not receive error. murtuza@vm:~/pgadmin4/web/regression$ python3 --version Python 3.5.0 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterpr

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Dave Page
On Tue, Jan 31, 2017 at 10:36 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Even I tested against Python3.5 but did not receive any such error and I > tried again after your mail but still did not receive error. > > murtuza@vm:~/pgadmin4/web/regression$ python3 --version > > Python 3.5.0 Hmm, I hav

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Murtuza Zabuawala
Hi Dave, Please find minor patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 31, 2017 at 4:10 PM, Dave Page wrote: > On Tue, Jan 31, 2017 at 10:36 AM, Murtuza Zabuawala > wrote: > > Hi Dave, > > > > Even I

[pgadmin-hackers] pgAdmin 4 commit: Another Python 3 fix.

2017-01-31 Thread Dave Page
Another Python 3 fix. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0da8d1fe4c62e03157fcbee7b1f626dbae4f140c Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/sqlautocomplete/counter.py | 7 ++- 1 file changed, 6 i

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Dave Page
Works a treat - thanks, applied. On Tue, Jan 31, 2017 at 10:49 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Please find minor patch for the same. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Jan 31, 2017 at 4:10 P

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-31 Thread Dave Page
Hi On Mon, Jan 30, 2017 at 9:23 PM, Atira Odhner wrote: > Here's the patch with one more fix -- cleaning up the connections that get > created in pgAdmin. Hmm, I had trouble with this one. I noticed a few issues: - The tests started pgAdmin listening on the default port (5050), however, I alrea

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-31 Thread George Gelashvili
Hi Dave, We agree that a random port would be a nice addition. We think having randomized test database names can lead to polluting with lots of extra databases left around in the event that cleanup fails for whatever reason (e.g. a test errors out). We see this happen already with the randomized

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-31 Thread Dave Page
Hi On Tue, Jan 31, 2017 at 2:54 PM, George Gelashvili wrote: > Hi Dave, > > We agree that a random port would be a nice addition. We think having > randomized test database names can lead to polluting with lots of extra > databases left around in the event that cleanup fails for whatever reason >

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-31 Thread Dave Page
Hi George, I just tried to do some debugging of pgAdmin, and found that I couldn't start it. On further investigation, I found that I had an instance running in the background on my system. I'm assuming this was started by the acceptance tests, but not shutdown. I killed it off, and re-ran the tes