Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-02-01 Thread Fahar Abbas
Sure Ashesh, I will test and update the testing status accordingly. On Thu, Feb 2, 2017 at 11:17 AM, Ashesh Vashi wrote: > Hi Fahar, > > Can you please test the updated patch? > I have fixed one issue on windows, and also added logging information in > the

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-02-01 Thread Ashesh Vashi
Hi Fahar, Can you please test the updated patch? I have fixed one issue on windows, and also added logging information in the background process execution for future issue analysis. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers][Patch] Show databases for Greenplum

2017-02-01 Thread Dave Page
Thanks George, patch applied. Fahar; whilst this is a technically simple patch, it was also very large. Please keep an eye out for any issues. On Tue, Jan 31, 2017 at 10:08 PM, George Gelashvili wrote: > Hi Hackers, > > We're working on

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-01 Thread Dave Page
Hi On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch. This seems to display "timestamp(0) with[out] timezone" columns correctly in both the properties panel and dialog now, but the size is still ignored if I try to add

[pgadmin-hackers] pgAdmin 4 commit: Properly handle setting comments and other options on

2017-02-01 Thread Dave Page
Properly handle setting comments and other options on databases with allowconn = False. Fixes #2024 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d442da9ffd7acbc97fc28e8dc95e043fefa1617 Author: Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: Rename the 9.1_plus templates to "default" to more ap

2017-02-01 Thread Dave Page
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d05302ca106e1f07e1372284e00507dc3058fe2 Author: George Gelashvili

Re: [pgadmin-hackers][Patch] Show databases for Greenplum

2017-02-01 Thread Fahar Abbas
I was also thinking with same pattern and we need to verify this change thoroughly. Thanks Dave. Regards, On Wed, Feb 1, 2017 at 2:59 PM, Dave Page wrote: > Thanks George, patch applied. > > Fahar; whilst this is a technically simple patch, it was also very > large. Please

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-02-01 Thread Dave Page
Thanks - patch applied! On Wed, Feb 1, 2017 at 10:08 AM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch, issue was conn.release(did=did) was removing all > connection for same database from connection manager. > We have now created new connection

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-02-01 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch, issue was conn.release(did=did) was removing all connection for same database from connection manager. We have now created new connection for offline updates using "conn_id" parameter instead of did. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB:

[pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

2017-02-01 Thread Murtuza Zabuawala
Hi, PFA minor patch to display value '0' in Read only text editor. RM#2138 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/slickgrid/slick.pgadmin.editors.js

Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

2017-02-01 Thread Murtuza Zabuawala
Thanks Dave. Tested and working fine. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 1, 2017 at 7:20 PM, Dave Page wrote: > Hi > > On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala >

Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

2017-02-01 Thread Dave Page
Hi On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to display value '0' in Read only text editor. > RM#2138 Thanks - I committed a modified version of the patch; yours had the same tests duplicated and joined with an or

[pgadmin-hackers] pgAdmin 4 commit: Fix display of zeros in read-only grid editors. Fixes

2017-02-01 Thread Dave Page
Fix display of zeros in read-only grid editors. Fixes #2138 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=687a793383fa2531c8c2a6a9f82213c5779e470a Author: Murtuza Zabuawala Modified Files --