Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-04 Thread Dave Page
Hi, This seems to work nicely now for text and int fields etc. but you haven't handled booleans. They should have a 3 state checkbox in edit mode (checked == true, clear == false, blurred == null (see pgAdmin 3). I've committed the patch, but can you please get me an additional one for boolean su

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-04 Thread Dave Page
BTW, this may help: https://css-tricks.com/indeterminate-checkboxes/ On Sat, Feb 4, 2017 at 1:15 PM, Dave Page wrote: > Hi, > > This seems to work nicely now for text and int fields etc. but you > haven't handled booleans. They should have a 3 state checkbox in edit > mode (checked == true, clear

[pgadmin-hackers] pgAdmin 4 commit: Support setting text fields to empty strings or NULL

2017-02-04 Thread Dave Page
Support setting text fields to empty strings or NULL in the data editor grid. Fixes #1790 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54ba1fbe593a20261eb061ca262aab45b64329de Author: Surinder Kumar Modified Files -- .../static

[pgadmin-hackers] pgAdmin 4 commit: Remove help text for an option that no longer exists.

2017-02-04 Thread Dave Page
Remove help text for an option that no longer exists. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3cc58cf3de667f2d8e31519598ed6d3e6c13f9d6 Modified Files -- docs/en_US/preferences.rst | 1 - 1 file changed, 1 deletion(-) -- Se

[pgadmin-hackers] pgAdmin 4 commit: Add some help on data editing.

2017-02-04 Thread Dave Page
Add some help on data editing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=426ee40a714494149fe6e845f7de9a59aa37a4ba Modified Files -- docs/en_US/query_tool.rst | 8 1 file changed, 8 insertions(+) -- Sent via pgadmin-

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-04 Thread Dave Page
Hi Murtuza, I clearly neglected to run the regression tests with this patch, and unfortunately it looks like it broke them. Can you look at this ASAP please? runTest (pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_add.ColumnAddTestCase) This function will

[pgadmin-hackers] pgAdmin 4 commit: Fix process execution. Fixes #1679. Fixes #2144.

2017-02-04 Thread Dave Page
Fix process execution. Fixes #1679. Fixes #2144. Re-engineer the background process executor, to avoid using sqlite as some builds of components it relies on do not support working in forked children. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitd

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-02-04 Thread Dave Page
Thanks - applied with some minor UI and string tweaks. On Fri, Feb 3, 2017 at 3:40 PM, Ashesh Vashi wrote: > Hi Dave, > > Please find the patch with fix for the 2144. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-04 Thread Surinder Kumar
Hi Dave, I have overriden the checkbox editor to add 'indeterminate' state of checkbox other than checked and unchecked which gives the user capability to set [null] value for boolean types. Please find updated patch and review. On Sat, Feb 4, 2017 at 6:47 PM, Dave Page wrote: > BTW, this may