[pgadmin-hackers] pgAdmin 4 commit: Handle NULL booleans in the data editor. Fixes #1790

2017-02-05 Thread Dave Page
Handle NULL booleans in the data editor. Fixes #1790 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4566877188b3e41caa3a2a786a930c98f8d1d40e Author: Surinder Kumar Modified Files -- .../static/js/slickgrid/slick.pgadmin.editors.js

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-05 Thread Dave Page
Thanks - patch applied! On Sat, Feb 4, 2017 at 8:58 PM, Surinder Kumar wrote: > Hi Dave, > > I have overriden the checkbox editor to add 'indeterminate' state of > checkbox other than checked and unchecked which gives the user capability to > set [null] value > for boolean types. > > Please find

[pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

2017-02-05 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue with Graphical Explain plan functionality which was breaking for INSERT/UPDATE/DELETE explain plans. RM#2133 *Issue:* It was due to typo in imageMapper object. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise Po

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-05 Thread Murtuza Zabuawala
Sure, Checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sat, Feb 4, 2017 at 7:34 PM, Dave Page wrote: > Hi Murtuza, > > I clearly neglected to run the regression tests with this patch, and > unfortunately it looks like it brok

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-05 Thread Murtuza Zabuawala
Hi Dave, Please find a fix for the same, attribute length was set to False instead of None. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 6, 2017 at 11:18 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: