Re: [pgadmin-hackers][patch] change --pkg behavior

It looks like there was some test setup logic that happened in test_utils.py that was node-name specific. We've removed that logic and re-enabled cleaning up the test databases. Tira & George On Thu, Feb 9, 2017 at 7:16 AM, Dave Page wrote: > Hi > > On Wed, Feb 8, 2017 at

Re: [pgadmin-hackers] Issues with PgAdmin4

Thanks for the prompt response. The problem with 'Reset Layout' is you lose all queries in all windows if you haven't saved them. Wouldn't it be nice to allow users to set a preference if they want these windows dockable or static? That way users like me who don't like this feature can still

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Harshal, I had a brief discussion with Ashesh about this. He's going to setup a call next week for us to discuss a plan of action for eliminating any remaining encoding issues including this one. I'm putting this on hold until then. Thanks. On Mon, Feb 6, 2017 at 2:54 PM, Harshal Dhumal

Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

Hi On Thu, Feb 9, 2017 at 7:26 AM, Murtuza Zabuawala wrote: > Hi, > > It's not a good idea to directly change in main Library, Lets say if newer > version of CodeMirror available and we want to pull new version then we need > to maintain this change set every

[pgadmin-hackers] building with Qt runtime question

Hello Hackers! We're having trouble building the app with Qt runtime. We've tried running make appbundle after setting PGDIR, QTDIR, PYTHON_HOME, and PYTHON_VERSION environment variables. We've tried setting PYTHON_HOME to the roots of brew (effectively, system) python as well as the virtualenv

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Feb 3, 2017 at 7:53 PM, Dave Page wrote: > > > On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Fri, Feb 3, 2017 at 7:02 PM, Dave Page

Re: [pgadmin-hackers][patch] change --pkg behavior

Hi On Wed, Feb 8, 2017 at 9:37 PM, Atira Odhner wrote: > Here is the additional patch to exclude one or more packages. > > On Tue, Feb 7, 2017 at 6:02 PM, George Gelashvili > wrote: >> >> Hello Hackers, >> >> To chase down a set of tests that were

Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

Good point! I guess I was asleep at the wheel on this one. I didn't notice it was a library. On Thu, Feb 9, 2017, 4:37 AM Dave Page wrote: > Hi > > On Thu, Feb 9, 2017 at 7:26 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > It's not a good

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Hi I get the following crash when running with Python 3.4 or 3.5: (pgadmin4-py34) piranha:pgadmin4 dpage$ python web/regression/runtests.py pgAdmin 4 - Application Initialisation == The configuration database - '/Users/dpage/.pgadmin/test_pgadmin4.db' does

Re: [pgadmin-hackers][patch] We can see tables in Greenplum!

Great! Here is an updated patch set. -Tira & George On Thu, Feb 9, 2017 at 12:33 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > Regarding test output, > > > *Comment Style-1:* If we comment like > > """Test Case is used for... """ > > *Result:* > > runTest

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Hi Dave, I think the problem was that the way you phrased it, You're right, we totally messed that up. We were talking about making 3 patches and ended up making only 2 and forgot to reword that bit. Sorry about that. Here are the two patches for this change that resolves the AttributeError

[pgadmin-hackers] pgAdmin 4 commit: Update supported Python versions.

Update supported Python versions. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3697bf0a2cb3bd73499ca39b61f7111fa3a0a53b Modified Files -- README | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- Sent via

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

OK, well that one was sent back with feedback as well, so please resubmit when the relevant updates have been made to either and they've been retested. Given the amount of work you're doing at the moment, it would be helpful if you could note when one patch is dependent on another. It's hard to

[pgadmin-hackers] pgAdmin 4 commit: Fix the issue with Jinja conditions in Foreign Data W

Fix the issue with Jinja conditions in Foreign Data Wrappers, Foreign Servers, User Mapping. I also did some re-formatting & re-factoring to code to remove all the duplicate code. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Ensure FTS parsers and templates are removed prior to

Ensure FTS parsers and templates are removed prior to creating them when testing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=68879202954cf6852bc6b27a0175706d0c93ad68 Author: Murtuza Zabuawala Modified

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

create_table is the change we pulled into the other patch which would need to be applied first. On Thu, Feb 9, 2017, 7:47 AM Dave Page wrote: > Hi > > I get the following crash when running with Python 3.4 or 3.5: > > (pgadmin4-py34) piranha:pgadmin4 dpage$ python

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Certainly. We did mention the dependency in the email. Would it be better to mention it in the patch name? Is there a better way for us to manage these changes? On other open source projects, I've seen github mirrors set up so that changes can be pulled in like branches rather then as patch

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Hi On Thu, Feb 9, 2017 at 2:20 PM, Atira Odhner wrote: > Certainly. We did mention the dependency in the email. Would it be better > to mention it in the patch name? I think the problem was that the way you phrased it, it sounded optional ("an updated patch which does not

[pgadmin-hackers] Communication Channels

Hello Hackers, We were wondering if there is a pgadmin-hackers IRC or similar setup for closer-to-realtime communication? Thanks! George

Re: [pgadmin-hackers] Communication Channels

Hi On Thu, Feb 9, 2017 at 5:02 PM, George Gelashvili wrote: > Hello Hackers, > > We were wondering if there is a pgadmin-hackers IRC or similar setup for > closer-to-realtime communication? There are no dedicated channels. I'm pgsnake on Freenode's IRC network - but I

Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

Here's the updated patch On Thu, Feb 9, 2017 at 8:52 AM, Atira Odhner wrote: > Good point! I guess I was asleep at the wheel on this one. I didn't notice > it was a library. > > On Thu, Feb 9, 2017, 4:37 AM Dave Page wrote: > >> Hi >> >> On Thu, Feb 9,