Hi Hackers,
Attached you can find the patches that finish the following Redmine Issue
https://redmine.postgresql.org/issues/2216
*Note:*
These changes depend on the acceptance of the patch that we submitted on
the email thread: "Refactor: clipboard, translations, jasmine"
This makes some changes
Hi
On Tue, Mar 14, 2017 at 8:16 PM, Atira Odhner wrote:
> Dave, try doing the yarn install and karma run from the web directory.
> karma cli expects karma to be under node_modules where it is run from.
> (which is where yarn will install it if you use yarn from the web
> directory). Karma also n
you could also try installing it with yarn.
On Wed, Mar 15, 2017, 9:16 AM Atira Odhner wrote:
> Hmm. I'm not sure why you can't install karma-cli. Are you able to run the
> tests using raw karma? (probably `web/node_modules/karma/bin/karma start` )
>
> On Wed, Mar 15, 2017, 8:56 AM Dave Page wr
Hmm. I'm not sure why you can't install karma-cli. Are you able to run the
tests using raw karma? (probably `web/node_modules/karma/bin/karma start` )
On Wed, Mar 15, 2017, 8:56 AM Dave Page wrote:
> Hi
>
> On Tue, Mar 14, 2017 at 8:16 PM, Atira Odhner wrote:
>
> Dave, try doing the yarn instal
Oops, somehow we ended up with package.json in the wrong directory! It
should be under web. Here is a patch to fix it. I also updated the readme
yarn/karma instructions.
Tira
On Wed, Mar 15, 2017 at 9:18 AM, Atira Odhner wrote:
> you could also try installing it with yarn.
>
> On Wed, Mar 15, 2
Hey Dave, looks like we missed the .keep file in the screenshots directory
when applying this patch.
It's making screenshots fail to be captured when the directory doesn't
exist (e.g. in CI).
On Thu, Mar 9, 2017 at 10:34 AM, Dave Page wrote:
> Create screenshots when feature tests fail.
>
> Br
Hello Hackers,
Chrome's latest update to version 57 is not compatible with the Chrome
driver of Selenium. This patch updates Selenium and adds the latest Chrome
driver to make the tests run.
Thanks
Joao & Sarah
0001-Update-Selenium-and-ChromeDriver-to-support-chrome-v.patch
Description: Binary
Add Jasmine test framework for JS testing.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f84156dc6589304e56f202151bf9199c6f7e985
Author: Atira Odhner
Modified Files
--
.gitignore | 1 +
karma.conf.js
Add a mechanism for centralising JS translations, to avoid having to render
many JS files with Jinja.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4445f9dd63709849875cd3e422d4df3d50bca8da
Author: Atira Odhner
Modified Files
--
Refactor clipboard copying into a separate file for use outside the SQL Editor.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=172b41cba8b8c3b4129255aa904620ec318cf154
Author: Atira Odhner
Modified Files
--
web/pgadmin/static/js/s
Fix quotes to ensure we have valid JS.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=889050b71d05aa270c61bb2d62f3565e4cfa7d98
Author: Atira Odhner
Modified Files
--
.../sqleditor/templates/sqleditor/js/sqleditor.js | 128 +++
Fix the path to JS
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae0d8e89eb9feb1162f345100492868050805992
Author: Atira Odhner
Modified Files
--
web/pgadmin/static/js/selection/clipboard.js| 2 +-
web/pgadmin/t
Move the karma config and node_modules into the web directory.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5593faf2a4dce0446e6595dd1b3d6da92e9a6101
Author: Atira Odhner
Modified Files
--
karma.conf.js
Don't ship the node_modules directory with packages as it's only used for local
testing.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8fa0c4e28419750cf0201128f0309af8fc62b71
Author: Atira Odhner
Modified Files
--
Make.bat
Move the package.json file to the web/ directory
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dbddad50bf8e2cf3799b957144436d1d94a403e3
Author: Atira Odhner
Modified Files
--
package.json | 10 --
web/package.json
README improvements.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc4686f1bb9ce1f8d0f87c07a6a1193e4163
Modified Files
--
web/regression/README | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
--
That go it! Thanks, patch applied.
On Wed, Mar 15, 2017 at 2:46 PM, Atira Odhner wrote:
> Oops, somehow we ended up with package.json in the wrong directory! It
> should be under web. Here is a patch to fix it. I also updated the readme
> yarn/karma instructions.
>
> Tira
>
> On Wed, Mar 15, 201
Awesome! Thanks! :D
On Wed, Mar 15, 2017 at 1:16 PM, Dave Page wrote:
> That go it! Thanks, patch applied.
>
> On Wed, Mar 15, 2017 at 2:46 PM, Atira Odhner wrote:
>
>> Oops, somehow we ended up with package.json in the wrong directory! It
>> should be under web. Here is a patch to fix it. I al
Originally we had a .keep file in the screenshots directory. This patch
dynamically creates the screenshots directory.
Tira
0001-ensure-the-screenshots-directory-exists.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to y
Hi Hackers!
Here's a patch to move to current db migration system to use Alembic.
Instructions to create new migrations are in the README.
Thanks!
Joao & Sarah
0001-Switch-to-Alembic-and-Flask-migration-db-migration-s.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pg
Hi Hackers!
It looks like our previous patch messed up some logging. Please use this
one instead.
Thanks,
Joao & Sarah
On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear wrote:
> Hi Hackers!
>
> Here's a patch to move to current db migration system to use Alembic.
> Instructions to create new mi
Hi
On Tue, Mar 14, 2017 at 10:08 PM, Joao Pedro De Almeida Pereira
wrote:
> Hi Hackers,
>
> Attached you can find the patches that finish the following Redmine Issue
> https://redmine.postgresql.org/issues/2216
>
> Note:
> These changes depend on the acceptance of the patch that we submitted on t
Ensure the screenshots directory exists before trying to save regression test
screenshots
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2abd3724c2042e88da3bd5b3e9ac2e03f61b231a
Author: Atira Odhner
Modified Files
--
web/regressi
Thanks, applied.
On Wed, Mar 15, 2017 at 6:11 PM, Atira Odhner wrote:
> Originally we had a .keep file in the screenshots directory. This patch
> dynamically creates the screenshots directory.
>
> Tira
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make cha
All,
I'd like to clarify our patch submission expectations as I think
there's been some confusion recently:
- Typically each new feature or change should be a single patch,
ideally in it's own mail thread for future tracking/searching etc.
- Large patches may be broken up into 2 or more smaller
Hi,
I spent a couple of hours this morning to build pgadmin4 dependencies on RHEL
6. I think I made them work, but pgadmin4 does not run (actually it runs, but
the window comes empty). Here is the console output. Can you please take a
look?
[devrim@CentOS6x8664 ~]$ pgadmin4
Python path:
"/usr
26 matches
Mail list logo
