Re: [pgadmin-hackers] Last few steps for pgadmin4 on RHEL 6

2017-03-16 Thread Dave Page
-- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 16 Mar 2017, at 04:24, Devrim Gündüz wrote: > > > Hi, > > I spent a couple of hours this morning to build pgadmin4 dependencies on RHEL > 6. I

Re: [pgadmin-hackers] Last few steps for pgadmin4 on RHEL 6

2017-03-16 Thread Dave Page
That one is easy, there's a setting in config.py to enable/disable HTML minimisation. Put that in config_distro.py and set it to False. In 1.4, that'll happen automatically with Python 2.6. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb

[pgadmin-hackers] pgAdmin 4 commit: Update test requirements to include a version of Sele

2017-03-16 Thread Dave Page
Update test requirements to include a version of Selenium that supports Chrome 57, and the chromedriver installer. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6ad6bf5aab212c19b94b7ac353598dd59d3b7ea3 Author: Joao Pedro De Almeida Pereira

Re: [pgadmin-hackers][patch] Update Selenium and Chrome driver

2017-03-16 Thread Dave Page
Thanks, applied. On Wed, Mar 15, 2017 at 4:02 PM, Joao Pedro De Almeida Pereira wrote: > Hello Hackers, > > Chrome's latest update to version 57 is not compatible with the Chrome > driver of Selenium. This patch updates Selenium and adds the latest Chrome > driver to make the tests run. > > Thank

[pgadmin-hackers] Feature test regression failures

2017-03-16 Thread Dave Page
Hi Ashesh, A common theme is emerging from some of the feature test regression failures on the Jenkins server. Please see: https://jenkins.pgadmin.org/job/pgadmin4-master-python27/ws/web/regression/screenshots/EDB_Postgres_AS_9.3/ConnectsToServerFeatureTest-2017.03.16_10.09.18-Python-2.7.13.png

Re: [pgadmin-hackers] Feature test regression failures

2017-03-16 Thread Ashesh Vashi
On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote: > Hi Ashesh, > > A common theme is emerging from some of the feature test regression > failures on the Jenkins server. Please see: > > https://jenkins.pgadmin.org/job/pgadmin4-master-python27/ > ws/web/regression/screenshots/EDB_Postgres_AS_9.3/ >

Re: [pgadmin-hackers] Feature test regression failures

2017-03-16 Thread Dave Page
On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote: > >> Hi Ashesh, >> >> A common theme is emerging from some of the feature test regression >> failures on the Jenkins server. Please see: >> >> https://jenkins

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-16 Thread Dave Page
Ashesh, can you review/commit this please? One thing I notice on a quick look through is that the file headers are missing everywhere. They should be present in all source files, except where they would bloat the data transfer from client to server. On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear

[pgadmin-hackers] pgAdmin 4 commit: Fix a bunch of file headers.

2017-03-16 Thread Dave Page
Fix a bunch of file headers. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2a74ad26de805bea603a161b6a854affa1cf1c2 Modified Files -- web/pgadmin/browser/server_groups/__init__.py | 1 + .../servers/databases/casts/tests

Re: [pgadmin-hackers] Feature test regression failures

2017-03-16 Thread Atira Odhner
I have seen this issue as well. Ashesh, this issue is related to the loading of the tree node data, not loading of code, correct? Each time the user expands a node triggers an ajax request to fetch the child nodes. There are probably some performance tradeoffs to loading that tree up front. But,

Re: [pgadmin-hackers] Last few steps for pgadmin4 on RHEL 6

2017-03-16 Thread Devrim Gündüz
Hi Dave, On Thu, 2017-03-16 at 07:44 +, Dave Page wrote: > That one is easy, there's a setting in config.py to enable/disable HTML > minimisation. Put that in config_distro.py and set it to False. Thank you! 1.3-2 RPMs on RHEL 6 in 9.6 testing repo now builds and run on RHEL 6 (x86_64). 32-b

Re: [pgadmin-hackers] Feature test regression failures

2017-03-16 Thread Ashesh Vashi
On Mar 16, 2017 22:32, "Atira Odhner" wrote: I have seen this issue as well. Ashesh, this issue is related to the loading of the tree node data, not loading of code, correct? Theoritically - Each node may contain code to represent the node url. For all current nodes follow the function (present

Re: [pgadmin-hackers] Patch submissions

2017-03-16 Thread Atira Odhner
Hi Dave, I'm wondering what pain you are feeling around having multiple patches. >From my perspective it is much easier to deal with smaller commits as it gives us a quicker way to understand each change if we want to look back at history. I agree that each patch should work standalone (tests sho

[pgadmin-hackers][patch] Fix SQL tab for postgres 9.1 tables (RM #2260)

2017-03-16 Thread Atira Odhner
Hi Hackers, It looks like the sql tab was broken for postgres 9.1 because there was an error in the template. We found this when we started trying to fix it for Greenplum. We don't have an instance of Postgres 9.1, so we haven't tested this out, but this patch is at least going in the right direc

Re: [pgadmin-hackers] Feature test regression failures

2017-03-16 Thread Atira Odhner
> > We're relying on the third party library jquery.acitree for tree > operations. Yes, what I was suggesting is to probably move away from that. AciTree is one of the libraries my team identified as questionable (not in major repositories, not actively maintained) and there are lots of alternati