[pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

Hi, Here is patch for RM2243 and RM2244 Changes: 1. Pickup correct encoding in qtLiteral to decode. 2. While releasing database connection only decode database name if it's not unicode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise Postg

Re: [pgadmin-hackers] Last few steps for pgadmin4 on RHEL 6

Hi On Thu, Mar 16, 2017 at 5:15 PM, Devrim Gündüz wrote: > > Hi Dave, > > On Thu, 2017-03-16 at 07:44 +, Dave Page wrote: >> That one is easy, there's a setting in config.py to enable/disable HTML >> minimisation. Put that in config_distro.py and set it to False. > > Thank you! 1.3-2 RPMs on

Re: [pgadmin-hackers] Last few steps for pgadmin4 on RHEL 6

Hi Dave, On Fri, 2017-03-17 at 08:57 +, Dave Page wrote: > > However, I am not too excited about the current situation in the repo, as I > > updated some RHEL 6 packages (like -crypto, etc), which may mean breakage > > to > > some servers. I'll think about that for a while. > > Oh, urgh. Can

Re: [pgadmin-hackers] Patch submissions

Hi On Thu, Mar 16, 2017 at 5:58 PM, Atira Odhner wrote: > Hi Dave, > > I'm wondering what pain you are feeling around having multiple patches. > > From my perspective it is much easier to deal with smaller commits as it > gives us a quicker way to understand each change if we want to look back at

Re: [pgadmin-hackers] Last few steps for pgadmin4 on RHEL 6

On Fri, Mar 17, 2017 at 9:11 AM, Devrim Gündüz wrote: > > Hi Dave, > > On Fri, 2017-03-17 at 08:57 +, Dave Page wrote: >> > However, I am not too excited about the current situation in the repo, as I >> > updated some RHEL 6 packages (like -crypto, etc), which may mean breakage >> > to >> > so

[pgadmin-hackers] pgAdmin 4 commit: Fix a typo and remove an unnecessary copy of the colu

Fix a typo and remove an unnecessary copy of the column properties template. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4464be6f43419fc049e08bac0714c0779c539f86 Author: Atira Odhner Modified Files -- .../templates/column/sql/9

Re: [pgadmin-hackers][patch] Fix SQL tab for postgres 9.1 tables (RM #2260)

Thanks, applied. On Thu, Mar 16, 2017 at 9:51 PM, Atira Odhner wrote: > Hi Hackers, > > It looks like the sql tab was broken for postgres 9.1 because there was an > error in the template. We found this when we started trying to fix it for > Greenplum. > > We don't have an instance of Postgres 9.1

[pgadmin-hackers] pgAdmin 4 commit: Import from flask_babel instead of the deprecated fla

Import from flask_babel instead of the deprecated flask.ext.babel. Fixes #2264 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=648c332488a3012bbffb2800183aa72b14d0b371 Modified Files -- web/pgadmin/tools/__init__.py | 3 +-- 1 file c

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

Hi, On Mon, Mar 13, 2017 at 4:09 PM, Dave Page wrote: > Hi > > On Fri, Mar 10, 2017 at 1:55 PM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached patch for #2190: Move language selection to > > Preferences. > > > > Moved the user language selection into Preferences. > > > > For t

[pgadmin-hackers] pgAdmin 4 commit: Fix dropping of databases with Unicode names. Fixes #

Fix dropping of databases with Unicode names. Fixes #2243 1. Pickup correct encoding in qtLiteral to decode. 2. While releasing database connection only decode database name if it's not unicode. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

Hi On Fri, Mar 17, 2017 at 7:02 AM, Harshal Dhumal wrote: > Hi, > > Here is patch for RM2243 and RM2244 > > Changes: 1. Pickup correct encoding in qtLiteral to decode. > 2. While releasing database connection only decode database name if it's not > unicode. This fixes 2243, but 2244 is an SQL er

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

Hi On Fri, Mar 17, 2017 at 10:25 AM, Khushboo Vashi wrote: > Hi, > > On Mon, Mar 13, 2017 at 4:09 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Mar 10, 2017 at 1:55 PM, Khushboo Vashi >> wrote: >> > Hi, >> > >> > Please find the attached patch for #2190: Move language selection to >> > Preference

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Mar 17, 2017 at 4:20 PM, Dave Page wrote: > Hi > > On Fri, Mar 17, 2017 at 10:25 AM, Khushboo Vashi > wrote: > > Hi, > > > > On Mon, Mar 13, 2017 at 4:09 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Fri, Mar 10, 2017 at 1

[pgadmin-hackers] pgAdmin 4 commit: Remove test related files from the mac appbundle.

Remove test related files from the mac appbundle. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6abb906b2041a76e18157082bbcc9c20f7d136dd Modified Files -- pkg/mac/build.sh | 12 ++-- 1 file changed, 10 insertions(+), 2 dele

[pgadmin-hackers] [pgAdmin4][Patch] To fix the issues in SQL editor module & Functions node

Hi, PFA patches to fix the issues in SQL Editor & Function nodes. 1) Add handling of DATERANGE[] type RM#2258 2) "By Selection" and "Exclude selection" filter options was broken due to 2d array data conversion. RM#2265 3) Barces are missing on function parameters on SQL tab. RM#2246 Please rev

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

Hi On Fri, Mar 17, 2017 at 12:17 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Mar 17, 2017 at 4:20 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Mar 17, 2017 at 10:25 AM, Khushboo Vashi >> wrote: >> > Hi, >> > >> > On Mon, Mar 13,

[pgadmin-hackers] pgAdmin 4 commit: Fix hadling of DATERANGE[] type. Fixes #2258

Fix hadling of DATERANGE[] type. Fixes #2258 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9702752d98d037eb620a2befa95934b4ad0d42d Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 4 ++-

[pgadmin-hackers] pgAdmin 4 commit: Fix View Data filter options. Fixes #2265

Fix View Data filter options. Fixes #2265 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=461086c17d82193cf0983cfbadf48c166d6e6a3d Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqled

[pgadmin-hackers] pgAdmin 4 commit: Add miissing braces to reverse engineered SQL header

Add miissing braces to reverse engineered SQL header block for Functions. Fixes #2246 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=145983d544dc9a4457e9e2d53e57826208b5e132 Author: Murtuza Zabuawala Modified Files -- .../server_

Re: [pgadmin-hackers] [pgAdmin4][Patch] To fix the issues in SQL editor module & Functions node

Thanks, applied. On Fri, Mar 17, 2017 at 12:27 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patches to fix the issues in SQL Editor & Function nodes. > > 1) Add handling of DATERANGE[] type > RM#2258 > > 2) "By Selection" and "Exclude selection" filter options was broken due to > 2d array data conv

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi! We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers. Thanks! Joao & Sarah On Thu, Mar 16, 2017 at 9:31 AM, Dave Page wrote: > Ashesh, can you review/commit t

[pgadmin-hackers] QGIS Seem To Bypass PostgreSQL/PostGIS User Privileges/Permissions

Hi All, I created a "Read-only" User in PostgreSQL via a Role with "SELECT" ONLY privilege on all tables in a schema as shown below: GRANT SELECT ON ALL TABLES IN SCHEMA [schema_name] TO [role_name] GRANT [role_name] TO [user_name] Next, I test this by trying to UPDATE a column in a table (same

Re: [pgadmin-hackers] Feature test regression failures

Hello, We agree that we should keep an eye on this and the failing feature tests. Our current story touches part of this code, but we won't go into changing the library for now. The patch Tira sent fixes a global variable problem that we found while looking into the code that generates the Tree,

Re: [pgadmin-hackers][patch] Shows titles for disabled buttons on hover

Hi! Here's a new patch that applies to all the buttons. Thanks, Joao and Sarah On Fri, Mar 10, 2017 at 4:06 AM, Dave Page wrote: > Hi > > On Thu, Mar 9, 2017 at 7:05 PM, Joao Pedro De Almeida Pereira > wrote: > > Hello Dave, > > > > We were looking into this request and we found at least on

[pgadmin-hackers][patch] Fix an issue with the tree expansion

Stop using global variable, per thread about feature test regression failures Tira 0001-Stop-using-a-global-variable-for-the-tree-node-when-.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www