On Fri, Mar 17, 2017 at 8:35 PM, Sarah McAlear wrote:
> Hello,
>
> We agree that we should keep an eye on this and the failing feature tests.
> Our current story touches part of this code, but we won't go into changing
> the library for now.
>
> The patch Tira sent fixes a global variable problem
Show tooltips for disabled buttons to help user learning. Fixes #2226
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c9e04fec8dc88edfc9b4f9ff0c7988f71908dbdf
Author: Sarah McAlear
Modified Files
--
web/pgadmin/static/css/bootstrap
Thanks, patch applied!
On Fri, Mar 17, 2017 at 7:17 PM, Sarah McAlear wrote:
> Hi!
>
> Here's a new patch that applies to all the buttons.
>
> Thanks,
> Joao and Sarah
>
>
>
> On Fri, Mar 10, 2017 at 4:06 AM, Dave Page wrote:
>>
>> Hi
>>
>> On Thu, Mar 9, 2017 at 7:05 PM, Joao Pedro De Almeida P
Hi
On Sat, Mar 18, 2017 at 2:57 PM, Harshal Dhumal
wrote:
>
> Please find attached patch for RM2244.
If I run View Data on the table below, I see the following exception
and no grid is rendered:
CREATE TABLE public.varchar_test
(
id integer NOT NULL DEFAULT nextval('varchar_test_id_seq'::re
On Sun, Mar 19, 2017 at 1:41 PM, Magnus Hagander wrote:
>
>
> On Sun, Mar 19, 2017 at 2:33 PM, Devrim Gündüz wrote:
>>
>>
>> Hi,
>>
>> On Fri, 2017-03-17 at 09:40 +, Dave Page wrote:
>> > Hmm. That might be tricky. It might work if you just install it into
>> > the web/ directory.
>>
>> If we
Hi
On Fri, Mar 17, 2017 at 10:12 PM, Jonas Thelemann
wrote:
> Hello pgAdmin hackers,
>
> this is my first suggestion for some translation improvements. It adds a
> space in front of all occurences of three dots at the end of a string which
> seems to be the correct language style. Initially I hop
Hi
On Sat, Mar 18, 2017 at 4:03 PM, Atira Odhner wrote:
>>
>> Patch 4 fixed quotes in sqleditor.js (arguably part of feature 2)
>
>
> This change isn't related to any of the other changes. Combining it with
> another patch would make it more difficult to understand the project
> history.
OK.
>
On Mon, Mar 20, 2017 at 10:24 AM, Ashesh Vashi
wrote:
> On Fri, Mar 17, 2017 at 8:35 PM, Sarah McAlear wrote:
>>
>> Hello,
>>
>> We agree that we should keep an eye on this and the failing feature tests.
>> Our current story touches part of this code, but we won't go into changing
>> the library
Hi Dave,
On Mon, 2017-03-20 at 10:44 +, Dave Page wrote:
> I think the first question to answer is, of the packages that already
> exist in Centos/EPEL, which ones are actually too old to be used?
Don't know. Needs some testing from someone.
> As I mentioned earlier in the thread, the vers
On Mon, Mar 20, 2017 at 12:06 PM, Devrim Gündüz wrote:
>
> Hi Dave,
>
> On Mon, 2017-03-20 at 10:44 +, Dave Page wrote:
>> I think the first question to answer is, of the packages that already
>> exist in Centos/EPEL, which ones are actually too old to be used?
>
> Don't know. Needs some testi
>
> - If we commit half-baked code, there's no guarantee that the
> submitter will actually come back and fix the outstanding problems.
> We've had *significant* baggage in pgAdmin 3 in the past when this has
> happened.
I'm not suggesting you apply the patches before you feel the issues are
addr
[Extendible][Dashboard] Allow to show the dashboard of their choice for
the selected node in the browser tree.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72128df75c9d1f298f7a22738f8f81f11b1ed410
Modified Files
--
.../dashboard/
Hello Hackers,
We noticed that some Python comments were added to the fake_translations.js
file. We flushed out this issue running the Jasmine tests by doing(do not
forget to install node dependencies instructions in web/regression/README):
cd $PGADMIN4_SRC/web/
karma start
This patch corrects t
Hi Ashesh,
*Regarding your second patch:*
It looks like your second patch addresses module loading. This is an
improvement over the previous hard timeout, but won’t do anything for the
tree issues. The module loading code can also be simplified; we’ve attached
a patchset that is tidier, tests the
Use correct file header for a JS file.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ff082ee7427ce0a00e0ac60c9a80c6c6f5c4de0
Modified Files
--
web/regression/javascript/fake_translations.js | 16
1 file changed, 8
Ooops, my bad. Sorry about that - it's fixed now.
On Mon, Mar 20, 2017 at 2:01 PM, Joao Pedro De Almeida Pereira
wrote:
> Hello Hackers,
> We noticed that some Python comments were added to the fake_translations.js
> file. We flushed out this issue running the Jasmine tests by doing(do not
> forg
Note that this patch makes the problem of the tree not having loaded worse,
because it only waits for js modules to load rather than arbitrarily
waiting 900ms.
On Mon, Mar 20, 2017 at 3:17 PM, Atira Odhner wrote:
> Hi Ashesh,
>
> *Regarding your second patch:*
>
> It looks like your second patch
I'm not clear why you believe this to be the correct formatting?
Sorry, the link got removed. Here it is written out:
http://english.stackexchange.com/questions/91653/space-before-three-dots
Again, I thought this would simplify the translation process which it
didn't. Either way I googled that a
Resolved a typo - show a '?' after the 'Show timing' preference.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4eafdbeff6b6c2c05c6934108b8880567798a001
Modified Files
--
web/pgadmin/tools/sqleditor/__init__.py | 2 +-
1 file change
19 matches
Mail list logo
