Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-04 Thread Dave Page
Can you send me a squashed version as a single patch please? On Mon, Apr 3, 2017 at 8:32 PM, Atira Odhner wrote: > Oops, there was a test issue we missed while de-branding. > > Please look at these instead > > On Mon, Apr 3, 2017 at 3:12 PM, Atira Odhner wrote: >>> >>> This doesn't seem to work

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-04 Thread Atira Odhner
Hi Dave, I still think that smaller commits make it easier to handle git history, but here is a squashed patch. We've updated the styling as well. Shirley okayed this styling for now but is going to look into updating it in the future--investigating whether we should keep the checkboxes. Also, a

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-04-04 Thread Matthew Kleiman
Hi Surinder, We looked at your fix for default values in the query tool editor. We think the user experience could be further improved by seeing the actual default value instead of the empty cell. As an intermediate step, there would be user value in seeing "[default]" instead of the blank cell

Re: [pgadmin-hackers] [pgadmin4][patch] Remove (...) from links

2017-04-04 Thread Matthew Kleiman
Okay, feel free to disregard this patch. On Mon, Apr 3, 2017 at 11:17 AM, Dave Page wrote: > Hi > > On Mon, Apr 3, 2017 at 2:47 PM, Sarah McAlear wrote: > > Hi Hackers! > > > > A lot of the links in the app's dropdown menu had a trailing (...), which > > made it seem like there was truncated te