Re: [pgadmin-hackers] [pgAdmin3][Patch]: Fix query viewer row height for High-DPI screens

[Bruno Friedmann]

On mardi, 18 avril 2017 16.14:41 h CEST Ryan Trinkle wrote:
> Hi everyone,
> 
> I know pgAdmin III isn't still actively maintained, but I figured I'd send
> this here in case it's useful to anyone else.  It changes the way that the
> default row height in the data viewer (ctlSQLGrid) is calculated, so that
> the wxFont is asked for the height in pixels rather than in points.  I
> haven't tested this on low-DPI screens, but the calculation seems very
> accurate on my setup, and I think using GetPixelSize is right, based on the
> wxFont documentation.
> 
> 
> Best regards,
> Ryan

Ryan you deserve a glass of the brevage you want, when you want.
Really a pleasure here, tested on 192dpi and 288dpi screen, and this was a 
alleluia moment...

I will confirm tomorrow that it will not break anything on a normal 96 dpi.

Thanks, this will help me to keep this tools active until pgadmin4 finish to 
polish the last glitches.


-- 

Bruno Friedmann 
 Ioda-Net Sàrl www.ioda-net.ch
 Bareos Partner, openSUSE Member, fsfe fellowship
 GPG KEY : D5C9B751C4653227
 irc: tigerfoot




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

[Devrim Gündüz]

Hi Dave,

On Tue, 2017-04-18 at 14:34 +0100, Dave Page wrote:
> What Sphinx version do you have?

1.0.8, which comes from EPEL.

Regards,
-- 
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

[pgadmin-hackers] [pgAdmin3][Patch]: Fix query viewer row height for High-DPI screens

[Ryan Trinkle]

Hi everyone,

I know pgAdmin III isn't still actively maintained, but I figured I'd send
this here in case it's useful to anyone else.  It changes the way that the
default row height in the data viewer (ctlSQLGrid) is calculated, so that
the wxFont is asked for the height in pixels rather than in points.  I
haven't tested this on low-DPI screens, but the calculation seems very
accurate on my setup, and I think using GetPixelSize is right, based on the
wxFont documentation.


Best regards,
Ryan


0001-Set-row-heights-based-on-pixels-rather-than-points.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Prevent the top-left logo from changing colour when c

[Dave Page]

Prevent the top-left logo from changing colour when clicked.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=929a43c9faf116c45b6c0e6121e4c0fec76bcdaa
Author: Jonas Thelemann 

Modified Files
--
web/pgadmin/static/css/bootstrap.overrides.css | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] CSS Focus Bug Fix

[Dave Page]

Thanks, applied.

On Sat, Apr 15, 2017 at 1:06 AM, Jonas Thelemann
 wrote:
> Hello pgAdmin hackers,
>
> when the upper left logo is clicked and the mouse leaves the logo it turns
> white. The attached .diff fixes this bug.
>
> Greetings,
> Jonas Thelemann
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Re-order Makefile targets for readability.

[Dave Page]

Re-order Makefile targets for readability.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=649b064cf3ffab020d62b8b0ea5c20719b3f9047
Author: Jonas Thelemann 

Modified Files
--
Makefile | 56 
1 file changed, 28 insertions(+), 28 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Translation Docs Update & DE Fixes

[Dave Page]

Thanks, patch applied.

On Fri, Apr 14, 2017 at 11:44 PM, Jonas Thelemann
 wrote:
> Hey pgAdmin-hackers!
>
> For the translations docs file I ...
>
>  - ...anonymized the language codes (ISO 639-1, $LANG)
>  - ...clarified the "Updating and Merging" description and removed the
> examples as they were pretty useless in my eyes. Correct me if they had a
> meaning.
>  - ...anonymized the bash user
>  - ...updated the "New Language" section
>
> I fixed the German translation too.
>
> Greetings,
> Jonas
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: German translation update.

[Dave Page]

German translation update.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e127cf4fa117c1b81554a3c236790272912b469
Author: Jonas Thelemann 

Modified Files
--
.../translations/de/LC_MESSAGES/messages.mo|  Bin 102764 -> 113740 bytes
.../translations/de/LC_MESSAGES/messages.po| 1039 ++--
2 files changed, 306 insertions(+), 733 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Translation doc update:

[Dave Page]

Translation doc update:

 - ...anonymized the language codes (ISO 639-1, $LANG)
 - ...clarified the "Updating and Merging" description and removed the examples 
as they were pretty useless in my eyes. Correct me if they had a meaning.
 - ...anonymized the bash user
 - ...updated the "New Language" section

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7deb570b617325e4899e6119693a1e218e6feb2c
Author: Jonas Thelemann 

Modified Files
--
docs/en_US/translations.rst | 105 
1 file changed, 28 insertions(+), 77 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

[Dave Page]

Unfortunately I had to revert this, as I found it was preventing
treeview nodes from being collapsed again. I'm running in Google
Chrome on Mac, if that helps narrow down the problem.

On Tue, Apr 18, 2017 at 2:01 PM, Dave Page  wrote:
> Thanks, patch applied.
>
> On Fri, Apr 14, 2017 at 5:02 AM, Khushboo Vashi
>  wrote:
>> Hi,
>>
>> Please find the attached patch to fix the RM #2339: Horizontal scrolling in
>> the treeview.
>>
>> I wanted to change the pgadmin.css file to fix this issue but the aciTree
>> library is located at browser/static/vendor/, so I have included this change
>> in the browser/static/css/browser.css file.
>>
>>
>> Thanks,
>> Khushboo
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Revert "Ensure the treeview can be scrolled horizonta

[Dave Page]

Revert "Ensure the treeview can be scrolled horizontally. Fixes #2339"

This reverts commit 78c25cef21dcffed695494caa93c3e16b3114b47 which apparently 
prevents tree nodes being collapsed.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f6041b2a77c05147d6007115d723acdf8e85f4c

Modified Files
--
web/pgadmin/browser/static/css/browser.css | 4 
1 file changed, 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2318: Fixed Foreign Table column order

[Dave Page]

Thanks, patch applied.

On Fri, Apr 14, 2017 at 6:05 AM, Khushboo Vashi
 wrote:
> Hi,
>
> Please find the attached patch to fix the RM #2318: Foreign Table create
> script puts columns in alphabetical order instead of the actual order of the
> columns as the table was originally created
>
> Fixed the column order in get_columns.sql template for PG 9.5 and above.
> Other than this templates have the correct order.
>
> Thanks,
> Khushboo
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Order foreign table columns correctly. Fixes #2318

[Dave Page]

Order foreign table columns correctly. Fixes #2318

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d6add13c06bbd92a581a6044b2efc92cfa29df0
Author: Khushboo Vashi 

Modified Files
--
.../templates/foreign_tables/sql/9.5_plus/get_columns.sql   | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

[Dave Page]

On Tue, Apr 18, 2017 at 2:10 PM, Devrim Gündüz  wrote:
>
> Hi Dave,
>
> On Tue, 2017-04-18 at 09:12 +0100, Dave Page wrote:
>> Yeah, we see that with Python 2.6. Don't worrk about it.
>
> Ok, but this is treated as an error, and the build stops there.

Oh, sorry - I was looking at the deprecation warnings, and didn't see
the error there.

What Sphinx version do you have?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

[Devrim Gündüz]

Hi Dave,

On Tue, 2017-04-18 at 09:12 +0100, Dave Page wrote:
> Yeah, we see that with Python 2.6. Don't worrk about it.

Ok, but this is treated as an error, and the build stops there.

Regards,
-- 
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

[Dave Page]

Thanks, patch applied.

On Fri, Apr 14, 2017 at 5:02 AM, Khushboo Vashi
 wrote:
> Hi,
>
> Please find the attached patch to fix the RM #2339: Horizontal scrolling in
> the treeview.
>
> I wanted to change the pgadmin.css file to fix this issue but the aciTree
> library is located at browser/static/vendor/, so I have included this change
> in the browser/static/css/browser.css file.
>
>
> Thanks,
> Khushboo
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure the treeview can be scrolled horizontally. Fix

[Dave Page]

Ensure the treeview can be scrolled horizontally. Fixes #2339

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=78c25cef21dcffed695494caa93c3e16b3114b47
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/browser/static/css/browser.css | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

[Dave Page]

Thanks, patch applied.

On Fri, Apr 14, 2017 at 4:20 AM, Khushboo Vashi
 wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Sat, Apr 1, 2017 at 12:12 PM, Dave Page  wrote:
>>
>> Hi
>>
>>
>> On Friday, March 31, 2017, Khushboo Vashi
>>  wrote:
>>>
>>> Hi,
>>>
>>> On Mon, Mar 27, 2017 at 9:57 PM, Dave Page  wrote:

 On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi
  wrote:
 > Hi Dave,
 >
 > I have fixed the issue and the patch for the same is attached, but the
 > Binary path options are not translated properly.

 Thanks - committed.

 > We register the preferences before the first request of the app. In
 > this
 > case we don't have any language loaded, so it will take only English.
 > To fix this issue, I had explicitly added gettext for the labels and
 > help
 > messages while opening the Preference dialogue.
 > All the labels and help messages render properly except Binary paths;
 > as at
 > run time we don't get the translation of 'EDB Advanced Server Binary
 > Path'.
 > We have translations like below:
 >
 > #: pgadmin/browser/server_groups/servers/types.py:59
 > msgid "{0} Binary Path"
 > msgstr "Ścieżka Binarna {0}"
 >
 > So, in this case my suggestion is to have the entire label/help
 > messages
 > translations.
 > So, that the Preference dialogue can translate run time.

 I'm fine with that; however, the strings should come from the
 underlying drivers of course, as only they should have specific
 knowledge of details such as the name of the database server they
 provide access to.

>>> The string always comes from drivers as they are being registered from
>>> there.
>>> I have attached the patch to translate the entire string.
>>> I took the reference of the string from the messages.po file and
>>> translated, so someone has to validate that this is the correct translation.
>>
>>
>> All I see in the patch is updates to the message catalog. It seems to me
>> there should be chunks in there to push the entire string back into the
>> relevant driver, otherwise the changes to the messages.po files will be
>> overwritten the next time I do an extract/merge.
>>
>> Essentially, I think we need to add properties to the drivers, such as:
>>
>> BIN_PATH_LABEL = _("PostgreSQL Binary Path")
>> BIN_PATH_HELP = _("Path to the directory containing the PostgreSQL utility
>> programs (pg_dump, pg_restore etc).")
>>
>> Then in types.py, we'd have something like:
>>
>> st.utility_path = paths.register(
>> 'bin_paths', st.stype + '_bin_dir',
>> st.BIN_PATH_LABEL,
>> 'text', default_path, category_label=_('Binary paths'),
>> help_str=st.BIN_PATH_HELP
>> )
>> )
>>
> Fixed
>>
>> Thanks.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure database driver names and description strings

[Dave Page]

Ensure database driver names and description strings can be translated. Fixes 
#2190

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a3007b7335d73cb2042cf4b2d3939b69ae4bcaac
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/browser/server_groups/servers/ppas.py  |  6 ++
web/pgadmin/browser/server_groups/servers/types.py | 14 +++---
2 files changed, 13 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

[Dave Page]

Thanks - patch committed!

On Wed, Apr 12, 2017 at 10:00 PM, Matthew Kleiman  wrote:
> Hi Dave,
>
> We have found the source of this bug and fixed it in the attached patch.
> If this revised patch addresses the copy issues you pointed out, it can be
> pulled into master.
>
> Please note that we'll be working on a few more stories around column
> selection styling, e.g. removal of checkboxes. See email thread with subject
> "[pgadmin-hackers] [Design Update] Visual design of query editor and results
> table" for details.
> We will change the styling of this patch as part of that work.
>
> Best,
> George and Matt
>
>
>
>
>
>
> On Mon, Apr 10, 2017 at 11:13 AM, Dave Page  wrote:
>>
>> Hi
>>
>> On Mon, Apr 10, 2017 at 4:01 PM, Matthew Kleiman 
>> wrote:
>> > Hi Dave,
>> >
>> >> Unfortunately I found another regression; I have a test table called
>> >> موسيقى (Arabic for music) which if included in a selection of rows,
>> >
>> > Could you share the queries that:
>> > - create this table
>>
>> CREATE TABLE public."موسيقى"
>> (
>> )
>>
>> > - populate it with data
>>
>> It doesn't have any - there are no columns in it.
>>
>> > - access it leading to the regression
>>
>> SELECT * FROM pg_tables
>>
>> or
>>
>> SELECT * FROM pg_class
>>
>> in the Query Tool.
>>
>> > What user interaction are you performing to trigger the behavior (is it
>> > the
>> > query tool or something else)?
>>
>> Run the select query in the query tool, select the rows, then hit Copy.
>>
>> Note that I think the issue with columns is the editor I was using. If
>> I paste into vim, I can't reproduce that. The row issue is
>> consistently reproducible though.
>>
>> > It would also help if you could attach a screenshot of the issue.
>>
>> Attached.
>>
>> >
>> > Thanks,
>> > George & Matt
>> >
>> >
>> >
>> > On Mon, Apr 10, 2017 at 5:52 AM Dave Page  wrote:
>> >>
>> >> Hi Matt,
>> >>
>> >> On Fri, Apr 7, 2017 at 10:56 PM, Matthew Kleiman 
>> >> wrote:
>> >> > Hi Dave,
>> >> >
>> >> > I've updated the attached patch to include a change to the "Paste
>> >> > Rows"
>> >> > button. It will now be enabled only if there are rows on the
>> >> > clipboard.
>> >>
>> >> Unfortunately I found another regression; I have a test table called
>> >> موسيقى (Arabic for music) which if included in a selection of rows,
>> >> seems to ensure that it and any preceding rows are excluded from the
>> >> copy. If I include it in a selection of columns, then things get weird
>> >> as the pasted output for that row will sometimes - but not always -
>> >> seem to have the column order moved around (maybe because it's an RTL
>> >> language).
>> >>
>> >> Obviously the second issue doesn't apply to the current code, but
>> >> copying rows does seem to work properly at present, so I'm afraid I
>> >> need to bump this back to you again.
>> >>
>> >> > Good luck with the release on Monday morning!
>> >>
>> >> Thanks!
>> >>
>> >> > On Fri, Apr 7, 2017 at 4:12 PM, Matthew Kleiman 
>> >> > wrote:
>> >> >>
>> >> >> Hi Dave
>> >> >>
>> >> >> The attached patch now includes a fix for the regression you found.
>> >> >> When
>> >> >> the query tool is in edit mode, the user can copy rows and paste
>> >> >> them.
>> >> >> I've
>> >> >> also removed the two lines from copy_data.js that you mentioned so
>> >> >> that
>> >> >> users can copy from the table even after they have copied once.
>> >> >>
>> >> >> I have noticed that the "Paste Rows" button remains enabled even if
>> >> >> only
>> >> >> columns are copied. Although pressing this button won't do anything
>> >> >> unless
>> >> >> rows have been copied to the clipboard, this might prove confusing
>> >> >> to
>> >> >> users.
>> >> >> I am going to look at disabling this button until rows are in the
>> >> >> clipboard.
>> >> >> I will let you know if I have anything for you by the end of today.
>> >> >>
>> >> >> Best,
>> >> >> Matt
>> >> >>
>> >> >> On Fri, Apr 7, 2017 at 10:27 AM, Dave Page 
>> >> >> wrote:
>> >> >>>
>> >> >>> On Fri, Apr 7, 2017 at 2:49 PM, Atira Odhner 
>> >> >>> wrote:
>> >> >>> >> The one tweak I made to the patch was to remove the code that
>> >> >>> >> disabled
>> >> >>> >> the Copy button from the top of copy_data.js. I think the button
>> >> >>> >> should remain enabled to allow the user to copy again, in case
>> >> >>> >> they
>> >> >>> >> use the clipboard for something else and then need to refresh it
>> >> >>> >> with
>> >> >>> >> the data. Of course, it should still be disabled when there is
>> >> >>> >> nothing
>> >> >>> >> selected that can be copied.
>> >> >>> >
>> >> >>> > Yes, the copy button enablement behavior was a bit strange.  I'm
>> >> >>> > glad
>> >> >>> > you
>> >> >>> > found a fix for it. Do you mind sending us your updated patch?
>> >> >>>
>> >> >>> I literally just removed lines 5 & 6 of copy_data.js.
>> >> >>>
>> >> >>> >> Any 

[pgadmin-hackers] pgAdmin 4 commit: Allow column or row selection in the query tool. Fixe

[Dave Page]

Allow column or row selection in the query tool. Fixes #2216

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d663d553c55fbb5cdbe172d5c8780b777815de00
Author: Matthew Kleiman 

Modified Files
--
docs/en_US/images/query_output_data.png| Bin 62119 -> 52290 bytes
.../copy_selected_query_results_feature_test.py|  76 +++
web/pgadmin/static/js/selection/column_selector.js |  92 
web/pgadmin/static/js/selection/copy_data.js   |  52 +
web/pgadmin/static/js/selection/grid_selector.js   |  79 +++
.../js/selection/range_boundary_navigator.js   | 111 ++
.../static/js/selection/range_selection_helper.js  |  78 +++
web/pgadmin/static/js/selection/row_selector.js|  85 
.../tools/datagrid/templates/datagrid/index.html   |   2 +-
.../tools/sqleditor/static/css/sqleditor.css   |  15 +-
.../sqleditor/templates/sqleditor/js/sqleditor.js  |  61 +-
web/regression/README  |   7 +
web/regression/feature_utils/base_feature_test.py  |   1 +
web/regression/feature_utils/pgadmin_page.py   |  11 +
.../javascript/selection/column_selector_spec.js   | 235 +
.../javascript/selection/copy_data_spec.js | 119 +++
.../javascript/selection/grid_selector_spec.js | 126 +++
.../selection/range_boundary_navigator_spec.js | 158 ++
.../javascript/selection/row_selector_spec.js  | 174 +++
web/regression/python_test_utils/test_utils.py |   3 +
web/regression/requirements.txt|   1 +
21 files changed, 1427 insertions(+), 59 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin website commit: Correct link to downloads, per Devrim.

[Dave Page]

Correct link to downloads, per Devrim.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=10f2959b2442f1896b458d916e9c58b268d673ce

Modified Files
--
download/index.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

[Dave Page]

Yeah, we see that with Python 2.6. Don't worrk about it.

On Mon, Apr 17, 2017 at 9:41 PM, Devrim Gündüz  wrote:
>
> Hi,
>
> This is new in 1.4: Any suggestions?
>
> --
> sphinx-1.0-build -W -b html -d _build/doctrees   . _build/html
> Making output directory...
> Running Sphinx v1.0.8
> /usr/lib/python2.6/site-packages/flask_security/forms.py:67: 
> DeprecationWarning: Required is going away in WTForms 3.0, use DataRequired
>   email_required = Required(message='EMAIL_NOT_PROVIDED')
> /usr/lib/python2.6/site-packages/flask_security/forms.py:69: 
> DeprecationWarning: Required is going away in WTForms 3.0, use DataRequired
>   password_required = Required(message='PASSWORD_NOT_PROVIDED')
> loading pickled environment... not yet created
> building [html]: targets for 87 source files that are out of date
> updating environment: 87 added, 0 changed, 0 removed
> reading sources... [100%] view_dialog
>
> Warning, treated as error:
> /var/lib/pgsql/rpm/BUILD/pgadmin4-1.4/docs/en_US/connect_error.rst:4: ERROR: 
> Interpreted text role "index" not implemented.
>
>
> Regards,
> --
> Devrim Gündüz
> EnterpriseDB: http://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

[Dave Page]

On Thu, Apr 13, 2017 at 4:43 PM, Robert Eckhardt  wrote:
 Is that a new shade of gray? How many do we have now? It looks to me
 like it's starting to get messy, with too many different variations of gray
 plus the light blues used for the codemirror gutter and alternate rows in
 the grid.
>>>
>>>
>>> Yes, it is a darker shade of gray. Are you concerned with the number of
>>> variations on gray, or that the grays are not used appropriately?
>>
>>
>> Both really.
>
>
> The shade of gray, I think, doesn't really matter that much and remaining
> consistent within the app is fine as long as there is sufficient contrast.

I disagree. There should be a defined set of colours, otherwise the
application will look haphazard and random. The use of different
contrasts can help focus the user on the appropriate part (or parts,
which are also often important) of the screen.

> The use of gray is intentional. The idea being that the eye should be drawn
> only to the area the user is actively working on.  In the picture the area
> of focus is the query text editor and the blue bar above it actually draws
> the eye there. After the user decides they need to inspect the results
> adding blue there makes those results pop.

Exactly.

> Let me state what I think your concerns are:
>
> The application is becoming too monochromatic and washed out
> the application is becoming too 'flat'

Right - and for an example, just Google for the fallout after
Microsoft flattened the look of visual studio. Many people were vocal
that they didn't like it and felt it made it harder to use.

> I think we agree that both of these things could be problematic, my guess is
> where we don't agree is on the line.
>
> Here are the assumptions we are designing to:
>
> users are going to be on the application for multiple hours per day
> a softer aesthetic makes it easier on the eyes for long term use.
> color is important to make the product appealing
> use of color should be intentional and done to change the users focus.

Right - but we also need to keep in mind that there are usually
multiple areas of the screen that the user needs to be able to focus
on quickly - for example, the text editor may be the primary area, and
button bar the secondary. They need to be clearly delineated so that
users can quickly discern each area, and focus on either as needed.

However, we should also not ignore other important visual indicators.
For users with multiple query tools running at once (perhaps in
different databases or on different servers), the info bar that shows
which server you are on is critically important to help prevent
running queries on the wrong database and potentially destroying data.

> To my knowledge we haven't don't anything to make the application more or
> less flat.

Yes - the last point above for example; the info bar has been made
gray so it a) flattens the look and b) stops it standing out. I would
argue that absolutely needs to be a prominent colour; maybe not the
blue it currently is, but certainly something that makes it clearly
visible. Pastel colours are easy on the eye, so maybe the soft blue we
use, or a soft yellow would work.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Problems editing Queries with pgAdmin4

[Christian Espinoza]

Hi,

How can I report an issue for pgadmin4? I've had a lot of problems editing
queries in the last version (4), today I upgraded to the last release and
the problem is there yet.

When one is modifying any query even a new one, the editor freezes some
text zones, and
is impossible edit it, I don't understand why it happens, seems a
html editor bug.

Thanks.

Version
1.4
Copyright
Copyright 2013 - 2017, The pgAdmin Development Team
Python Version
2.7.10 (default, Jul 30 2016, 19:40:32) [GCC 4.2.1 Compatible Apple LLVM
8.0.0 (clang-800.0.34)]
Flask Version
0.11.1
Application Mode
Desktop
Current User
pgadm...@pgadmin.org