[pgadmin-hackers] pgAdmin 4 commit: Use a different server name for unit vs. feature test

Use a different server name for unit vs. feature tests to avoid some observed conflicts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4acecfa59a650369f14e1f61db8816e4eb13718a Author: Sarah McAlear Modified Files -- web/regress

Re: [pgadmin-hackers][Patch] Rename feature test server

Thanks, applied. On Thu, Apr 27, 2017 at 10:22 PM, Sarah McAlear wrote: > Hi Hackers! > > We realized that the feature tests and unit tests were using the same > server, which was causing some flakiness when running the tests. This patch > renames the server for the feature tests. > > Thanks! >

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

Hi When testing on Mac, the testsuite never exits with this patch applied. It just hangs after printing the result summary. On Fri, Apr 28, 2017 at 2:51 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the patch for OS compatability issue of test-s

[pgadmin-hackers] pgAdmin 4 commit: Ensure errors thrown when deleting rows in the query

Ensure errors thrown when deleting rows in the query tool in edit mode are shown properly. Fixes #2356 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93df5e3e54ee2546e618531a4dedbe44d8659bde Author: Surinder Kumar Modified Files ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Delete row server error not shown to GUI user

Thanks, patch applied. On Fri, Apr 28, 2017 at 11:48 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > The variable list_of_rowid doesn't keep track of rows to be deleted. > If this list is empty simply return 0 since '_rowid' is being used to > highlight the row for which err

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi, This is looking much better now :-). Couple of thoughts and a bug: - Only the TextFormatter seems to handle both [null] and [default] values. Shouldn't all formatters do so (including Json and Checkmark)? For example, "serial" columns currently get displayed as [null] when left blank, but I w

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, On Tue, May 2, 2017 at 5:21 PM, Dave Page wrote: > Hi, > > This is looking much better now :-). Couple of thoughts and a bug: > > - Only the TextFormatter seems to handle both [null] and [default] values. > Shouldn't all formatters do so (including Json and Checkmark)? > ​Yes, I will ap

[pgadmin-hackers] pgadmin4 on PyPI

Hi, thanks for creating pgAdmin 4! It's awesome that pgAdmin is now a web application. I installed pgAdmin 4 successfully from the PostgreSQL FTP[1] using pip. I also tried to install it from PyPI, but the distribution hasn't been upload there. Having pgAdmin 4 available on PyPI would make the i

Re: [pgadmin-hackers] pgadmin4 on PyPI

Hi On Tue, May 2, 2017 at 10:44 AM, Markus Zapke-Gründemann < mar...@transcode.de> wrote: > Hi, > > thanks for creating pgAdmin 4! It's awesome that pgAdmin is now a web > application. > You're welcome. > > I installed pgAdmin 4 successfully from the PostgreSQL FTP[1] using pip. > I also tried

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

Hi On Tue, May 2, 2017 at 2:46 PM, Akshay Joshi wrote: > Hi All > > To implement Declarative Partitioning in existing Table dialog > below changes should be implemented: > >1. *Icon: *As we have separate icon for view and materialised view, we >should have for partition table. I didn't f

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Hackers & Ashesh! Is there anything else we can do for this? Thanks! Matt & Sarah On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Thanks for reviewing, Ashesh. > > We have updated the patch. The headers are all consistent and we remove

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Tue, May 2, 2017 at 10:56 AM Dave Page wrote: > Hi > > On Tue, May 2, 2017 at 2:46 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> To implement Declarative Partitioning in existing Table dialog >> below changes should be implemented: >> >>1. *Icon: *As we have

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

Hi Shirley On Wed, May 3, 2017 at 3:31 AM, Shirley Wang wrote: > > > On Tue, May 2, 2017 at 10:56 AM Dave Page wrote: > >> Hi >> >> On Tue, May 2, 2017 at 2:46 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> To implement Declarative Partitioning in existing Tab

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

Hi Dave, I have applied and run this patch on Mac and it ran successfully without hang up. I used different OS: OS X Yosemite Version 10.10.2 OS X EI Capitan Version 10.11.6 What is your system config? On Tue, May 2, 2017 at 4:39 PM, Dave Page wrote: > Hi > > When te